[NoQA] Migrate RNEF to ROCK by rinej · Pull Request #69350 · Expensify/App

rinej · 2025-08-27T12:06:49Z

Explanation of Change

Added migration from React Native Enterprise Framework to Rock to align with recent changes.
Additionally, upgraded to the latest framework version to ensure compatibility and take advantage of recent improvements.

Fixed Issues

$ #69950

MOBILE-EXPENSIFY: https://github.com/Expensify/Mobile-Expensify/pull/13669

Tests

Offline tests

QA Steps

Verify that Remote Build iOS and Remote Build Android are not failing

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I verified there are no new alerts related to the canBeMissing param for useOnyx
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

github-actions · 2025-08-27T12:06:59Z

⚠️ This PR is possibly changing native code and/or updating libraries, it may cause problems with HybridApp. Please check if any patch updates are required in the HybridApp repo and run an AdHoc build to verify that HybridApp will not break. Ask Contributor Plus for help if you are not sure how to handle this. ⚠️

adhorodyski · 2025-09-01T08:22:05Z

+          git fetch origin pull/${{ github.event.inputs.mobile_expensify_pr }}/head:pr-${{ github.event.inputs.mobile_expensify_pr }}
+          git checkout pr-${{ github.event.inputs.mobile_expensify_pr }}
+          echo "Checked out Mobile-Expensify PR #${{ github.event.inputs.mobile_expensify_pr }}"
+      - name: Rock Remote Build - Android


newline missing

adhorodyski · 2025-09-01T08:22:35Z

+          git fetch origin pull/${{ github.event.inputs.mobile_expensify_pr }}/head:pr-${{ github.event.inputs.mobile_expensify_pr }}
+          git checkout pr-${{ github.event.inputs.mobile_expensify_pr }}
+          echo "Checked out Mobile-Expensify PR #${{ github.event.inputs.mobile_expensify_pr }}"
+      - name: Rock Remote Build - iOS


same, newline

roryabraham · 2025-09-03T05:08:52Z

Is there somewhere I can read a slack proposal for this change? I had a good amount of involvement in discussions around rnef (including in the context of AdHoc builds) up to this point, so I'm confused about this PR. I don't remember discussing using a new package

rinej · 2025-09-05T10:24:36Z

@roryabraham
Here is the Slack thread (the same one as for AdHocs) – https://callstack-hq.slack.com/archives/C01GTK53T8Q/p1756996593648849?thread_ts=1753228474.755499&cid=C01GTK53T8Q.

To clarify, this PR is not introducing a new package but simply updating the existing one.
“RNEF” was a temporary name, and it has since been officially renamed and rebranded as Rock. The official documentation is available here:
https://www.rockjs.dev/docs/getting-started/introduction

Apologies for any confusion. We want to ensure we are on the most recent version before adding AdHoc support, so that everything remains consistent up from that point and avoids issues in the future.

adhorodyski · 2025-09-05T10:44:28Z

    - ReactCommon/turbomodule/bridging
    - ReactCommon/turbomodule/core
    - Yoga
+  - ExpoSecureStore (14.2.4):


I'm not sure if these changes are required, maybe main is outdated?

it was already bumped up on main, I merged main and run pod install script again 👍

adhorodyski · 2025-09-05T10:46:08Z

@roryabraham https://www.callstack.com/blog/react-native-enterprise-framework-is-now-rock

roryabraham · 2025-09-05T14:17:48Z

Thanks for explaining, sorry for the confusion

melvin-bot · 2025-09-08T12:19:10Z

@truph01 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

mountiny

Just a small comment here, we have tested successfully here https://expensify.slack.com/archives/C01GTK53T8Q/p1757332812179609?thread_ts=1753228474.755499&cid=C01GTK53T8Q
https://github.com/Expensify/App/actions/runs/17550017382

@roryabraham all yours

mountiny · 2025-09-08T12:39:53Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

roryabraham · 2025-09-08T19:05:14Z

  - RNSound/Core (0.11.2):
    - React-Core
-  - RNSVG (15.12.1):
+  - RNSVG (15.9.0):


Some sus dependency changes in this Podfile.lock? Why is RNSVG affected?

I saw some unrelated changes but assumed that is something that is a diff from main already. @rinej can you please confirm? related proposal https://expensify.slack.com/archives/C05LX9D6E07/p1757074711334269

I don't have access to the shared link, unfortunately.

Those changes are just from running pod-install-standalone script, which I run after modifying the command in Podfile. I was needed to pass the Verify Podfile gh check. But those changes are no related to the migration🤔

Ok so that confirms this is just the diff that exists in main and the verifyPodfile action might not be working the best

Actually, I don't think it was something from the main branch

I bumped react-native-svg and RNSVG should be in v15.12.1
I can see those changes now when running npm run pod-install-standalone (on the main) so those changes are mistakenly added in this PR

@mountiny should I create a separate PR fixing this, or should @rinej take care of it?

mountiny

Thanks!

OSBotify · 2025-09-09T14:20:00Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2025-09-10T23:29:26Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.2.9-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2025-09-11T11:10:45Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.2.11-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2025-09-12T00:16:19Z

🚀 Deployed to production by https://github.com/francoisl in version: 9.2.12-4 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

rinej added 11 commits August 26, 2025 16:55

refactor: migrate rnef to rock

c845656

adjust to rock 0.9.0

c2a1bb7

adjust rock naming

911885a

adjust to version 0.9.0

4050e86

fix ios build script

e1a7e84

adjust rock config for testing

0d1a1f0

use different commit

987e1ee

use most recent commit

4fa2211

prettier and cspell migration

942f082

update README

7de771d

remove testing data

f9535d3

melvin-bot Bot assigned rinej Aug 27, 2025

rinej added 6 commits August 28, 2025 13:47

install pods

3962c41

syntax fixes

91633a6

adjust .gitignore

5b6dbda

Merge branch 'main' into Migrate-rnef-to-rock

19e3ebc

install pods

78491dc

add ability to build with specific Mobile-Expensify version

d72c402

adhorodyski reviewed Sep 1, 2025

View reviewed changes

fix formatting

e0529bb

rinej mentioned this pull request Sep 1, 2025

[Due for payment 2026-01-07] Remote builds cache: integrate into Adhoc builds #62296

Closed

rinej added 2 commits September 5, 2025 12:13

Merge branch 'main' into Migrate-rnef-to-rock

a375ecd

pod install

4144cbf

adhorodyski reviewed Sep 5, 2025

View reviewed changes

rinej added 4 commits September 8, 2025 10:42

Merge branch 'main' into Migrate-rnef-to-rock

85002a4

merge main and install pods

fc78426

revert podfile

8665b67

run pod install command

724d3b5

rinej marked this pull request as ready for review September 8, 2025 12:19

rinej requested a review from a team as a code owner September 8, 2025 12:19

melvin-bot Bot requested a review from truph01 September 8, 2025 12:19

melvin-bot Bot removed the request for review from a team September 8, 2025 12:19

rinej mentioned this pull request Sep 8, 2025

Migrate from RNEF to Rock #69950

Closed

mountiny changed the title ~~Migrate RNEF to ROCK~~ [NoQA] Migrate RNEF to ROCK Sep 8, 2025

mountiny added the InternalQA This pull request required internal QA label Sep 8, 2025

mountiny requested review from mountiny and roryabraham and removed request for truph01 September 8, 2025 12:37

mountiny previously approved these changes Sep 8, 2025

View reviewed changes

Comment thread .gitignore Outdated

adjust gitignore

2b1dfbb

rinej dismissed mountiny’s stale review via 2b1dfbb September 8, 2025 14:22

roryabraham reviewed Sep 8, 2025

View reviewed changes

Merge branch 'main' into Migrate-rnef-to-rock

ab257e4

mountiny approved these changes Sep 9, 2025

View reviewed changes

mountiny merged commit 8494e69 into Expensify:main Sep 9, 2025
30 checks passed

OSBotify mentioned this pull request Sep 10, 2025

Deploy Checklist: New Expensify 2025-09-10 #70325

Closed

Conversation

rinej commented Aug 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

github-actions Bot commented Aug 27, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

roryabraham commented Sep 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rinej commented Sep 5, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

adhorodyski commented Sep 5, 2025

Uh oh!

roryabraham commented Sep 5, 2025

Uh oh!

melvin-bot Bot commented Sep 8, 2025

Uh oh!

mountiny left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

mountiny commented Sep 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rinej Sep 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mountiny left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

OSBotify commented Sep 9, 2025

Uh oh!

OSBotify commented Sep 10, 2025

Uh oh!

OSBotify commented Sep 11, 2025

Uh oh!

OSBotify commented Sep 12, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

rinej commented Aug 27, 2025 •

edited

Loading

roryabraham commented Sep 3, 2025 •

edited

Loading

mountiny commented Sep 8, 2025 •

edited

Loading

rinej Sep 9, 2025 •

edited

Loading