Reduce useonyx calls in transaction item by martasudol · Pull Request #69416 · Expensify/App

martasudol · 2025-08-28T06:36:35Z

Explanation of Change

This PR reduces useOnyx calls in TransactionItemRowRBRWithOnyx by passing transaction's violations in props.

Fixed Issues

$#67165
PROPOSAL: Reduce useOnyx calls on list-item level in TransactionItemRowRBRWithOnyx
Background:
The transaction list displays many items per report, each rendering with related data like violations. These components rely on hooks to fetch the data required for each item.

Problem:
When each transaction item makes multiple data subscriptions via useTransactionViolations hook, it causes excessive re-renders and slowness in large transaction lists.

Solution:
Move violation data fetching to the parent transaction list component to perform a single shared subscription. Pass the resulting violation data down as props (part of transaction) to child components like TransactionItemRowRBRWithOnyx. This pattern reduces subscriptions from N×4 per report to 1, significantly improving rendering performance while preserving all existing functionality.

=== 📁 Trace File Analysis ===

📄 File: open-report-BEFORE.json
  • Commit count: 62
  • Total render duration: 1551.320 ms
  • p50 / p95 / p99 (ms):
    • p50: 6.170 ms
    • p95: 103.118 ms
    • p99: 135.421 ms

📄 File: open-report-AFTER.json
  • Commit count: 59
  • Total render duration: 1380.853 ms
  • p50 / p95 / p99 (ms):
    • p50: 6.218 ms
    • p95: 115.744 ms
    • p99: 141.160 ms

=== 📊 Trace Comparison ===

🔁 Comparing Baseline ↔️ open-report-AFTER.json
  🟢 Duration Diff: -170.467 ms (-11.0%)
  🟢 Commit Count Diff: -3

=== 📁 Trace File Analysis ===

📄 File: scrolling-reports-tab-BEFORE.json
  • Commit count: 35
  • Total render duration: 667.497 ms
  • p50 / p95 / p99 (ms):
    • p50: 0.813 ms
    • p95: 141.052 ms
    • p99: 217.287 ms

📄 File: scrolling-reports-tab-AFTER.json
  • Commit count: 30
  • Total render duration: 606.387 ms
  • p50 / p95 / p99 (ms):
    • p50: 0.812 ms
    • p95: 118.306 ms
    • p99: 197.429 ms

=== 📊 Trace Comparison ===

🔁 Comparing Baseline ↔️ scrolling-reports-tab-AFTER.json
  🟢 Duration Diff: -61.110 ms (-9.2%)
  🟢 Commit Count Diff: -5

Tests

Navigate to Reports tab and verify if list is rendered correctly
Navigate to a single expense report and verify if it renders correctly.
Verify if transaction with violation(s) renders correctly (in the transactions list and in a single item screen).
Verify if violation messages display correctly in header.
As an example flow:

Create a new expense with missing receipt
Verify: "Missing receipt" violation appears
Add the receipt
Verify: Violation disappears
Hold an expense
Verify: Hold status shows correctly
Verify that no errors appear in the JS console

Offline tests

Same as Tests.

QA Steps

Same as Tests.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

android-native.mov

Android: mWeb Chrome

android-web.mov

iOS: Native

ios-native.mov

iOS: mWeb Safari

ios-web.mov

MacOS: Chrome / Safari

chrome-web.mov

MacOS: Desktop

desktop-aa.mov

melvin-bot · 2025-08-28T09:18:39Z

@dukenv0307 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

mountiny · 2025-08-28T15:46:18Z

@dukenv0307 are you available for the review?

dukenv0307 · 2025-08-28T15:47:20Z

@mountiny Yeah, I'll review in 10 minutes

dukenv0307 · 2025-08-28T16:16:54Z

Looks good, left some minor comments

dukenv0307 · 2025-08-28T16:34:23Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Screen.Recording.2025-08-28.at.23.31.39.mov

Android: mWeb Chrome

Screen.Recording.2025-08-28.at.23.30.38.mov

iOS: HybridApp

Screen.Recording.2025-08-28.at.23.33.05.mov

iOS: mWeb Safari

Screen.Recording.2025-08-28.at.23.29.51.mov

MacOS: Chrome / Safari

Screen.Recording.2025-08-28.at.23.27.14.mov

MacOS: Desktop

Screen.Recording.2025-08-28.at.23.33.58.mov

dukenv0307 · 2025-08-28T16:35:33Z

There're some minor issues so when you resolve them we're good to merge

martasudol · 2025-08-29T08:05:24Z

@dukenv0307 I addressed your comments, thanks!

martasudol · 2025-09-05T08:11:47Z

@mountiny it's ready for review - I moved violations from transaction object to a separate prop.

martasudol · 2025-09-08T06:06:02Z

@mountiny kindly reminder about review 🙏

mountiny

Thanks! @martasudol there are conflicts now, but wanted to confirm, have you measured the performance on this branch and does it give the same benefits?

martasudol · 2025-09-09T06:13:34Z

Thanks! @martasudol there are conflicts now, but wanted to confirm, have you measured the performance on this branch and does it give the same benefits?

@mountiny conflicts resolved. I measured it and it gives the same benefits.

amyevans

Awesome, glad to hear the performance benefits are unchanged. Code looks good to me!

@mountiny want to take a final look?

mountiny

Thanks

OSBotify · 2025-09-09T16:04:50Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

…s-in-transaction-item Reduce useonyx calls in transaction item (cherry picked from commit 3bfe224) (cherry-picked to staging by francoisl)

OSBotify · 2025-09-10T00:46:55Z

🚀 Cherry-picked to staging by https://github.com/francoisl in version: 9.2.8-1 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

dangrous · 2025-09-10T15:27:29Z

hi! as linked above - it looks like this might have caused #70256 - can we look into it please?

@daledah has suggested an alternate solution, so we can investigate that as well rather than a revert. thanks!

…nyx-calls-in-transaction-item" This reverts commit 3bfe224, reversing changes made to 271c093.

mountiny · 2025-09-10T19:15:16Z

I see too late now you are moving ahead with the fix, but in case you will need the revert here it is #70317 @dangrous @francoisl

francoisl · 2025-09-10T19:32:50Z

Yeah we CP'ed this PR because it fixed another blocker, so reverting it would also reintroduce that other blocker 🙃 It's best if we go with a fix in this case.

mountiny · 2025-09-10T19:50:08Z

Ahaaa

OSBotify · 2025-09-10T22:59:12Z

🚀 Deployed to production by https://github.com/francoisl in version: 9.2.8-4 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2025-09-10T23:29:51Z

🚀 Cherry-picked to staging by https://github.com/francoisl in version: 9.2.9-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

OSBotify · 2025-09-11T11:11:13Z

🚀 Cherry-picked to staging by https://github.com/francoisl in version: 9.2.11-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

OSBotify · 2025-09-12T00:16:31Z

🚀 Deployed to production by https://github.com/francoisl in version: 9.2.12-4 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

martasudol added 3 commits August 27, 2025 14:35

perf: useTransactionViolations called on a list-item level

d9a2034

Merge branch 'main' into reduce-useonyx-calls-in-transaction-item

8c07d43

prettier

0d50dea

melvin-bot Bot assigned martasudol Aug 28, 2025

martasudol added 9 commits August 28, 2025 08:41

prettier

950410b

unit test

88f51e1

ESLint

228aa25

ESLint

96cd297

ESLint

106af67

ESLint

af73e35

ESLint

6e66914

ESLint

a6e76c6

Merge branch 'main' into reduce-useonyx-calls-in-transaction-item

6d37bb5

martasudol marked this pull request as ready for review August 28, 2025 09:18

martasudol requested a review from a team as a code owner August 28, 2025 09:18

melvin-bot Bot requested review from dukenv0307 and removed request for a team August 28, 2025 09:18

martasudol mentioned this pull request Aug 28, 2025

[Due for payment 2025-09-19] [Due for payment 2025-09-17] Reduce useOnyx calls on list-item level in TransactionItemRowRBRWithOnyx. #67165

Closed

dukenv0307 reviewed Aug 28, 2025

View reviewed changes

Comment thread src/components/MoneyRequestReportView/MoneyRequestReportView.tsx Outdated

dukenv0307 reviewed Aug 28, 2025

View reviewed changes

Comment thread src/pages/home/ReportScreen.tsx Outdated

addressed comments

b764063

martasudol requested a review from a team as a code owner August 29, 2025 08:02

dukenv0307 approved these changes Aug 29, 2025

View reviewed changes

martasudol added 4 commits September 4, 2025 10:45

prettier

7350e1c

prettier

9fff462

Merge branch 'main' into reduce-useonyx-calls-in-transaction-item

f7b1c5b

Merge branch 'main' into reduce-useonyx-calls-in-transaction-item

6116f36

mountiny previously approved these changes Sep 8, 2025

View reviewed changes

Merge branch 'main' into reduce-useonyx-calls-in-transaction-item

ae1496a

martasudol dismissed mountiny’s stale review via ae1496a September 9, 2025 06:12

amyevans approved these changes Sep 9, 2025

View reviewed changes

mountiny approved these changes Sep 9, 2025

View reviewed changes

mountiny merged commit 3bfe224 into Expensify:main Sep 9, 2025
22 checks passed

francoisl mentioned this pull request Sep 9, 2025

Reports - Hold message appears and disappears, menu options do not update #70167

Closed

8 tasks

OSBotify added the CP Staging marks PRs that have been CP'd to staging label Sep 10, 2025

OSBotify mentioned this pull request Sep 10, 2025

Deploy Checklist: New Expensify 2025-09-09 #70157

Closed

83 tasks

dangrous mentioned this pull request Sep 10, 2025

[Due for payment 2025-09-19] [$250] Reports - Error message "This expense was put on hold" appear on the moved expense #70256

Closed

8 tasks

mountiny added a commit that referenced this pull request Sep 10, 2025

Revert "Merge pull request #69416 from callstack-internal/reduce-useo…

b681aaa

…nyx-calls-in-transaction-item" This reverts commit 3bfe224, reversing changes made to 271c093.

mountiny mentioned this pull request Sep 10, 2025

[CP Staging] Revert "Merge pull request #69416 from callstack-internal/reduce-useo… #70317

Closed

51 tasks

Conversation

martasudol commented Aug 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Aug 28, 2025

Uh oh!

mountiny commented Aug 28, 2025

Uh oh!

dukenv0307 commented Aug 28, 2025

Uh oh!

Uh oh!

Uh oh!

dukenv0307 commented Aug 28, 2025

Uh oh!

dukenv0307 commented Aug 28, 2025

Reviewer Checklist

Screenshots/Videos

Uh oh!

dukenv0307 commented Aug 28, 2025

Uh oh!

martasudol commented Aug 29, 2025

Uh oh!

martasudol commented Sep 5, 2025

Uh oh!

martasudol commented Sep 8, 2025

Uh oh!

mountiny left a comment

Choose a reason for hiding this comment

Uh oh!

martasudol commented Sep 9, 2025

Uh oh!

amyevans left a comment

Choose a reason for hiding this comment

Uh oh!

mountiny left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

OSBotify commented Sep 9, 2025

Uh oh!

OSBotify commented Sep 10, 2025

Uh oh!

dangrous commented Sep 10, 2025

Uh oh!

mountiny commented Sep 10, 2025

Uh oh!

francoisl commented Sep 10, 2025

Uh oh!

mountiny commented Sep 10, 2025

Uh oh!

OSBotify commented Sep 10, 2025

Uh oh!

OSBotify commented Sep 10, 2025

Uh oh!

OSBotify commented Sep 11, 2025

Uh oh!

OSBotify commented Sep 12, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

martasudol commented Aug 28, 2025 •

edited

Loading