Skip to content

fix: Removed \n for different copies of change password#6954

Merged
luacmartins merged 1 commit into
Expensify:mainfrom
mananjadhav:fix/changepassword-copy
Dec 30, 2021
Merged

fix: Removed \n for different copies of change password#6954
luacmartins merged 1 commit into
Expensify:mainfrom
mananjadhav:fix/changepassword-copy

Conversation

@mananjadhav

@mananjadhav mananjadhav commented Dec 30, 2021

Copy link
Copy Markdown
Collaborator

Details

  • Removed \n for different copies of change password

Fixed Issues

$ #6922

Tests

  • Tested for copies on different platforms
  • Tested for Spanish translations as well

QA Steps

  1. Click on the Profile picture to load settings
  2. Go to Security -> Change Password
  3. The copy in subtitle and the new password hint should be as a single sentence.

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

web-password-copy

web-spanish-password-copy

Mobile Web

mweb-password-copy

Desktop

desktop-password-copy

iOS

ios-password-copy

Android

android-password-copy

@mananjadhav mananjadhav requested a review from a team as a code owner December 30, 2021 16:29
@MelvinBot MelvinBot requested review from luacmartins and parasharrajat and removed request for a team December 30, 2021 16:29

@parasharrajat parasharrajat left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@luacmartins luacmartins left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the fix!

@luacmartins luacmartins merged commit fd08d9d into Expensify:main Dec 30, 2021
@OSBotify

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify

OSBotify commented Jan 4, 2022

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by @luacmartins in version: 1.1.24-19 🚀

platform result
🤖 android 🤖 failure ❌
🖥 desktop 🖥 failure ❌
🍎 iOS 🍎 failure ❌
🕸 web 🕸 failure ❌

@OSBotify

OSBotify commented Jan 4, 2022

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by @francoisl in version: 1.1.24-19 🚀

platform result
🤖 android 🤖 failure ❌
🖥 desktop 🖥 failure ❌
🍎 iOS 🍎 failure ❌
🕸 web 🕸 failure ❌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants