[No QA] [Pre RN 0.81] Bump react-native-nitro-sqlite, react-native-nitro-modules & nitro-codegen#69551
Conversation
|
|
|
🚧 @mountiny has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪
|
react-native-nitro-sqlite & react-native-nitro-modulesreact-native-nitro-sqlite, react-native-nitro-modules & nitro-codegen
# Conflicts: # ios/Podfile.lock # package-lock.json # package.json
|
Since this is No QA, should I actually test this? |
|
@jjcoffee Actually, I'm not sure how we should test this bump 🤔 last bump of those deps was marked as cc @mountiny as you can have a broader context Maybe we could test the contacts feature? (importing them when creating the expense) |
# Conflicts: # package-lock.json # package.json
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppandroid-app-2025-09-09_15.24.01.mp4Android: mWeb Chromeandroid-chrome-2025-09-09_15.29.18.mp4iOS: HybridAppios-app-2025-09-09_14.52.44.mp4iOS: mWeb Safariios-safari-2025-09-09_15.00.04.mp4MacOS: Chrome / Safaridesktop-chrome-2025-09-09_15.31.02.mp4MacOS: Desktopdesktop-app-2025-09-09_15.38.02.mp4 |
|
Looks like I can test around these areas:
|
jjcoffee
left a comment
There was a problem hiding this comment.
LGTM! Conflicts need to be resolved though.
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
@mountiny coming from this Slack discussion I think merging this bump caused iOS remote builds to stop working. |
|
🚀 Deployed to staging by https://github.com/roryabraham in version: 9.2.9-0 🚀
|
|
🚀 Deployed to staging by https://github.com/roryabraham in version: 9.2.11-0 🚀
|
|
🚀 Deployed to production by https://github.com/francoisl in version: 9.2.12-4 🚀
|
Explanation of Change
Our current
react-native-nitro-sqliteversion doesn't support RN 0.81 and causes build issues. Let's bump it to the latest versionFixed Issues
$ #65991
PROPOSAL:
MOBILE-EXPENSIFY: https://github.com/Expensify/Mobile-Expensify/pull/13675
Tests
N/A
Offline tests
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop