Skip to content

[No QA]Generate a new GPG key and add it to the .gitignore #6957

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AndrewGable merged 3 commits into from
Dec 30, 2021
Merged

[No QA]Generate a new GPG key and add it to the .gitignore #6957

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b94fa0d
Ignore GPG keys moving forward
AndrewGable Dec 30, 2021
f449051
Update key ID with new key
AndrewGable Dec 30, 2021
8cb9c45
Generate new encrypted GPG private key
AndrewGable Dec 30, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file modified .github/workflows/OSBotify-private-key.asc.gpg
View file
Open in desktop
Binary file not shown.
2 changes: 1 addition & 1 deletion .github/workflows/cherryPick.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ jobs:

- name: Set up git for Botify
run: |
git config user.signingkey DBF63700F60F5530
git config user.signingkey 367811D53E34168C
git config commit.gpgsign true
git config user.name OSBotify
git config user.email infra+osbotify@expensify.com
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/createNewVersion.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ jobs:
run: |
git fetch
git checkout main
git config user.signingkey DBF63700F60F5530
git config user.signingkey 367811D53E34168C
git config commit.gpgsign true
git config user.name OSBotify
git config user.email infra+osbotify@expensify.com
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/deploy.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ jobs:

- name: Set up git for Botify
run: |
git config user.signingkey DBF63700F60F5530
git config user.signingkey 367811D53E34168C
git config commit.gpgsign true
git config user.name OSBotify
git config user.email infra+osbotify@expensify.com
Expand Down Expand Up @@ -77,7 +77,7 @@ jobs:

- name: Set up git for Botify
run: |
git config user.signingkey DBF63700F60F5530
git config user.signingkey 367811D53E34168C
git config commit.gpgsign true
git config user.name OSBotify
git config user.email infra+osbotify@expensify.com
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/updateProtectedBranch.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ jobs:

- name: Set up git for Botify
run: |
git config user.signingkey DBF63700F60F5530
git config user.signingkey 367811D53E34168C
git config commit.gpgsign true
git config user.name OSBotify
git config user.email infra+osbotify@expensify.com
Expand Down
4 changes: 4 additions & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,3 +74,7 @@ fastlane/screenshots

# Storybook build files
storybook-static

# GitHub GPG Keys
.github/workflows/OSBotify-private-key.asc
*.asc

@AndrewGable AndrewGable Dec 30, 2021

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI - I verified via find . -name "*.asc" that there are no other keys that would be unintentionally ignored via this.

@aldo-expensify aldo-expensify Dec 30, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NAB: Just wondering if .github/workflows/OSBotify-private-key.asc is already included in *.asc

@AndrewGable AndrewGable Dec 30, 2021

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be yes, but this is somewhat a safety net just in case we ever change the name of the key. I could remove .github/workflows/OSBotify-private-key.asc if it's too redundant.

@aldo-expensify aldo-expensify Dec 30, 2021

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess I was double checking that it was intentional, I'm ok if you want to leave it there to be more explicit as it doesn't cause any problem :P, changing my comment to NAB.

@rafecolton rafecolton Dec 30, 2021

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's ok to leave it