fix: remove other occurrences of ShowMoreButton and the component by koko57 · Pull Request #69599 · Expensify/App

koko57 · 2025-09-01T11:50:58Z

Explanation of Change

Fixed Issues

$ #68866
PROPOSAL:

Tests

Find lists that can have more than 50 entries and use SelectionList component - like Category list, Tag list
Scroll down the list
Verify that after scrolling to the 50th element the Show More button doesn't appear
Verify that the next elements are loaded and you can continue scrolling down

Verify that no errors appear in the JS console

Offline tests

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

same as tests

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

Screen.Recording.2025-09-02.at.09.48.59.mp4

iOS: mWeb Safari

Screen.Recording.2025-09-02.at.09.51.12.mp4

MacOS: Chrome / Safari

here I'm comparing the changes with staging (in the 2nd half of the film)

Screen.Recording.2025-09-02.at.09.34.18.mp4

MacOS: Desktop

Screen.Recording.2025-09-02.at.12.11.03.mp4

melvin-bot · 2025-09-03T07:02:34Z

@Pujan92 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

Pujan92 · 2025-09-03T10:36:31Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

Simulator.Screen.Recording.-.iPhone.15.Pro.-.2025-09-03.at.17.56.53.mp4

iOS: mWeb Safari

Simulator.Screen.Recording.-.iPhone.15.Pro.-.2025-09-03.at.18.01.22.mp4

MacOS: Chrome / Safari

Screen.Recording.2025-09-03.at.17.52.12.mov

MacOS: Desktop

Pujan92 · 2025-09-03T12:19:57Z

                            </>
                        }
-                        onEndReached={onEndReached}
+                        onEndReached={onEndReached ?? incrementPage}


Inside the incrementPage function, we can use condition flattenedSections.allOptions.length > CONST.MAX_SELECTION_LIST_PAGE_LENGTH * currentPage; to increase the page value. Currently, it is increasing irrespective of there is more data or not on scrolling the end of the list.

ok, I will look into that

@Pujan92 done

trjExpensify

Nice improvement to remove the "show more" where we don't need it for pagination. CC'ing @Expensify/design so this is on your radar too for vis!

shawnborton · 2025-09-03T18:27:19Z

Nice, I dig it 👍

Pujan92 · 2025-09-04T10:03:32Z

-    const incrementPage = () => setCurrentPage((prev) => prev + 1);
+    const incrementPage = useCallback(() => {
+        // Calculate total options from sections
+        const totalOptions = sections.reduce((total, section) => total + (section.data?.length ?? 0), 0);


Can't we use flattenedSections.allOptions here as it is already available and used earlier here https://github.com/Expensify/App/pull/69599/files#diff-750b08e6eebe347cd7ad8d106d3ea0192256cbd6217b8a97618239ee76b3404cL319

ok, done @Pujan92

Pujan92

LGTM!

mountiny

Great simplification

mountiny

Thanks!

OSBotify · 2025-09-09T16:09:17Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2025-09-10T23:30:06Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.2.9-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2025-09-11T11:11:28Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.2.11-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2025-09-12T00:16:46Z

🚀 Deployed to production by https://github.com/francoisl in version: 9.2.12-4 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

fix: remove other occurrences of ShowMoreButton and the component

77facda

melvin-bot Bot assigned koko57 Sep 1, 2025

koko57 added 7 commits September 2, 2025 08:52

Merge branch 'main' into fix/68866-hide-show-more-button-for-other-lists

0872f55

Merge branch 'main' into fix/68866-hide-show-more-button-for-other-lists

f68e52d

fix: change tests to remove show more button check

c207a19

fix: minor fix

67e98ca

fix: tests

41570e9

fix: prettier

99138f7

Merge branch 'main' into fix/68866-hide-show-more-button-for-other-lists

3438306

koko57 marked this pull request as ready for review September 3, 2025 07:02

koko57 requested review from a team as code owners September 3, 2025 07:02

melvin-bot Bot requested review from Pujan92 and removed request for a team September 3, 2025 07:02

Pujan92 reviewed Sep 3, 2025

View reviewed changes

trjExpensify previously approved these changes Sep 3, 2025

View reviewed changes

koko57 added 2 commits September 4, 2025 10:33

Merge branch 'main' into fix/68866-hide-show-more-button-for-other-lists

b005b75

fix: apply requested changes

48281e7

koko57 dismissed trjExpensify’s stale review via 48281e7 September 4, 2025 09:10

koko57 requested a review from Pujan92 September 4, 2025 09:10

Pujan92 reviewed Sep 4, 2025

View reviewed changes

koko57 added 2 commits September 4, 2025 12:10

fix: apply requested changes

982d04b

fix: prettier

31a5e22

Pujan92 approved these changes Sep 4, 2025

View reviewed changes

melvin-bot Bot requested a review from mountiny September 4, 2025 10:19

mountiny requested changes Sep 8, 2025

View reviewed changes

Comment thread src/components/SelectionList/BaseSelectionList.tsx Outdated

Comment thread src/components/SelectionList/BaseSelectionList.tsx Outdated

Merge branch 'main' into fix/68866-hide-show-more-button-for-other-lists

00e1494

koko57 added 2 commits September 9, 2025 09:06

fix: remove redundant comment

fdf1fc8

fix: remove all redundant code

c64056f

mountiny approved these changes Sep 9, 2025

View reviewed changes

mountiny merged commit 30fc568 into Expensify:main Sep 9, 2025
22 checks passed

OSBotify mentioned this pull request Sep 10, 2025

Deploy Checklist: New Expensify 2025-09-10 #70325

Closed

melvin-bot Bot mentioned this pull request Sep 12, 2025

[Due for payment 2025-09-19] [Due for payment 2025-09-12] [$250] Fix BaseSelectionList pagination in some cases #68866

Closed

Conversation

koko57 commented Sep 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Sep 3, 2025

Uh oh!

Pujan92 commented Sep 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

Pujan92 Sep 3, 2025

Choose a reason for hiding this comment

Uh oh!

koko57 Sep 3, 2025

Choose a reason for hiding this comment

Uh oh!

koko57 Sep 4, 2025

Choose a reason for hiding this comment

Uh oh!

trjExpensify left a comment

Choose a reason for hiding this comment

Uh oh!

shawnborton commented Sep 3, 2025

Uh oh!

Pujan92 Sep 4, 2025

Choose a reason for hiding this comment

Uh oh!

koko57 Sep 4, 2025

Choose a reason for hiding this comment

Uh oh!

Pujan92 left a comment

Choose a reason for hiding this comment

Uh oh!

mountiny left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

mountiny left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

OSBotify commented Sep 9, 2025

Uh oh!

OSBotify commented Sep 10, 2025

Uh oh!

OSBotify commented Sep 11, 2025

Uh oh!

OSBotify commented Sep 12, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

koko57 commented Sep 1, 2025 •

edited

Loading

Pujan92 commented Sep 3, 2025 •

edited

Loading