Skip to content

[No QA]: Remove Onyx.connect() for the key: ONYXKEYS.COLLECTION.REPORT in src/libs/actions/App.ts #69646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danieldoglas merged 5 commits into from
Sep 9, 2025
Merged

[No QA]: Remove Onyx.connect() for the key: ONYXKEYS.COLLECTION.REPORT in src/libs/actions/App.ts #69646

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
25071fb
chore: decrement number of max eslint warnings
dariusz-biela Sep 2, 2025
db29264
refactor: replaces Onyx.connect with Onyx.connectWithoutView in src/l…
dariusz-biela Sep 2, 2025
5272033
fix: fixes import issues in App.ts
dariusz-biela Sep 3, 2025
9768818
Merge branch 'main' into dariusz-biela/refactor/deprecate-onyx-connec…
dariusz-biela Sep 3, 2025
0d00260
Merge branch 'main' into dariusz-biela/refactor/deprecate-onyx-connec…
dariusz-biela Sep 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions src/libs/actions/App.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,8 @@
import {isLoggingInAsNewUser as isLoggingInAsNewUserSessionUtils} from '@libs/SessionUtils';
import {clearSoundAssetsCache} from '@libs/Sound';
import CONST from '@src/CONST';
import ONYXKEYS from '@src/ONYXKEYS';
import type {OnyxKey} from '@src/ONYXKEYS';
import ONYXKEYS from '@src/ONYXKEYS';
import type {Route} from '@src/ROUTES';
import ROUTES from '@src/ROUTES';
import type * as OnyxTypes from '@src/types/onyx';
Expand Down Expand Up @@ -87,8 +87,11 @@
},
});

// allReports is used in the "ForOpenOrReconnect" functions and is not directly associated with the View,
// so retrieving it using Onyx.connectWithoutView is correct.
// If this variable is ever needed for use in React components, it should be retrieved using useOnyx.
let allReports: OnyxCollection<OnyxTypes.Report>;
Onyx.connect({
Onyx.connectWithoutView({
key: ONYXKEYS.COLLECTION.REPORT,
waitForCollectionCallback: true,
callback: (value) => {
Expand Down Expand Up @@ -218,7 +221,7 @@
function getPolicyParamsForOpenOrReconnect(): Promise<PolicyParamsForOpenOrReconnect> {
return new Promise((resolve) => {
isReadyToOpenApp.then(() => {
const connection = Onyx.connect({

Check warning on line 224 in src/libs/actions/App.ts

View workflow job for this annotation

GitHub Actions / Changed files ESLint check 

Onyx.connect() is deprecated. Use useOnyx() hook instead and pass the data as parameters to a pure function
key: ONYXKEYS.COLLECTION.POLICY,
waitForCollectionCallback: true,
callback: (policies) => {
Expand Down
Loading