Skip to content

fix: Changed copy for Desktop -> macOS#6973

Merged
marcaaron merged 1 commit into
Expensify:mainfrom
mananjadhav:fix/desktop-link-copy
Jan 3, 2022
Merged

fix: Changed copy for Desktop -> macOS#6973
marcaaron merged 1 commit into
Expensify:mainfrom
mananjadhav:fix/desktop-link-copy

Conversation

@mananjadhav

@mananjadhav mananjadhav commented Jan 1, 2022

Copy link
Copy Markdown
Collaborator

Details

  • Changed the copy from Desktop to macOSso that the user knows the supported platform.

Fixed Issues

$ #6921

Tests

  • Checked the updated copy in all platforms.

QA Steps

  1. Open app
  2. Go to settings > About > App download links
  3. Check the desktop link label should be 'macOS'

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

web-desktop-link-copy

Mobile Web

mweb-desktop-link-copy

Desktop

desktop-link-copy

iOS

ios-desktop-link-copy

Android

android-desktop-link-copy

@mananjadhav mananjadhav requested a review from a team as a code owner January 1, 2022 04:08
@MelvinBot MelvinBot requested review from marcaaron and parasharrajat and removed request for a team January 1, 2022 04:08

@parasharrajat parasharrajat left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

cc: @marcaaron

C+ reviewed

@marcaaron marcaaron merged commit cf91885 into Expensify:main Jan 3, 2022
@OSBotify

OSBotify commented Jan 3, 2022

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify

OSBotify commented Jan 4, 2022

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by @marcaaron in version: 1.1.24-19 🚀

platform result
🤖 android 🤖 failure ❌
🖥 desktop 🖥 failure ❌
🍎 iOS 🍎 failure ❌
🕸 web 🕸 failure ❌

@OSBotify

OSBotify commented Jan 4, 2022

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by @francoisl in version: 1.1.24-19 🚀

platform result
🤖 android 🤖 failure ❌
🖥 desktop 🖥 failure ❌
🍎 iOS 🍎 failure ❌
🕸 web 🕸 failure ❌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants