Skip to content

Follow-up: stop returning promise #69738

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cristipaval merged 2 commits into from
Sep 4, 2025
Merged

Follow-up: stop returning promise #69738

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
71fbe54
Get rid of anti-pattern
VickyStash Sep 3, 2025
a056152
Merge branch 'main' into VickyStash/bugfix/61183-follow-up
VickyStash Sep 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/libs/actions/TransactionEdit.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
const newTransaction = {
...transaction,
};
const conn = Onyx.connect({

Check warning on line 27 in src/libs/actions/TransactionEdit.ts

View workflow job for this annotation

GitHub Actions / Changed files ESLint check 

Onyx.connect() is deprecated. Use useOnyx() hook instead and pass the data as parameters to a pure function
key: `${ONYXKEYS.COLLECTION.TRANSACTION_BACKUP}${transaction.transactionID}`,
callback: (transactionBackup) => {
Onyx.disconnect(conn);
Expand Down Expand Up @@ -56,7 +56,7 @@
return;
}

connection = Onyx.connect({

Check warning on line 59 in src/libs/actions/TransactionEdit.ts

View workflow job for this annotation

GitHub Actions / Changed files ESLint check 

Onyx.connect() is deprecated. Use useOnyx() hook instead and pass the data as parameters to a pure function
key: `${ONYXKEYS.COLLECTION.TRANSACTION_BACKUP}${transactionID}`,
callback: (backupTransaction) => {
Onyx.disconnect(connection);
Expand Down Expand Up @@ -109,7 +109,7 @@
},
{} as Record<string, null>,
);
return Onyx.multiSet(draftTransactionsSet);
Onyx.multiSet(draftTransactionsSet);
}

function replaceDefaultDraftTransaction(transaction: OnyxEntry<Transaction>) {
Expand Down
3 changes: 2 additions & 1 deletion src/pages/iou/request/step/IOURequestStepConfirmation.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -433,7 +433,8 @@
Navigation.navigate(ROUTES.MONEY_REQUEST_STEP_SCAN.getRoute(CONST.IOU.ACTION.CREATE, iouType, initialTransactionID, reportID, Navigation.getActiveRouteWithoutParams()));
return;
}
removeDraftTransactions(true).then(() => navigateToStartMoneyRequestStep(requestType, iouType, initialTransactionID, reportID));
removeDraftTransactions(true);
navigateToStartMoneyRequestStep(requestType, iouType, initialTransactionID, reportID);
});
}, [requestType, iouType, initialTransactionID, reportID, action, report, transactions, participants]);

Expand Down Expand Up @@ -918,7 +919,7 @@

requestMoney(selectedParticipants);
},
[

Check warning on line 922 in src/pages/iou/request/step/IOURequestStepConfirmation.tsx

View workflow job for this annotation

GitHub Actions / Changed files ESLint check 

React Hook useCallback has a missing dependency: 'transactions'. Either include it or remove the dependency array
iouType,
transaction,
isDistanceRequest,
Expand Down
Loading