Workflows option in onboarding modal screen goes full width instead of using 50% width like all other choices#69940
Conversation
…f using 50% width like all other choices
|
@ishpaul777 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppScreen.Recording.2025-09-05.at.11.39.38.PM.movAndroid: mWeb ChromeScreen.Recording.2025-09-05.at.11.41.40.PM.moviOS: HybridAppScreen.Recording.2025-09-05.at.11.06.49.PM.moviOS: mWeb SafariScreen.Recording.2025-09-05.at.11.08.15.PM.movMacOS: Chrome / SafariScreen.Recording.2025-09-05.at.10.41.19.PM.movMacOS: DesktopScreen.Recording.2025-09-05.at.11.49.05.PM.mov |
|
👋 @Expensify/design please take a look at this from design POV |
|
Looks good to me! |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/puneetlath in version: 9.2.3-0 🚀
|
|
🚀 Deployed to staging by https://github.com/puneetlath in version: 9.2.5-0 🚀
|
|
🚀 Deployed to staging by https://github.com/puneetlath in version: 9.2.8-0 🚀
|
|
🚀 Deployed to production by https://github.com/francoisl in version: 9.2.8-4 🚀
|
| accessible={false} | ||
| hoverStyle={!isSelected ? styles.hoveredComponentBG : undefined} | ||
| style={[styles.onboardingInterestedFeaturesItem, isSmallScreenWidth && styles.flexBasis100, isSelected && styles.activeComponentBG]} | ||
| style={[styles.onboardingInterestedFeaturesItem, isSmallScreenWidth ? styles.flexBasis100 : {maxWidth: (width - gap) / 2}, isSelected && styles.activeComponentBG]} |
There was a problem hiding this comment.
This change caused #82910. The onLayout-based width measurement includes the scrollbar gutter (~17px on Windows), so (width - gap) / 2 computes a maxWidth that's wider than the actual content area. In paired rows flexShrink: 1 constrains both items, but the lone "Time" item in the last row grows to the inflated maxWidth, causing visible misalignment. Fixed in #87176 by switching to percentage-based sizing (flexBasis: '48.5%'), which is inherently scrollbar-aware.
Explanation of Change
Fixed Issues
$ #69660
PROPOSAL: #69660 (comment)
Tests
Offline tests
Same as tests
QA Steps
Same as tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop