perf: recompute derived value on display name changes by TMisiukiewicz · Pull Request #70087 · Expensify/App

TMisiukiewicz · 2025-09-08T12:39:40Z

Explanation of Change

Currently, every change to personal details causes full recomputation of report attributes derived value (~800ms). This PR aims to recompute it only when there is any update to displayName of any user.

Update	Full recompute before?	Full recompute after?
`Onyx.merge("personalDetailsList", {"19568722": {"login": "loginf@netcgtf.com"}})`	✅	❌
`Onyx.merge("personalDetailsList", {"19568722": {"phoneNumber": "112445"}})`	✅	❌
`Onyx.merge("personalDetailsList", {"19568722": {"displayName": "Tomasz Misiukiewicz"}})`	✅	✅

Fixed Issues

$ #68865
PROPOSAL:

Tests

Open the app
Go to Profile -> Display name
Change and save the display name
Go back to LHN
Verify the display name changed in e.g. expense chats, group chats or self DM

Verify that no errors appear in the JS console

Offline tests

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."
Same as tests

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

android.mov

Android: mWeb Chrome

iOS: Native

ios.mp4

iOS: mWeb Safari

ios-web.mp4

MacOS: Chrome / Safari

web.mov

MacOS: Desktop

desktop.mov

…ibutes-on-displayname-change

melvin-bot · 2025-09-09T15:58:10Z

@brunovjk Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

mountiny · 2025-09-09T15:59:36Z

@brunovjk can you please review this with priority?

mountiny · 2025-09-09T16:00:19Z

        ONYXKEYS.COLLECTION.REPORT_METADATA,
    ],
-    compute: ([reports, preferredLocale, transactionViolations, reportActions, reportNameValuePairs, transactions], {currentValue, sourceValues, areAllConnectionsSet}) => {
+    compute: ([reports, preferredLocale, transactionViolations, reportActions, reportNameValuePairs, transactions, personalDetails], {currentValue, sourceValues, areAllConnectionsSet}) => {


Could you add unit tests to test if the derived values are recomputed with the personal details change or not?

brunovjk · 2025-09-10T00:15:01Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

70087_android_native.mov

Android: mWeb Chrome

70087_android_web.mov

iOS: HybridApp

70087_ios_web.mov

iOS: mWeb Safari

70087_ios_web.mov

MacOS: Chrome / Safari

70087_web_chrome.mov

MacOS: Desktop

70087_web_desktop.mov

brunovjk · 2025-09-10T03:24:00Z

Caught up on the issue and related discussions. The code changes align with the slack conversation. I’ve only tested a few scenarios so far; everything looks good. I’ll continue testing other potentially affected areas and all platforms first thing tomorrow.

…ibutes-on-displayname-change

TMisiukiewicz · 2025-09-10T09:10:04Z

Added tests and recordings for the PR ✅

mountiny · 2025-09-10T16:13:23Z

@brunovjk thanks for testing!

brunovjk

Tested this PR and didn’t notice any difference in user-facing behavior compared to production. Based on the logs and performance tracking, the optimizations are working—report attributes now only update when the displayName actually changes, not for unrelated updates.

A couple of existing bugs that exist both in this PR when in staging:

On native Android, the LHN doesn’t update with the new name until the affected chat is opened:

Android: HybridApp

bug_main_android.mov

On web (Chrome, mWeb iOS/Android), when user B changes their name, user A’s view updates everywhere except the expense preview title in an unfocused window. The title only update when the window regains focus:

MacOS: Chrome

bug_main_chrome.mov

These issues are not introduced or fixed by this PR, so I don’t think they block merging, but please let me know if anyone feels otherwise.

mountiny · 2025-09-10T19:59:34Z

@brunovjk can you please report those in slack for Qa to create issue? great job testing!

mountiny

Thanks for adding the automated test, if you think of other ways to cover this method in automated tests, please add them given how crucial this is

OSBotify · 2025-09-10T20:20:57Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

brunovjk · 2025-09-10T20:22:31Z

@brunovjk can you please report those in slack for Qa to create issue? great job testing!

Sure :D

OSBotify · 2025-09-10T23:30:57Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.2.9-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2025-09-11T11:12:19Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.2.11-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2025-09-12T00:17:37Z

🚀 Deployed to production by https://github.com/francoisl in version: 9.2.12-4 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

situchan · 2026-01-07T23:23:17Z

+    if (Object.keys(previousDisplayNames).length === 0) {
+        previousDisplayNames = currentDisplayNames;
+        previousPersonalDetails = personalDetails;
+        return false;


returning false here doesn't recompute report attributes when personalDetails is set first time.
So it caused #76563

check if displayName changed in personal details

85be289

melvin-bot Bot assigned TMisiukiewicz Sep 8, 2025

TMisiukiewicz mentioned this pull request Sep 9, 2025

[Due for payment 2025-09-19] [$250] Investigate personal details bottlenecks #68865

Closed

Merge remote-tracking branch 'upstream/main' into perf/recompute-attr…

67e71c3

…ibutes-on-displayname-change

mountiny marked this pull request as ready for review September 9, 2025 15:58

mountiny requested a review from a team as a code owner September 9, 2025 15:58

melvin-bot Bot requested a review from brunovjk September 9, 2025 15:58

melvin-bot Bot removed the request for review from a team September 9, 2025 15:58

mountiny reviewed Sep 9, 2025

View reviewed changes

This comment was marked as outdated.

Sign in to view

TMisiukiewicz added 2 commits September 10, 2025 09:02

Merge remote-tracking branch 'upstream/main' into perf/recompute-attr…

a5197f8

…ibutes-on-displayname-change

add unit tests

48631ba

brunovjk approved these changes Sep 10, 2025

View reviewed changes

melvin-bot Bot requested a review from mountiny September 10, 2025 19:52

mountiny approved these changes Sep 10, 2025

View reviewed changes

mountiny merged commit eecd0ab into Expensify:main Sep 10, 2025
23 checks passed

OSBotify mentioned this pull request Sep 10, 2025

Deploy Checklist: New Expensify 2025-09-10 #70325

Closed

apeyada mentioned this pull request Dec 8, 2025

[Due for payment 2026-01-07] [$250] Reports - Link on expense preview changes to "Chat Report" after clearing cache offline #76563

Closed

8 tasks

apeyada mentioned this pull request Dec 18, 2025

fix Reports - Link on expense preview changes to "Chat Report" after clearing cache offline #77983

Merged

54 tasks

situchan reviewed Jan 7, 2026

View reviewed changes

Conversation

TMisiukiewicz commented Sep 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Sep 9, 2025

Uh oh!

mountiny commented Sep 9, 2025

Uh oh!

mountiny Sep 9, 2025

Choose a reason for hiding this comment

Uh oh!

This comment was marked as outdated.

brunovjk commented Sep 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

brunovjk commented Sep 10, 2025

Uh oh!

TMisiukiewicz commented Sep 10, 2025

Uh oh!

mountiny commented Sep 10, 2025

Uh oh!

brunovjk left a comment

Choose a reason for hiding this comment

Uh oh!

mountiny commented Sep 10, 2025

Uh oh!

mountiny left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

OSBotify commented Sep 10, 2025

Uh oh!

brunovjk commented Sep 10, 2025

Uh oh!

OSBotify commented Sep 10, 2025

Uh oh!

OSBotify commented Sep 11, 2025

Uh oh!

OSBotify commented Sep 12, 2025

Uh oh!

situchan Jan 7, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

TMisiukiewicz commented Sep 8, 2025 •

edited

Loading

brunovjk commented Sep 10, 2025 •

edited

Loading