Skip to content

[No QA] Only use isPullRequestMergeable action after PR is approved#7044

Merged
AndrewGable merged 1 commit into
mainfrom
Rory-IsPullRequestMergeable
Jan 5, 2022
Merged

[No QA] Only use isPullRequestMergeable action after PR is approved#7044
AndrewGable merged 1 commit into
mainfrom
Rory-IsPullRequestMergeable

Conversation

@roryabraham

Copy link
Copy Markdown
Contributor

Details

Only use the isPullRequestMergeable action after a PR is approved.

Fixed Issues

https://expensify.slack.com/archives/C03V9A4TB/p1641415688476900

Tests

  1. Merge this PR
  2. Re-run the production deploy and see if it works.

QA Steps

None

@roryabraham roryabraham self-assigned this Jan 5, 2022
@roryabraham roryabraham requested a review from a team as a code owner January 5, 2022 21:10
@roryabraham roryabraham requested a review from francoisl January 5, 2022 21:10
@github-actions

github-actions Bot commented Jan 5, 2022

Copy link
Copy Markdown
Contributor

⚠️ ⚠️ Heads up! This pull request has the CP Staging label. ⚠️ ⚠️
Merging it will cause it to be immediately deployed to staging, even if the open StagingDeployCash deploy checklist is locked.

@MelvinBot MelvinBot requested review from Gonals and removed request for a team January 5, 2022 21:10
@AndrewGable AndrewGable merged commit a88614c into main Jan 5, 2022
@AndrewGable AndrewGable deleted the Rory-IsPullRequestMergeable branch January 5, 2022 22:11
OSBotify pushed a commit that referenced this pull request Jan 5, 2022
[No QA] Only use isPullRequestMergeable action after PR is approved

(cherry picked from commit a88614c)
@OSBotify

OSBotify commented Jan 6, 2022

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by @AndrewGable in version: 1.1.25-2 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants