Fix search page footer briefly shows after submit/approve/pay report by bernhardoj · Pull Request #71073 · Expensify/App

bernhardoj · 2025-09-23T14:36:27Z

Explanation of Change

Fixed Issues

$ #70741
PROPOSAL: #70741 (comment)

Tests

Same as QA Steps

Verify that no errors appear in the JS console

Offline tests

Same as QA Steps

QA Steps

Create an expense in a WS chat
Open Reports > Reports
Open the expense report
Submit the report
Go back
Verify there is no Reports footer shows briefly
Repeat step 3-6, but do Approve
Repeat step 3-6, but do Pay

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

android.mp4

Android: mWeb Chrome

android.mweb.mp4

iOS: Native

iOS: mWeb Safari

ios.mweb.mp4

MacOS: Chrome / Safari

web.mp4

MacOS: Desktop

desktop.mp4

melvin-bot · 2025-09-23T14:36:33Z

@allroundexperts Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

bernhardoj · 2025-09-23T14:38:26Z

I'm still having trouble with iOS.

allroundexperts · 2025-09-23T14:41:25Z

Should I review this @JS00001?

allroundexperts · 2025-09-23T14:42:23Z

Oh, I guess I need to do. Will review this today.

allroundexperts · 2025-09-28T22:22:34Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

Screen.Recording.2025-09-29.at.3.37.28.AM.mov

iOS: HybridApp

WhatsApp.Video.2025-10-11.at.01.06.27.mp4

iOS: mWeb Safari

Screen.Recording.2025-09-29.at.3.35.40.AM.mov

MacOS: Chrome / Safari

Screen.Recording.2025-09-29.at.3.31.23.AM.mov

MacOS: Desktop

Screen.Recording.2025-09-29.at.3.33.47.AM.mov

allroundexperts · 2025-09-28T23:02:25Z

Not able to test iOS as well. @JS00001 Can you trigger an adhoc build for iOS and android please?

github-actions · 2025-09-29T11:39:32Z

🚧 @JS00001 has triggered a test Expensify/App build. You can view the workflow run here.

allroundexperts · 2025-10-01T21:23:33Z

@JS00001 iOS build failed :(

JS00001 · 2025-10-02T12:15:32Z

Rats... @bernhardoj Can you pull main to see if that fixes it?

bernhardoj · 2025-10-03T14:27:56Z

Done

JS00001 · 2025-10-03T14:36:27Z

@allroundexperts Can you see if you can build now?

allroundexperts · 2025-10-07T19:28:49Z

@JS00001 Can you please trigger an adhoc build? I still can't build locally.

github-actions · 2025-10-08T11:44:05Z

🚧 @JS00001 has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2025-10-08T12:17:43Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪
Built from App PR #71073.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/71073/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/71073/index.html

Desktop 💻	Web 🕸️
⏩ SKIPPED ⏩	⏩ SKIPPED ⏩
The build for Desktop was skipped	The build for Web was skipped

👀 View the workflow run that generated this build 👀

JS00001 · 2025-10-10T15:31:36Z

@allroundexperts Can you please review?

luacmartins

LGTM

JS00001 · 2025-10-13T11:18:12Z

@allroundexperts Looks like this checklist is missing some options, could you check youre on the latest?
#71073 (comment)

allroundexperts · 2025-10-13T17:48:51Z

@JS00001 The failure seems to be a 404 error. Can you restart the check?

allroundexperts · 2025-10-13T19:41:47Z

@bernhardoj Can you resolve the conflicts?

bernhardoj · 2025-10-14T03:44:32Z

Fixed

codecov · 2025-10-14T03:55:51Z

Codecov Report

❌ Patch coverage is 0% with 11 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
src/hooks/useSearchShouldCalculateTotals.ts	0.00%	9 Missing ⚠️
src/components/MoneyReportHeader.tsx	0.00%	1 Missing ⚠️
src/components/Search/index.tsx	0.00%	1 Missing ⚠️

Files with missing lines	Coverage Δ
src/components/MoneyReportHeader.tsx	`0.18% <0.00%> (-0.01%)`	⬇️
src/components/Search/index.tsx	`0.00% <0.00%> (ø)`
src/hooks/useSearchShouldCalculateTotals.ts	`0.00% <0.00%> (ø)`

... and 20 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

JS00001 · 2025-10-14T13:05:12Z

IDK Whats happening with the checklist, theres a 404 and then

You completed 49 out of 52 checklist items with 0 unfinished items
Make sure you are using the most up to date checklist found here: https://raw.githubusercontent.com/Expensify/App/main/.github/PULL_REQUEST_TEMPLATE.md
Error: PR Author Checklist is not completely filled out. Please check every box to verify you've thought about the item.

luacmartins · 2025-10-14T15:42:22Z

The checklist in the OP was outdated.

OSBotify · 2025-10-14T17:56:16Z

🚀 Deployed to staging by https://github.com/luacmartins in version: 9.2.31-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

kavimuru · 2025-10-15T01:32:53Z

@bernhardoj @luacmartins @allroundexperts PR is failing with original bug id #70741 on all the platforms
https://platform.applause.com/services/links/v1/external/cbf499814a6ec3d58ae253f4f2f3c42a80f772d0ea9a3429c9ae875cd60b4d68
https://platform.applause.com/services/links/v1/external/69b6ff1cb678e49c669f9a1492507a05116d812732e67a76785f036dee4fec15
https://platform.applause.com/services/links/v1/external/4b794d9892a64037f8007516851cbc8453019c01bd00f7e76c52c7d81a84b597
https://platform.applause.com/services/links/v1/external/fd5e2ec0ea131af1cd0b53b916af3b6527a39301b80427a98d5503e2a9c08747
https://platform.applause.com/services/links/v1/external/096edd656318ce919f17d71e10610aa6e6194b155f37b4128be18f8674bc6357

luacmartins · 2025-10-15T15:14:11Z

@bernhardoj can you please take a look?

OSBotify · 2025-10-15T22:49:56Z

🚀 Deployed to production by https://github.com/mountiny in version: 9.2.31-2 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

fix search page footer briefly shows after submit/approve/pay report

65e3317

bernhardoj requested a review from a team as a code owner September 23, 2025 14:36

melvin-bot Bot assigned bernhardoj Sep 23, 2025

melvin-bot Bot requested review from allroundexperts and removed request for a team September 23, 2025 14:36

JS00001 previously approved these changes Sep 23, 2025

View reviewed changes

lint

b6b31c3

bernhardoj dismissed JS00001’s stale review via b6b31c3 September 23, 2025 14:41

This comment has been minimized.

Sign in to view

Merge branch 'main' into fix/70741-search-page-footer-briefly-shown

8a5032c

allroundexperts approved these changes Oct 10, 2025

View reviewed changes

melvin-bot Bot requested a review from luacmartins October 10, 2025 20:08

luacmartins previously approved these changes Oct 10, 2025

View reviewed changes

JS00001 previously approved these changes Oct 13, 2025

View reviewed changes

Merge branch 'main' into fix/70741-search-page-footer-briefly-shown

2d292d2

bernhardoj dismissed stale reviews from JS00001 and luacmartins via 2d292d2 October 14, 2025 03:44

JS00001 approved these changes Oct 14, 2025

View reviewed changes

luacmartins approved these changes Oct 14, 2025

View reviewed changes

luacmartins merged commit f1054c3 into Expensify:main Oct 14, 2025
23 of 26 checks passed

OSBotify mentioned this pull request Oct 14, 2025

Deploy Checklist: New Expensify 2025-10-14 #72609

Closed

42 tasks

melvin-bot Bot mentioned this pull request Oct 15, 2025

[Due for payment 2025-11-03] [$250] Reports - Footer on "Reports", is briefly shown when submitting, approving or paying report. #70741

Closed

8 tasks

Conversation

bernhardoj commented Sep 23, 2025 • edited by luacmartins Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Sep 23, 2025

Uh oh!

bernhardoj commented Sep 23, 2025

Uh oh!

allroundexperts commented Sep 23, 2025

Uh oh!

allroundexperts commented Sep 23, 2025

Uh oh!

allroundexperts commented Sep 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

allroundexperts commented Sep 28, 2025

Uh oh!

github-actions Bot commented Sep 29, 2025

Uh oh!

This comment has been minimized.

allroundexperts commented Oct 1, 2025

Uh oh!

JS00001 commented Oct 2, 2025

Uh oh!

bernhardoj commented Oct 3, 2025

Uh oh!

JS00001 commented Oct 3, 2025

Uh oh!

allroundexperts commented Oct 7, 2025

Uh oh!

github-actions Bot commented Oct 8, 2025

Uh oh!

github-actions Bot commented Oct 8, 2025

Uh oh!

JS00001 commented Oct 10, 2025

Uh oh!

luacmartins left a comment

Choose a reason for hiding this comment

Uh oh!

JS00001 commented Oct 13, 2025

Uh oh!

allroundexperts commented Oct 13, 2025

Uh oh!

allroundexperts commented Oct 13, 2025

Uh oh!

bernhardoj commented Oct 14, 2025

Uh oh!

codecov Bot commented Oct 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

JS00001 commented Oct 14, 2025

Uh oh!

luacmartins commented Oct 14, 2025

Uh oh!

Uh oh!

OSBotify commented Oct 14, 2025

Uh oh!

kavimuru commented Oct 15, 2025

Uh oh!

luacmartins commented Oct 15, 2025

Uh oh!

OSBotify commented Oct 15, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

bernhardoj commented Sep 23, 2025 •

edited by luacmartins

Loading

allroundexperts commented Sep 28, 2025 •

edited

Loading

codecov Bot commented Oct 14, 2025 •

edited

Loading