[No QA] Temporarily remove getPullRequestsMergedBetween unit test#7119
Merged
Conversation
roryabraham
changed the title
roryabraham
changed the title
Julesssss
approved these changes
Jan 11, 2022
Julesssss
left a comment
Julesssss
left a comment
Contributor
There was a problem hiding this comment.
Approving and merging to unblock contributor PRs.
Contributor
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
54 tasks
Contributor
|
🚀 Deployed to staging by @Julesssss in version: 1.1.27-2 🚀
|
Contributor
|
🚀 Deployed to staging by @Julesssss in version: 1.1.27-3 🚀
|
Contributor
|
🚀 Deployed to staging by @Julesssss in version: 1.1.27-3 🚀
|
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
Contributor PRs are failing unit tests because they do not have access to the repo secrets necessary for
OSBotifyto configure commit signing on the GitHub Actions runner. This PR should fix that temporarily removing the new failing test, pending a solution that doesn't require commit signing (or doesn't use actual GPG keys).Fixed Issues
$ https://github.com/Expensify/Expensify/issues/191675
Tests
None - only PR checks.
QA Steps
No QA.
Tested On