fix: handle selection mode in search context#71700
Conversation
Codecov Report❌ Patch coverage is
... and 28 files with indirect coverage changes 🚀 New features to boost your workflow:
|
|
@ZhenjaHorbach Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
Sorry for the delay |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / Safari2025-10-09.15.23.03.movMacOS: Desktop2025-10-09.15.29.55.mov |
|
@daledah |
|
LGTM! |
|
@daledah can you merge main to fix this |
|
@youssef-lr Done! |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/youssef-lr in version: 9.2.35-0 🚀
|
|
FYI we reverted this here: #73107 |
|
🚀 Deployed to production by https://github.com/blimpich in version: 9.2.35-4 🚀
|
Explanation of Change
Fixed Issues
$ #69251
PROPOSAL: #69251 (comment)
Tests
Scenario 1: Incorrect selection state after resizing
Scenario 2: Header not updating on resize in selection mode
Offline tests
QA Steps
Scenario 1: Incorrect selection state after resizing
Scenario 2: Header not updating on resize in selection mode
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Screen.Recording.2025-10-13.at.01.03.05.mov
Android: mWeb Chrome
Screen.Recording.2025-10-13.at.01.07.13.mov
iOS: Native
Screen.Recording.2025-10-13.at.01.07.31.mov
iOS: mWeb Safari
Screen.Recording.2025-10-13.at.01.35.58.mov
MacOS: Chrome / Safari
Screen.Recording.2025-10-13.at.01.36.18.mov
MacOS: Desktop
Screen.Recording.2025-10-13.at.01.36.47.mov