Skip to content

Fix: Remove empty space above keyboard in iOS Chat after navigating from Expense Request #71743

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
inimaga merged 2 commits into from
Oct 23, 2025
Merged

Fix: Remove empty space above keyboard in iOS Chat after navigating from Expense Request #71743

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bc96bb8
fix(ios-chat): remove empty space above keyboard after navigating fro…
marufsharifi Oct 2, 2025
d181691
Merge branch 'main' into fix/ios-chat-keyboard-spacing
marufsharifi Oct 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions src/pages/home/report/ReportActionsView.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ function ReportActionsView({

const {shouldUseNarrowLayout} = useResponsiveLayout();
const isFocused = useIsFocused();
const [isNavigatingToLinkedMessage, setNavigatingToLinkedMessage] = useState(!!reportActionID);
const [isNavigatingToLinkedMessage, setNavigatingToLinkedMessage] = useState(false);
const prevShouldUseNarrowLayoutRef = useRef(shouldUseNarrowLayout);
const reportID = report.reportID;
const isReportFullyVisible = useMemo((): boolean => getIsReportFullyVisible(isFocused), [isFocused]);
Expand Down Expand Up @@ -279,16 +279,16 @@ function ReportActionsView({
useEffect(() => {
let timerID: NodeJS.Timeout;

if (isTheFirstReportActionIsLinked) {
if (!isTheFirstReportActionIsLinked && reportActionID) {
setNavigatingToLinkedMessage(true);
} else {
// After navigating to the linked reportAction, apply this to correctly set
// `autoscrollToTopThreshold` prop when linking to a specific reportAction.
// eslint-disable-next-line @typescript-eslint/no-deprecated
InteractionManager.runAfterInteractions(() => {
// Using a short delay to ensure the view is updated after interactions
timerID = setTimeout(() => setNavigatingToLinkedMessage(false), 10);
});
} else {
setNavigatingToLinkedMessage(false);
}

return () => {
Expand All @@ -297,7 +297,7 @@ function ReportActionsView({
}
clearTimeout(timerID);
};
}, [isTheFirstReportActionIsLinked]);
}, [isTheFirstReportActionIsLinked, reportActionID]);

// Show skeleton while loading initial report actions when data is incomplete/missing and online
const shouldShowSkeletonForInitialLoad = isLoadingInitialReportActions && (isReportDataIncomplete || isMissingReportActions) && !isOffline;
Expand Down
Loading