Skip to content

Navigate to expense detail page after adding a receipt#71818

Merged
mountiny merged 6 commits into
Expensify:mainfrom
callstack-internal:fix-70920
Oct 22, 2025
Merged

Navigate to expense detail page after adding a receipt#71818
mountiny merged 6 commits into
Expensify:mainfrom
callstack-internal:fix-70920

Conversation

@kubabutkiewicz

Copy link
Copy Markdown
Contributor

Explanation of Change

Fixed Issues

$#70920
PROPOSAL:

Tests

  1. Launch app as member
  2. Open employee workspace chat
  3. Create a manual expense
  4. Open the expense
  5. Tap plus icon and add a receipt
  6. Verify user is redirected to expense details page.
  • Verify that no errors appear in the JS console

Offline tests

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

same as tests

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
    • MacOS: Desktop
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I verified there are no new alerts related to the canBeMissing param for useOnyx
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop

@kubabutkiewicz kubabutkiewicz requested a review from a team as a code owner October 3, 2025 15:34
@melvin-bot melvin-bot Bot requested review from dukenv0307 and removed request for a team October 3, 2025 15:34
@melvin-bot

melvin-bot Bot commented Oct 3, 2025

Copy link
Copy Markdown

@dukenv0307 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@kubabutkiewicz

Copy link
Copy Markdown
Contributor Author

Hey @rafecolton I created a potential fix but I have some problem with building the app on my phone. Could you run the ad hoc builds so I could verify?

@codecov

codecov Bot commented Oct 3, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 12.50000% with 28 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/libs/actions/App.ts 0.00% 13 Missing ⚠️
...u/request/step/IOURequestStepScan/index.native.tsx 0.00% 10 Missing ⚠️
src/libs/Navigation/NavigationRoot.tsx 44.44% 5 Missing ⚠️
Files with missing lines Coverage Δ
src/CONST/index.ts 85.84% <ø> (ø)
src/libs/Navigation/NavigationRoot.tsx 78.49% <44.44%> (-1.29%) ⬇️
...u/request/step/IOURequestStepScan/index.native.tsx 1.04% <0.00%> (-0.03%) ⬇️
src/libs/actions/App.ts 43.34% <0.00%> (-2.57%) ⬇️

... and 21 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@rafecolton

Copy link
Copy Markdown
Member

Triggered the build

@github-actions

github-actions Bot commented Oct 3, 2025

Copy link
Copy Markdown
Contributor

🚧 @rafecolton has triggered a test Expensify/App build. You can view the workflow run here.

@github-actions

This comment has been minimized.

@dukenv0307

Copy link
Copy Markdown
Contributor

It doesn't work on my side @kubabutkiewicz

Screen.Recording.2025-10-06.at.11.42.42.mov

@kubabutkiewicz

Copy link
Copy Markdown
Contributor Author

thanks for checking will be digging further

@kubabutkiewicz

Copy link
Copy Markdown
Contributor Author

Hey @dukenv0307 is there is something I am doing wrong ?
For me its working 😅

ScreenRecording_10-06-2025.11-49-45_1.MP4

@dukenv0307

Copy link
Copy Markdown
Contributor

@kubabutkiewicz Can you please merge main? then I'll check again

@dukenv0307

Copy link
Copy Markdown
Contributor

@kubabutkiewicz Can you test on 1 transaction thread? It also works on my side when there are 2 transactions in the expense report, but it doesn't work on 1 transaction thread

@kubabutkiewicz

kubabutkiewicz commented Oct 7, 2025

Copy link
Copy Markdown
Contributor Author

I am still not able to reproduce that for me its working properly, I think, I am doing everything as described no?

ScreenRecording_10-07-2025.17-13-31_1.MP4

@kubabutkiewicz

Copy link
Copy Markdown
Contributor Author

hmm maybe its android only , let me check that

@kubabutkiewicz

Copy link
Copy Markdown
Contributor Author

@dukenv0307

Copy link
Copy Markdown
Contributor

@kubabutkiewicz After digging deeper, I found out that we can reproduce this issue by using the following steps:

  1. Open App
  2. Go to WS page
  3. Select any WS
  4. Go to WS chat
  5. Select any expense
  6. Click the receipt placeholder
  7. Upload the receipt
  8. Observe that after uploading the receipt, we'll navigate to LHN
Screen.Recording.2025-10-09.at.09.24.13.mov

@dukenv0307

dukenv0307 commented Oct 9, 2025

Copy link
Copy Markdown
Contributor

@kubabutkiewicz The RCA is in

const reportsSplitNavigator = navigationState?.routes?.find((route) => route.name === 'ReportsSplitNavigator');
const hasLostNavigationsState = reportsSplitNavigator && !reportsSplitNavigator.state;

The first route ReportsSplitNavigator doesn't have the state, so we'll navigate to the home page

Screenshot 2025-10-09 at 09 30 03

I think we should use findLast

@kubabutkiewicz

Copy link
Copy Markdown
Contributor Author

@dukenv0307 I dont know whats going on but I am doing exactly same steps as you and stil working for me, I will just apply the fix you suggest and we can run new ad hoc build to check

ScreenRecording_10-09-2025.17-04-35_1.MP4

@kubabutkiewicz

Copy link
Copy Markdown
Contributor Author

I pushed this change @dukenv0307. Could you @rafecolton run again the ad hoc builds 🙏

@dukenv0307

dukenv0307 commented Oct 9, 2025

Copy link
Copy Markdown
Contributor

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
    • MacOS: Desktop
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified there are no new alerts related to the canBeMissing param for useOnyx
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp
Screen.Recording.2025-10-09.at.23.26.23.mov
Android: mWeb Chrome
Screen.Recording.2025-10-09.at.23.33.25.mov
iOS: HybridApp
iOS: mWeb Safari
Screen.Recording.2025-10-09.at.23.34.14.mov
MacOS: Chrome / Safari
Screen.Recording.2025-10-09.at.23.35.24.mov
MacOS: Desktop
Screen.Recording.2025-10-09.at.23.42.27.mov

@melvin-bot melvin-bot Bot requested a review from mountiny October 9, 2025 16:43
@dukenv0307

dukenv0307 commented Oct 9, 2025

Copy link
Copy Markdown
Contributor

Thank you @kubabutkiewicz. This issue works well on my side. @mountiny @rafecolton Can you please trigger an ad-hoc build? We need to verify it on the real iOS device

@github-actions

Copy link
Copy Markdown
Contributor

🚧 @rafecolton has triggered a test Expensify/App build. You can view the workflow run here.

@github-actions

Copy link
Copy Markdown
Contributor

HelpDot Documentation Review

Assessment Summary

After thorough analysis of PR #71818, this PR does not contain any HelpDot documentation changes. This is a code-only pull request that implements a navigation fix for expense receipt scanning functionality.

PR Analysis

PR Title: Navigate to expense detail page after adding a receipt
Author: @kubabutkiewicz
Files Changed: 5 TypeScript/JavaScript files only

Files Modified (Code Only)

  • src/CONST/index.ts - Updated exclude list for last visited path
  • src/libs/Navigation/NavigationRoot.tsx - Enhanced navigation logic
  • src/libs/actions/App.ts - Added navigation action for expense details
  • src/libs/shouldOpenLastVisitedPath/index.native.ts - Updated path logic
  • src/pages/iou/request/step/IOURequestStepScan/index.native.tsx - Added navigation trigger

Recommendation

This PR should not be reviewed using HelpDot documentation criteria as it contains no documentation changes. The changes are purely functional code improvements for the expense scanning user flow.

For future reference, HelpDot documentation reviews should only be requested for PRs that modify files in the docs/ directory or other markdown documentation files.

Next Steps

Please direct this PR to appropriate code reviewers rather than documentation reviewers, as it implements a navigation enhancement rather than documentation updates.

@mountiny mountiny left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but I would love a review from navigation team before merging

rafecolton
rafecolton previously approved these changes Oct 10, 2025

@rafecolton rafecolton left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mountiny

Copy link
Copy Markdown
Contributor

Bumped @adamgrzybowski and @WojtekBoman for a review, I think they both were ooo

Comment thread src/libs/actions/App.ts
AppState.addEventListener('change', (nextAppState) => {
if (nextAppState.match(/inactive|background/) && appState === 'active') {
Log.info('Flushing logs as app is going inactive', true, {}, true);
saveCurrentPathBeforeBackground();

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, I'd like to make sure about this part :)

Why do we need to save it here? Can't we save it when we open this page like it's done in parseAndLogRoute?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its added because we are trying to fix the issue when you are going to change some permissions in the OS settings then app navigation state is reset and user is navigated to Inbox. this is for saving the navigation state before doing that to be able then to navigate to the screen which user was before.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I understand that part. I'm just wondering if we can save this information earlier. Now, saveCurrentPathBeforeBackground will be called every time the app goes to the background. Is the navigation state different when we go to the background and when we're on the scanned receipt screen?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see CONST.EXCLUDE_FROM_LAST_VISITED_PATH has been modified, so updateLastVisitedPath won't be called in parseAndLogRoute when we're on this page

Comment thread src/libs/shouldOpenLastVisitedPath/index.native.ts

@mountiny mountiny left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dukenv0307 could you retest now after the changes too please?

@dukenv0307

Copy link
Copy Markdown
Contributor
Screen.Recording.2025-10-16.at.11.53.02.mov

@melvin-bot melvin-bot Bot requested a review from mountiny October 16, 2025 04:54
@dukenv0307

Copy link
Copy Markdown
Contributor

LGTM

@kubabutkiewicz

Copy link
Copy Markdown
Contributor Author

@mountiny could you take a look here?

@kubabutkiewicz

Copy link
Copy Markdown
Contributor Author

@mountiny @rafecolton Can we merge this PR 😄 ?

@mountiny mountiny left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok I will go ahead and merge to avoid more conflicts

@mountiny mountiny merged commit ba8e4c8 into Expensify:main Oct 22, 2025
24 checks passed
@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/mountiny in version: 9.2.37-1 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/blimpich in version: 9.2.37-8 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants