Skip to content

[CP Staging] Revert "Jakubkalinski0/fix console errors related to forward ref batch7"#72106

Merged
lakchote merged 5 commits into
mainfrom
revert-71896-jakubkalinski0/Fix-console-errors-related-to-forwardRef-batch7
Oct 8, 2025
Merged

[CP Staging] Revert "Jakubkalinski0/fix console errors related to forward ref batch7"#72106
lakchote merged 5 commits into
mainfrom
revert-71896-jakubkalinski0/Fix-console-errors-related-to-forwardRef-batch7

Conversation

@lakchote

@lakchote lakchote commented Oct 8, 2025

Copy link
Copy Markdown
Contributor

Reverts #71896

@melvin-bot

melvin-bot Bot commented Oct 8, 2025

Copy link
Copy Markdown

Hey! I see that you made changes to our Form component. Make sure to update the docs in FORMS.md accordingly. Cheers!

@github-actions

github-actions Bot commented Oct 8, 2025

Copy link
Copy Markdown
Contributor

🚧 @lakchote has triggered a test Expensify/App build. You can view the workflow run here.

@codecov

codecov Bot commented Oct 8, 2025 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 37.87879% with 41 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/components/ContextMenuItem.tsx 0.00% 12 Missing ⚠️
src/components/DatePicker/index.tsx 0.00% 7 Missing ⚠️
src/components/MagicCodeInput.tsx 46.15% 7 Missing ⚠️
src/components/PercentageForm.tsx 0.00% 3 Missing ⚠️
...rc/components/ActionSheetAwareScrollView/index.tsx 0.00% 2 Missing ⚠️
src/components/AddressSearch/index.tsx 85.71% 0 Missing and 1 partial ⚠️
src/components/AmountPicker/index.tsx 0.00% 1 Missing ⚠️
src/components/AmountWithoutCurrencyInput.tsx 0.00% 1 Missing ⚠️
src/components/CurrencySelector.tsx 75.00% 0 Missing and 1 partial ⚠️
src/components/FormScrollView.tsx 0.00% 1 Missing ⚠️
... and 5 more

📢 Thoughts on this report? Let us know!

@github-actions

This comment has been minimized.

Sign in to view
mountiny
mountiny previously approved these changes Oct 8, 2025
View reviewed changes

@mountiny mountiny left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on the adhoc and it works

@github-actions

github-actions Bot commented Oct 8, 2025

Copy link
Copy Markdown
Contributor

🚧 @lakchote has triggered a test Expensify/App build. You can view the workflow run here.

MonilBhavsar
MonilBhavsar previously approved these changes Oct 8, 2025
View reviewed changes

@MonilBhavsar MonilBhavsar left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and it resolves issue

@github-actions

github-actions Bot commented Oct 8, 2025

Copy link
Copy Markdown
Contributor

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪
Built from App PR #72106.

Android 🤖 iOS 🍎
⏩ SKIPPED ⏩ https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/72106/index.html
The build for Android was skipped iOS
Desktop 💻 Web 🕸️
⏩ SKIPPED ⏩ ⏩ SKIPPED ⏩
The build for Desktop was skipped The build for Web was skipped

👀 View the workflow run that generated this build 👀

mountiny
mountiny reviewed Oct 8, 2025
View reviewed changes
Comment thread src/components/AmountWithoutCurrencyInput.tsx
AmountWithoutCurrencyInput.displayName = 'AmountWithoutCurrencyInput';

export default AmountWithoutCurrencyInput;
export default React.forwardRef(AmountWithoutCurrencyInput);

@mountiny mountiny Oct 8, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to go back to this:

function AmountWithoutCurrencyInput(
    {value: amount, shouldAllowNegative = false, inputID, name, defaultValue, accessibilityLabel, role, label, onInputChange, ...rest}: AmountFormProps,
    ref: ForwardedRef<BaseTextInputRef>,
) {

But add the new props that has been added

mountiny
mountiny previously approved these changes Oct 8, 2025
View reviewed changes

@mountiny mountiny left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The latest conflict resolution looks good

@github-actions

github-actions Bot commented Oct 8, 2025

Copy link
Copy Markdown
Contributor

🚧 @mountiny has triggered a test Expensify/App build. You can view the workflow run here.

@github-actions

github-actions Bot commented Oct 8, 2025

Copy link
Copy Markdown
Contributor

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪
Built from App PR #72106.

Android 🤖 iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/72106/index.html https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/72106/index.html
Android iOS
Desktop 💻 Web 🕸️
❌ FAILED ❌ https://72106.pr-testing.expensify.com
The QR code can't be generated, because the Desktop build failed Web

👀 View the workflow run that generated this build 👀

@mountiny

mountiny commented Oct 8, 2025

Copy link
Copy Markdown
Contributor

Works!

@mountiny mountiny changed the title Revert "Jakubkalinski0/fix console errors related to forward ref batch7" [CP Staging] Revert "Jakubkalinski0/fix console errors related to forward ref batch7" Oct 8, 2025
@lakchote lakchote marked this pull request as ready for review October 8, 2025 17:56
@lakchote lakchote requested a review from a team as a code owner October 8, 2025 17:56
@lakchote lakchote merged commit d005353 into main Oct 8, 2025
22 of 26 checks passed
@lakchote lakchote deleted the revert-71896-jakubkalinski0/Fix-console-errors-related-to-forwardRef-batch7 branch October 8, 2025 17:56
@melvin-bot melvin-bot Bot added the Emergency label Oct 8, 2025
@melvin-bot

melvin-bot Bot commented Oct 8, 2025

Copy link
Copy Markdown

@lakchote looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@lakchote lakchote removed the Emergency label Oct 8, 2025
@lakchote

lakchote commented Oct 8, 2025

Copy link
Copy Markdown
Contributor Author

Not emergency, straight revert

@melvin-bot melvin-bot Bot requested review from Beamanator and removed request for a team October 8, 2025 17:57
@melvin-bot

melvin-bot Bot commented Oct 8, 2025

Copy link
Copy Markdown

@Beamanator Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@os-botify os-botify Bot mentioned this pull request Oct 8, 2025
Merged
52 tasks
@OSBotify OSBotify added the CP Staging marks PRs that have been CP'd to staging label Oct 8, 2025
@OSBotify

OSBotify commented Oct 8, 2025

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

mountiny pushed a commit that referenced this pull request Oct 8, 2025
@lakchote @mountiny
Merge pull request #72106 from Expensify/revert-71896-jakubkalinski0/…
3711e4d 
…Fix-console-errors-related-to-forwardRef-batch7

[CP Staging] Revert "Jakubkalinski0/fix console errors related to forward ref batch7"

(cherry picked from commit d005353)

(cherry-picked to staging by mountiny)
lakchote added a commit that referenced this pull request Oct 8, 2025
@lakchote
Merge pull request #72124 from Expensify/cherry-pick-staging-72106-18…
eea7275 
…353794631-1

🍒 Cherry pick PR #72106 to staging 🍒
@OSBotify OSBotify mentioned this pull request Oct 8, 2025
Closed
62 tasks
@OSBotify

OSBotify commented Oct 8, 2025

Copy link
Copy Markdown
Contributor

🚀 Cherry-picked to staging by https://github.com/lakchote in version: 9.2.27-4 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

lakchote added a commit that referenced this pull request Oct 8, 2025
@lakchote
Merge pull request #72124 from Expensify/cherry-pick-staging-72106-18…
823e9d6 
…353794631-1

🍒 Cherry pick PR #72106 to staging 🍒

(cherry picked from commit eea7275)
@OSBotify

OSBotify commented Oct 8, 2025

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/lakchote in version: 9.2.27-6 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify

OSBotify commented Oct 8, 2025

Copy link
Copy Markdown
Contributor

🚀 Cherry-picked to staging by https://github.com/lakchote in version: 9.2.28-0 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify

OSBotify commented Oct 10, 2025

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/lakchote in version: 9.2.28-5 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@jakubkalinski0 jakubkalinski0 mentioned this pull request Nov 6, 2025
Merged
54 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mountiny mountiny mountiny approved these changes

@MonilBhavsar MonilBhavsar MonilBhavsar left review comments

@Beamanator Beamanator Awaiting requested review from Beamanator

Assignees

@lakchote lakchote

Labels

CP Staging marks PRs that have been CP'd to staging

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@lakchote @mountiny @OSBotify @MonilBhavsar