-
Notifications
You must be signed in to change notification settings - Fork 3.9k
Rename Policy Rooms #7217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Rename Policy Rooms #7217
Changes from all commits
Commits
Show all changes
28 commits
Select commit
Hold shift + click to select a range
cd842f2
add RenameReport API function
luacmartins 4c5ffa0
export function and add comment
luacmartins c0911ef
add renameReport action
luacmartins 232836e
add event handler to ReportSettingsPage
luacmartins 18fdd5c
update spanish copy
luacmartins ed54092
fix style
luacmartins 570eba1
remove loading state
luacmartins 5caf463
replace policyID with reportID in all function calls
luacmartins edc04f2
update copy
luacmartins 699ebfa
add renamed const and include renamed action in report action filter
luacmartins 60e05ea
update reportName on LHN and header
luacmartins e0a4083
merge main
luacmartins af3b558
add loading state to rename policy form
luacmartins 1e46cad
create RenameAction
luacmartins 364a5c4
fix style
luacmartins 861e88d
change lastMessage logic
luacmartins 0fa0c2d
update isConsecutiveActionMadeByPreviousActor to not group renamed ac…
luacmartins 0080bf8
update comment
luacmartins d8a1a86
Merge branch 'main' into cmartins-renamePolicyRooms
luacmartins 0b21d5b
add comment
luacmartins bf3ccfa
remove dot on copy
luacmartins 05314f0
fix style
luacmartins b6c83d3
rm podlock-file commit
luacmartins e6af3dd
rename AnnouceAction component
luacmartins cfe9cda
rename translattion keys
luacmartins f0f2070
update comment
luacmartins 1970d36
use pv3 for style and update comment
luacmartins b8bd6f4
rm wrong commit of podfile.lock
luacmartins File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -213,6 +213,7 @@ const CONST = { | |
| TYPE: { | ||
| IOU: 'IOU', | ||
| ADDCOMMENT: 'ADDCOMMENT', | ||
| RENAMED: 'RENAMED', | ||
| }, | ||
| }, | ||
| ERROR: { | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,34 @@ | ||
| import React from 'react'; | ||
| import PropTypes from 'prop-types'; | ||
| import lodashGet from 'lodash/get'; | ||
| import Text from '../Text'; | ||
| import styles from '../../styles/styles'; | ||
| import reportActionPropTypes from '../../pages/home/report/reportActionPropTypes'; | ||
| import withLocalize, {withLocalizePropTypes} from '../withLocalize'; | ||
|
|
||
| const propTypes = { | ||
| /** All the data of the action */ | ||
| action: PropTypes.shape(reportActionPropTypes).isRequired, | ||
|
|
||
| ...withLocalizePropTypes, | ||
| }; | ||
|
|
||
| const RenameAction = (props) => { | ||
| const displayName = lodashGet(props.action, ['message', 0, 'text']); | ||
| const oldName = lodashGet(props.action, 'originalMessage.oldName', ''); | ||
| const newName = lodashGet(props.action, 'originalMessage.newName', ''); | ||
|
|
||
| return ( | ||
| <Text style={[styles.pv3, styles.ph5, styles.textAlignCenter, styles.textLabelSupporting]}> | ||
| <Text style={[styles.textLabelSupporting, styles.textStrong]}> | ||
| {displayName} | ||
| </Text> | ||
| {props.translate('newRoomPage.renamedRoomAction', {oldName, newName})} | ||
| </Text> | ||
| ); | ||
| }; | ||
|
|
||
| RenameAction.propTypes = propTypes; | ||
| RenameAction.displayName = 'RenameAction'; | ||
|
|
||
| export default withLocalize(RenameAction); | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.