Skip to content

Trim Room title on the report details page#7223

Merged
iwiznia merged 5 commits into
Expensify:mainfrom
parasharrajat:roomdetails
Jan 28, 2022
Merged

Trim Room title on the report details page#7223
iwiznia merged 5 commits into
Expensify:mainfrom
parasharrajat:roomdetails

Conversation

@parasharrajat

@parasharrajat parasharrajat commented Jan 14, 2022

Copy link
Copy Markdown
Member

Details

Fixed Issues

$ #7181

Tests | QA Steps

  1. Go to staging.new.expensify.com
  2. log in expensifail account
  3. Click FAB + > New room
  4. You need to enter long room name
  5. Select any Workspace
  6. Tap Create
  • Verify that no errors appear in the JS console

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

image

Mobile Web

image

Desktop

image
image

iOS

image

Android

image

@parasharrajat parasharrajat marked this pull request as ready for review January 28, 2022 05:19
@parasharrajat parasharrajat requested a review from a team as a code owner January 28, 2022 05:19
@botify botify requested a review from iwiznia January 28, 2022 05:19
@MelvinBot MelvinBot removed the request for review from a team January 28, 2022 05:19
@iwiznia iwiznia merged commit c8d47a0 into Expensify:main Jan 28, 2022
@OSBotify

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify

OSBotify commented Feb 1, 2022

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by @iwiznia in version: 1.1.33-4 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify

OSBotify commented Feb 2, 2022

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by @sketchydroide in version: 1.1.34-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants