Make WorkspaceCategoriesSettingsPage use new SelectionList by GCyganek · Pull Request #72315 · Expensify/App

GCyganek · 2025-10-10T12:23:35Z

Explanation of Change

Fixed Issues

$ #65655
PROPOSAL: N/A

Tests

Create a workspace
Open Categories screen in your workspace
Click on More at the top right corner
Click on Settings to open the list
Verify that the list is working correctly by changing any of the default spend categories

Verify that no errors appear in the JS console

Offline tests

QA Steps

Same as tests

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I verified there are no new alerts related to the canBeMissing param for useOnyx
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If new assets were added or existing ones were modified, I verified that:
- The assets are optimized and compressed (for SVG files, run npm run compress-svg)
- The assets load correctly across all supported platforms.
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Screen.Recording.2025-10-10.at.14.11.38.mov

Android: mWeb Chrome

Screen.Recording.2025-10-10.at.14.16.48.mov

iOS: Native

Screen.Recording.2025-10-10.at.14.22.07.mov

iOS: mWeb Safari

Screen.Recording.2025-10-10.at.14.22.49.mov

MacOS: Chrome / Safari

Screen.Recording.2025-10-10.at.14.08.12.mov

MacOS: Desktop

Screen.Recording.2025-10-10.at.14.13.12.mov

codecov · 2025-10-10T12:34:40Z

Codecov Report

❌ Patch coverage is 0% with 9 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
...ace/categories/WorkspaceCategoriesSettingsPage.tsx	0.00%	9 Missing ⚠️

Files with missing lines	Coverage Δ
...ionList/ListItem/SpendCategorySelectorListItem.tsx	`0.00% <ø> (ø)`
...ace/categories/WorkspaceCategoriesSettingsPage.tsx	`0.00% <0.00%> (ø)`

... and 15 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

zfurtak

LGTM, just left some thoughts ✨

zfurtak · 2025-10-10T18:06:50Z

 };

-type ValidListItem = typeof RadioListItem;
+type ValidListItem = typeof RadioListItem | typeof BaseListItem | typeof MultiSelectListItem | typeof SingleSelectListItem | typeof SpendCategorySelectorListItem;


Good catch 😌

zfurtak · 2025-10-10T18:07:29Z

    const isToggleDisabled = !policy?.areCategoriesEnabled || !hasEnabledCategories || isConnectedToAccounting;

-    const setNewCategory = (selectedCategory: ListItem) => {
-        if (!selectedCategory.keyForList || !groupID) {


Why this check is not needed anymore? What happen if groupID is not set initially? 🤔

Instead I added currentGroupID prop to the setNewCategory function, because looking at the logic, the only usage of this function will have groupID defined:

{!!categoryID && !!groupID && ( <CategorySelectorModal ... onCategorySelected={(selectedCategory) => setNewCategory(selectedCategory, groupID)} ... />

zfurtak · 2025-10-10T18:10:45Z

+                                customListHeaderContent={
                                    <View style={[styles.mh5, styles.mt2, styles.mb1]}>
                                        <Text style={[styles.headerText]}>{translate('workspace.categories.defaultSpendCategories')}</Text>
                                        <Text style={[styles.mt1, styles.lh20]}>{translate('workspace.categories.spendCategoriesDescription')}</Text>
                                    </View>
                                }


What do you think about moving this code above return?

I think in this case it's more of a preference, I tried to find style guidelines for this kind of situations for this project but I couldn't. I moved it above return as well as onSelectRow handler anyway.

melvin-bot · 2025-10-14T09:35:41Z

@rushatgabhane Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

dukenv0307 · 2025-10-22T02:14:46Z

        });
    };

+    const onSelectItem = (item: ListItem) => {


let's wrap it into useCallback

dukenv0307 · 2025-10-22T02:14:58Z

+        setGroupID(item.groupID);
+    };
+
+    const selectionListHeaderContent = (


let's wrap it into useMemo

Is it really necessary to wrap these into useMemo and useCallback? I played a bit with the Profiler and it doesn't show any rerenders of SelectionList caused by onSelectRow and customListHeaderContent when I'm using the list. It looks like React Compiler takes care of the memoization here to prevent unnecessary re-renders. What do you think?

dukenv0307 · 2025-10-22T02:38:39Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Screen.Recording.2025-10-22.at.09.35.11.mov

Android: mWeb Chrome

Screen.Recording.2025-10-22.at.09.33.13.mov

iOS: HybridApp

Screen.Recording.2025-10-22.at.09.35.45.mov

iOS: mWeb Safari

Screen.Recording.2025-10-22.at.09.31.41.mov

MacOS: Chrome / Safari

Screen.Recording.2025-10-22.at.09.29.26.mov

MacOS: Desktop

Screen.Recording.2025-10-22.at.09.37.47.mov

dukenv0307 · 2025-10-22T02:38:54Z

@GCyganek We got the conflict.

…sPage-SelectionList

OSBotify · 2025-10-23T15:15:03Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2025-10-24T18:17:20Z

🚀 Deployed to staging by https://github.com/grgia in version: 9.2.38-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2025-10-27T20:06:44Z

🚀 Deployed to production by https://github.com/puneetlath in version: 9.2.38-5 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Make WorkspaceCategoriesSettingsPage use new SelectionList

01fc28f

melvin-bot Bot assigned GCyganek Oct 10, 2025

Fix type

adcd8c8

zfurtak mentioned this pull request Oct 10, 2025

[Due for payment 2026-01-23] [SelectionList Improvements][Phase 2] Migrate all usages (~100) #65655

Closed

zfurtak approved these changes Oct 10, 2025

View reviewed changes

Move selection list header content and onSelectItem above header

f7e666d

GCyganek marked this pull request as ready for review October 14, 2025 09:35

GCyganek requested a review from a team as a code owner October 14, 2025 09:35

melvin-bot Bot requested review from rushatgabhane and removed request for a team October 14, 2025 09:35

grgia mentioned this pull request Oct 20, 2025

Migrate Wave 2 #72968

Closed

grgia requested review from dukenv0307 and removed request for rushatgabhane October 21, 2025 10:01

dukenv0307 reviewed Oct 22, 2025

View reviewed changes

Merge branch 'main' into @GCyganek/migrate-WorkspaceCategoriesSetting…

a273a27

…sPage-SelectionList

dukenv0307 approved these changes Oct 23, 2025

View reviewed changes

melvin-bot Bot requested a review from grgia October 23, 2025 02:09

grgia approved these changes Oct 23, 2025

View reviewed changes

grgia merged commit 9400bfb into Expensify:main Oct 23, 2025
27 checks passed

OSBotify mentioned this pull request Oct 24, 2025

Deploy Checklist: New Expensify 2025-10-24 #73445

Closed

71 tasks

Conversation

GCyganek commented Oct 10, 2025

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

codecov Bot commented Oct 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

zfurtak left a comment

Choose a reason for hiding this comment

Uh oh!

zfurtak Oct 10, 2025

Choose a reason for hiding this comment

Uh oh!

zfurtak Oct 10, 2025

Choose a reason for hiding this comment

Uh oh!

GCyganek Oct 12, 2025

Choose a reason for hiding this comment

Uh oh!

zfurtak Oct 13, 2025

Choose a reason for hiding this comment

Uh oh!

zfurtak Oct 10, 2025

Choose a reason for hiding this comment

Uh oh!

GCyganek Oct 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

melvin-bot Bot commented Oct 14, 2025

Uh oh!

dukenv0307 Oct 22, 2025

Choose a reason for hiding this comment

Uh oh!

dukenv0307 Oct 22, 2025

Choose a reason for hiding this comment

Uh oh!

GCyganek Oct 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dukenv0307 commented Oct 22, 2025

Reviewer Checklist

Screenshots/Videos

Uh oh!

dukenv0307 commented Oct 22, 2025

Uh oh!

Uh oh!

OSBotify commented Oct 23, 2025

Uh oh!

OSBotify commented Oct 24, 2025

Uh oh!

OSBotify commented Oct 27, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

codecov Bot commented Oct 10, 2025 •

edited

Loading

GCyganek Oct 12, 2025 •

edited

Loading

GCyganek Oct 22, 2025 •

edited

Loading