[Native] Disable Import Contacts Modal if user is coming from Share Extension#72335
[Native] Disable Import Contacts Modal if user is coming from Share Extension#72335grgia wants to merge 7 commits into
Conversation
|
🚧 @grgia has triggered a test Expensify/App build. You can view the workflow run here. |
Codecov Report❌ Patch coverage is
... and 9 files with indirect coverage changes 🚀 New features to boost your workflow:
|
This comment has been minimized.
This comment has been minimized.
|
@dominictb Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
LGTM |
|
I'll review this tomorrow morning. |
|
@dominictb I merged main & triggered a build to help |
|
🚧 @grgia has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪
|
|
@dominictb are you able to get to this one today? |
|
I think we should go with this solution instead: #73407 |
|
It did not resolve the issue https://expensify.slack.com/archives/C05LX9D6E07/p1761558749225479?thread_ts=1760084302.254359&cid=C05LX9D6E07 |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / SafariMacOS: Desktop |
|
Still discussing in Slack |
|
Original issue is resolved, so I think we can close this now |
Explanation of Change
I was going to check the temp file in ONYX to check for the extension, but I realize we do not unmount it until the next share is initiated. I decided to pass the prop down for simplicity.
Fixed Issues
$ #72301
Tests
Offline tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
On IOS/Android
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop