Fix Move Expense check by luacmartins · Pull Request #72366 · Expensify/App

luacmartins · 2025-10-10T20:47:08Z

Explanation of Change

The checks for canChangeReport relied on live data, but that data is not always available when interacting with search results. This PR refactors canEditFieldOfMoneyRequest and its dependent functions to be pure and allow reportAction, report, transaction and policy to be passed as params for the check. We then refactored TransactionListItem to include this data.

One exception is this check, currently it relies on having all report transactions loaded locally, which would be unfeasible. So we're working on a different solution in the BE and will address that in a follow up.

Fixed Issues

$ #72032

Tests

Create two reports
Add an expense to one of them
Clear cache and restart
Go to Reports > Expenses
Select an expense in the list
Observe that "Move expense" option is in the bulk select menu (without opening the expense first)
Search for type:expense group-by:from
Expand the group
Select the transaction and verify that you see the Move expense option

Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

Same as tests

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Screen.Recording.2025-10-15.at.9.43.35.AM.mov

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

codecov · 2025-10-10T20:57:48Z

Codecov Report

❌ Patch coverage is 46.55172% with 31 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
src/components/Search/index.tsx	0.00%	18 Missing ⚠️
src/pages/iou/HoldReasonPage.tsx	0.00%	7 Missing ⚠️
...nents/ReportActionItem/MoneyRequestReceiptView.tsx	0.00%	2 Missing ⚠️
src/hooks/useShowNotFoundPageInIOUStep.ts	0.00%	2 Missing ⚠️
...c/components/ReportActionItem/MoneyRequestView.tsx	0.00%	1 Missing ⚠️
src/libs/ReportUtils.ts	90.90%	1 Missing ⚠️

Files with missing lines	Coverage Δ
...m/TransactionPreview/TransactionPreviewContent.tsx	`73.68% <100.00%> (+0.23%)`	⬆️
src/libs/SearchUIUtils.ts	`70.31% <100.00%> (+0.98%)`	⬆️
...c/components/ReportActionItem/MoneyRequestView.tsx	`0.28% <0.00%> (ø)`
src/libs/ReportUtils.ts	`74.65% <90.90%> (-0.08%)`	⬇️
...nents/ReportActionItem/MoneyRequestReceiptView.tsx	`2.17% <0.00%> (-0.02%)`	⬇️
src/hooks/useShowNotFoundPageInIOUStep.ts	`7.14% <0.00%> (-0.55%)`	⬇️
src/pages/iou/HoldReasonPage.tsx	`0.00% <0.00%> (ø)`
src/components/Search/index.tsx	`0.00% <0.00%> (ø)`

... and 8 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

melvin-bot · 2025-10-15T15:45:42Z

@brunovjk Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

luacmartins · 2025-10-15T15:46:18Z

@brunovjk this PR depends on some BE changes that are still not merged/deployed. I'll let you know once that's ready. In the meantime, you can review the rest of the code.

aimane-chnaif · 2025-10-22T20:27:33Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

android.mov

Android: mWeb Chrome

mchrome.mov

iOS: HybridApp

ios.mov

iOS: mWeb Safari

msafari.mov

MacOS: Chrome / Safari

web.mov

MacOS: Desktop

desktop.mov

aimane-chnaif · 2025-10-23T00:32:19Z

There's conflict

luacmartins · 2025-10-23T16:47:35Z

@aimane-chnaif resolved

melvin-bot · 2025-10-23T17:42:37Z

@mollfpr Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

JS00001 · 2025-10-24T14:08:54Z

conflicts 😢

OSBotify · 2025-10-24T15:36:51Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2025-10-24T18:17:26Z

🚀 Deployed to staging by https://github.com/luacmartins in version: 9.2.38-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2025-10-27T20:06:50Z

🚀 Deployed to production by https://github.com/puneetlath in version: 9.2.38-5 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

dukenv0307 · 2025-11-19T15:02:04Z

    const firstViolation = violations.at(0);
    const isIOUActionType = isMoneyRequestAction(action);
-    const canEdit = isIOUActionType && canEditMoneyRequest(action, transaction);
+    const canEdit = isIOUActionType && canEditMoneyRequest(action, isChatReportArchived, report, policy, transaction);


Coming from #73516, the report passed to canEditMoneyRequest should be iouReport

use snapshot data

262961a

luacmartins self-assigned this Oct 10, 2025

luacmartins added 2 commits October 13, 2025 12:36

Merge branch 'main' into cmartins-useSaerchReportActions

b1e80ec

fix ts

98df80f

luacmartins changed the title ~~use snapshot data~~ Fix Move Expense check Oct 14, 2025

luacmartins added 18 commits October 14, 2025 12:06

resolve conflicts

b5a5d4c

update function signature

c92a707

gst

67b07b5

refactor usages of canEditFieldOfMoneyRequest

f662310

refactor more code

ceb3c92

fix conditional

b8239d6

update map

ccb6872

revert chants

9eb946d

refacor data

5eab236

rm searchreportaction

14347c7

rm unused code

52aa166

fix prettier, eslint

8d5314a

fix tests

a51d9ed

fix eslint

521716e

fix more tests

983d131

fix more tests

897e082

rm const

e196d55

resolve conflicts

1fe0630

luacmartins marked this pull request as ready for review October 15, 2025 15:45

luacmartins requested a review from a team as a code owner October 15, 2025 15:45

melvin-bot Bot requested review from brunovjk and removed request for a team October 15, 2025 15:45