Skip to content

fix building optimistic transaction for negative values #72449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nkuoch merged 3 commits into from
Oct 22, 2025
Merged

fix building optimistic transaction for negative values #72449

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
25e4a22
fix building optimistic transaction for negative values
kubabutkiewicz Oct 13, 2025
3d4501b
Merge branch 'main' of github.com:callstack-internal/Expensify-App in…
kubabutkiewicz Oct 21, 2025
445f06e
Merge branch 'main' of github.com:callstack-internal/Expensify-App in…
kubabutkiewicz Oct 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/libs/actions/IOU.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,6 +199,7 @@ import {
isTrackExpenseReport,
prepareOnboardingOnyxData,
shouldCreateNewMoneyRequestReport as shouldCreateNewMoneyRequestReportReportUtils,
shouldEnableNegative,
updateReportPreview,
} from '@libs/ReportUtils';
import {getCurrentSearchQueryJSON} from '@libs/SearchQueryUtils';
Expand Down Expand Up @@ -4762,8 +4763,9 @@ function getUpdateTrackExpenseParams(
// - we're merging two expenses (server does not create MODIFIED_EXPENSE in this flow)
// In these cases, there isn't a valid optimistic mileage data we can use,
// and the report action is created on the server with the distance-related response from the MapBox API
const allowNegative = shouldEnableNegative(transactionThread ?? undefined);
const updatedReportAction = shouldBuildOptimisticModifiedExpenseReportAction
? buildOptimisticModifiedExpenseReportAction(transactionThread, transaction, transactionChanges, false, policy, updatedTransaction)
? buildOptimisticModifiedExpenseReportAction(transactionThread, transaction, transactionChanges, false, policy, updatedTransaction, allowNegative)
: null;
if (!hasPendingWaypoints && !(hasModifiedDistanceRate && isFetchingWaypointsFromServer(transaction)) && updatedReportAction) {
apiParams.reportActionID = updatedReportAction.reportActionID;
Expand Down
Loading