Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
a26a0ca
Remove isRowMultilineSupported prop and set 2-line text wrap as default
huult Oct 13, 2025
15f17b4
Add 8px right padding between text and checkbox
huult Oct 13, 2025
6feeb6f
Remove unused code
huult Oct 13, 2025
c429aeb
Merge remote-tracking branch 'upstream/main' into 71352-allow-selecti…
huult Oct 14, 2025
ef84b10
Update props for native select list
huult Oct 14, 2025
10bafda
Merge remote-tracking branch 'upstream/main' into 71352-allow-selecti…
huult Oct 28, 2025
e00c9c8
Merge remote-tracking branch 'upstream/main' into 71352-allow-selecti…
huult Oct 31, 2025
2e39a2f
Merge remote-tracking branch 'upstream/main' into 71352-allow-selecti…
huult Nov 3, 2025
1ba049b
Merge remote-tracking branch 'upstream/main' into 71352-allow-selecti…
huult Nov 7, 2025
21ca6c9
Merge remote-tracking branch 'upstream/main' into 71352-allow-selecti…
huult Nov 14, 2025
473e071
Merge remote-tracking branch 'upstream/main' into 71352-allow-selecti…
huult Nov 17, 2025
ac90c2e
Merge remote-tracking branch 'upstream/main' into 71352-allow-selecti…
huult Nov 18, 2025
2ed6ac1
Use isMultilineSupported by default, so no need for this height
huult Nov 18, 2025
e516b74
add ml3 for checkbox
huult Nov 18, 2025
fc031c7
Merge remote-tracking branch 'upstream/main' into 71352-allow-selecti…
huult Nov 19, 2025
7113c49
Merge remote-tracking branch 'upstream/main' into 71352-allow-selecti…
huult Nov 21, 2025
05ccf5c
Merge remote-tracking branch 'upstream/main' into 71352-allow-selecti…
huult Nov 24, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/components/CategoryPicker.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,6 @@ function CategoryPicker({selectedCategory, policyID, onSubmit, addBottomSafeArea
onSelectRow={onSubmit}
ListItem={RadioListItem}
initiallyFocusedOptionKey={selectedOptionKey ?? undefined}
isRowMultilineSupported
addBottomSafeAreaPadding={addBottomSafeAreaPadding}
contentContainerStyle={contentContainerStyle}
/>
Expand Down
1 change: 0 additions & 1 deletion src/components/DestinationPicker.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,6 @@ function DestinationPicker({selectedDestination, policyID, onSubmit}: Destinatio
onSelectRow={onSubmit}
ListItem={RadioListItem}
initiallyFocusedOptionKey={selectedOptionKey ?? undefined}
isRowMultilineSupported
shouldHideKeyboardOnScroll={false}
/>
);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -35,9 +35,10 @@ function MultiSelectListItem<TItem extends ListItem>({
accessibilityLabel={item.text ?? ''}
onPress={() => onSelectRow(item)}
isIndeterminate={item.isIndeterminate}
style={[isMultilineSupported ? styles.ml3 : null]}
/>
);
}, [isSelected, item, onSelectRow]);
}, [isMultilineSupported, isSelected, item, onSelectRow, styles.ml3]);

return (
<RadioListItem
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ function SelectionListWithSections<TItem extends ListItem>({shouldHideKeyboardOn
}
Keyboard.dismiss();
}}
isRowMultilineSupported
/>
);
}
Expand Down
1 change: 1 addition & 0 deletions src/components/SelectionListWithSections/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,7 @@ function SelectionListWithSections<TItem extends ListItem>({onScroll, shouldHide
// For example, a long press will trigger a focus event on mobile chrome.
shouldIgnoreFocus={isMobileChrome() && isScreenTouched}
shouldDebounceScrolling={shouldDebounceScrolling}
isRowMultilineSupported
shouldDisableHoverStyle={shouldDisableHoverStyle}
setShouldDisableHoverStyle={setShouldDisableHoverStyle}
/>
Expand Down
1 change: 0 additions & 1 deletion src/components/TagPicker.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,6 @@ function TagPicker({
textInputValue={searchValue}
headerMessage={headerMessage}
textInputLabel={shouldShowTextInput ? translate('common.search') : undefined}
isRowMultilineSupported
initiallyFocusedOptionKey={selectedOptionKey}
onChangeText={setSearchValue}
onSelectRow={onSubmit}
Expand Down
1 change: 0 additions & 1 deletion src/components/TaxPicker.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,6 @@ function TaxPicker({selectedTaxRate = '', policyID, transactionID, onSubmit, act
onSelectRow={handleSelectRow}
ListItem={RadioListItem}
initiallyFocusedOptionKey={selectedOptionKey ?? undefined}
isRowMultilineSupported
addBottomSafeAreaPadding={addBottomSafeAreaPadding}
/>
);
Expand Down
1 change: 0 additions & 1 deletion src/pages/Debug/ConstantPicker.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,6 @@ function ConstantPicker({formType, fieldName, fieldValue, onSubmit}: ConstantPic
onSelectRow={onSubmit}
ListItem={RadioListItem}
initiallyFocusedItemKey={selectedOptionKey}
isRowMultilineSupported
/>
);
}
Expand Down
1 change: 0 additions & 1 deletion src/pages/EditReportFieldDropdown.tsx
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import React, {useCallback, useMemo} from 'react';
import Icon from '@components/Icon';
import * as Expensicons from '@components/Icon/Expensicons';

Check warning on line 3 in src/pages/EditReportFieldDropdown.tsx

View workflow job for this annotation

GitHub Actions / Changed files ESLint check

'@components/Icon/Expensicons' import is restricted from being used by a pattern. Direct imports from Icon/Expensicons are deprecated. Please use lazy loading hooks instead. Use `useMemoizedLazyExpensifyIcons` from @hooks/useLazyAsset. See docs/LAZY_ICONS_AND_ILLUSTRATIONS.md for details

Check warning on line 3 in src/pages/EditReportFieldDropdown.tsx

View workflow job for this annotation

GitHub Actions / Changed files ESLint check

'@components/Icon/Expensicons' import is restricted from being used. Direct imports from @components/Icon/Expensicons are deprecated. Please use lazy loading hooks instead. Use `useMemoizedLazyExpensifyIcons` from @hooks/useLazyAsset. See docs/LAZY_ICONS_AND_ILLUSTRATIONS.md for details
import SelectionList from '@components/SelectionListWithSections';
import RadioListItem from '@components/SelectionListWithSections/RadioListItem';
import type {ListItem} from '@components/SelectionListWithSections/types';
Expand Down Expand Up @@ -83,7 +83,6 @@
onChangeText={setSearchValue}
headerMessage={headerMessage}
ListItem={RadioListItem}
isRowMultilineSupported
rightHandSideComponent={itemRightSideComponent}
/>
);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,6 @@ function NetSuiteCustomListSelectorModal({isVisible, currentCustomListValue, onC
onSelectRow={onCustomListSelected}
headerMessage={headerMessage}
ListItem={RadioListItem}
isRowMultilineSupported
initiallyFocusedOptionKey={currentCustomListValue}
shouldSingleExecuteRowSelect
shouldStopPropagation
Expand Down
1 change: 0 additions & 1 deletion src/styles/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1839,7 +1839,6 @@ const staticStyles = (theme: ThemeColors) =>
},

optionRowCompact: {
height: variables.optionRowHeightCompact,
minHeight: variables.optionRowHeightCompact,
paddingTop: 12,
paddingBottom: 12,
Expand Down
Loading