[No QA] Use Android react-native prebuilds in adhoc workflow by mateuuszzzzz · Pull Request #72554 · Expensify/App

mateuuszzzzz · 2025-10-14T10:36:19Z

Explanation of Change

This PR basically do 2 things:

Adjusts PatchedArtifactsSrttings.gradle to make it work on CI where we cannot rely on checking scopes with hasRequiredScopes. This function works correctly only with user generated tokens.
Adds 2 envs GITHUB_TOKEN and GITHUB_ACTOR to step that builds Android app in testBuild.yml so we could use react-native artifacts. GITHUB_TOKEN(.github.token or secrets.GITHUB_TOKEN) by default has required scopes to read public Github packages.

Fixed Issues

$ #72514
PROPOSAL:

Tests

Run adhoc workflow testBuild.yml and verify that gradle prints "[PatchedArtifacts] Using patched react-native artifacts: <version>"

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

github-actions · 2025-10-14T11:15:37Z

🚧 @mountiny has triggered a test Expensify/App build. You can view the workflow run here.

mateuuszzzzz · 2025-10-15T13:50:49Z

Check spell failed, but we cannot change this. It's not our API, but something that gradle/groovy provides.

melvin-bot · 2025-10-15T13:51:12Z

@eVoloshchak Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

mateuuszzzzz · 2025-10-15T13:56:30Z

@roryabraham I tested it on my fork, but I’d run one more ad-hoc on this repo before merging, just to make sure there aren’t any differences between my fork’s settings and the organization’s.

mountiny · 2025-10-15T21:28:08Z

Running it again

github-actions · 2025-10-15T21:28:40Z

🚧 @mountiny has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2025-10-15T21:53:57Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪
Built from App PR #72554.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/72554/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/72554/index.html

Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/72554/NewExpensify.dmg	https://72554.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

eVoloshchak · 2025-10-16T09:33:57Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

eVoloshchak

Adhoc builds are successful, cannot test this locally, so simply posting the filled-out reviewer checklist

roryabraham

@mateuuszzzzz you can fix spellcheck by adding getenv to cspell.json:

diff --git a/cspell.json b/cspell.json
index b06ff81162a..fbdf2cc4951 100644
--- a/cspell.json
+++ b/cspell.json
@@ -253,6 +253,7 @@
         "GDSO",
         "genkey",
         "GEOLOCATION",
+        "getenv",
         "getprop",
         "gibsdk",
         "glcode",

mateuuszzzzz · 2025-10-17T10:03:49Z

Rock adhoc builds were merged so I created a separate PR #72858 just for testing purposes. Let's see if it can fallback correctly to build with react-native artifacts enabled.

roryabraham · 2025-10-21T02:00:58Z

@mateuuszzzzz sorry, I'm not clear on what our next steps are here

mateuuszzzzz · 2025-10-21T09:36:49Z

@mateuuszzzzz sorry, I'm not clear on what our next steps are here

Sorry! I wanted to run adhoc here: #72858 to test if this still works when aligned with rock. Nevetheless, rock PR seems to be reverted so we can just resolve conflicts here and merge it.

roryabraham · 2025-10-22T00:23:53Z

Let's do one more test before we merge this...

github-actions · 2025-10-22T00:27:42Z

🚧 @roryabraham has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2025-10-22T00:54:24Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪
Built from App PR #72554.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/72554/index.html	❌ FAILED ❌
	The QR code can't be generated, because the iOS build failed

Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/72554/NewExpensify.dmg	https://72554.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

melvin-bot · 2025-10-22T06:31:33Z

@roryabraham looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

OSBotify · 2025-10-22T06:43:27Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2025-10-23T13:09:47Z

🚀 Deployed to staging by https://github.com/roryabraham in version: 9.2.37-1 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2025-10-24T17:51:58Z

🚀 Deployed to production by https://github.com/blimpich in version: 9.2.37-8 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Use Android react-native prebuilds in adhoc workflow

7434643

melvin-bot Bot assigned mateuuszzzzz Oct 14, 2025

mateuuszzzzz changed the title ~~Use Android react-native prebuilds in adhoc workflow~~ [No QA] Use Android react-native prebuilds in adhoc workflow Oct 14, 2025

mountiny mentioned this pull request Oct 14, 2025

Testing new adhoc builds #72558

Closed

54 tasks

This comment has been minimized.

Sign in to view

mateuuszzzzz added 5 commits October 14, 2025 15:12

Update patched artifacts implementation to make it work on CI

b50d3ab

Add GITHUB_ACTOR env

05f43bc

Refactor validation logic and use GITHUB_TOKEN instead of GH_TOKEN

4f85735

Fix validation logic

aaa7621

Remove redundant permissions

4dabf76

mateuuszzzzz marked this pull request as ready for review October 15, 2025 13:51

mateuuszzzzz requested a review from a team as a code owner October 15, 2025 13:51

melvin-bot Bot requested review from eVoloshchak and removed request for a team October 15, 2025 13:51

eVoloshchak approved these changes Oct 16, 2025

View reviewed changes

melvin-bot Bot requested a review from roryabraham October 16, 2025 09:38

roryabraham requested changes Oct 16, 2025

View reviewed changes

mateuuszzzzz added 2 commits October 17, 2025 11:29

Add getenv to cspell.json

8c22f02

Merge branch 'main' into enable-artifacts-for-adhocs

44c24da

mateuuszzzzz added 2 commits October 21, 2025 11:41

Merge branch 'main' into enable-artifacts-for-adhocs

ce6faa6

Merge branch 'main' into enable-artifacts-for-adhocs

a3bbf41

mateuuszzzzz requested a review from roryabraham October 21, 2025 09:51

roryabraham approved these changes Oct 22, 2025

View reviewed changes

Expensify deleted a comment from github-actions Bot Oct 22, 2025

roryabraham merged commit eed8391 into Expensify:main Oct 22, 2025
30 of 39 checks passed

melvin-bot Bot added the Emergency label Oct 22, 2025

OSBotify mentioned this pull request Oct 23, 2025

Deploy Checklist: New Expensify 2025-10-23 #73307

Closed

88 tasks

melvin-bot Bot mentioned this pull request Oct 24, 2025

[Due for payment 2025-10-31] Consume precompiled React Native Android binaries in AdHoc builds #72514

Closed

roryabraham removed the Emergency label Nov 10, 2025

Conversation

mateuuszzzzz commented Oct 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

github-actions Bot commented Oct 14, 2025

Uh oh!

This comment has been minimized.

mateuuszzzzz commented Oct 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

melvin-bot Bot commented Oct 15, 2025

Uh oh!

mateuuszzzzz commented Oct 15, 2025

Uh oh!

mountiny commented Oct 15, 2025

Uh oh!

github-actions Bot commented Oct 15, 2025

Uh oh!

github-actions Bot commented Oct 15, 2025

Uh oh!

eVoloshchak commented Oct 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Uh oh!

eVoloshchak left a comment

Choose a reason for hiding this comment

Uh oh!

roryabraham left a comment

Choose a reason for hiding this comment

Uh oh!

mateuuszzzzz commented Oct 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

roryabraham commented Oct 21, 2025

Uh oh!

mateuuszzzzz commented Oct 21, 2025

Uh oh!

roryabraham commented Oct 22, 2025

Uh oh!

github-actions Bot commented Oct 22, 2025

Uh oh!

github-actions Bot commented Oct 22, 2025

Uh oh!

Uh oh!

melvin-bot Bot commented Oct 22, 2025

Uh oh!

OSBotify commented Oct 22, 2025

Uh oh!

OSBotify commented Oct 23, 2025

Uh oh!

OSBotify commented Oct 24, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

mateuuszzzzz commented Oct 14, 2025 •

edited

Loading

mateuuszzzzz commented Oct 15, 2025 •

edited

Loading

eVoloshchak commented Oct 16, 2025 •

edited

Loading

mateuuszzzzz commented Oct 17, 2025 •

edited

Loading