Fix for updating avatar logic by jmusial · Pull Request #72556 · Expensify/App

jmusial · 2025-10-14T10:48:48Z

Explanation of Change

There was a difference default avatar generation logic between FE and BE. This PR aligns that logic. It now prefers email as a source for default avatar bucket generation.

Before

after.mov

After

before.mov

Fixed Issues

$ #71288
PROPOSAL:

Tests

Pre requisite:

easier to reproduce with customAvatars beta enabled
default avatar set

Open app
Go to Account -> Profile
Click the avatar icon
Set a custom image for avatar
Click avatar again
Remove avatar
The default avatar sets and does not change when you click avatar again

Offline tests

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

0054.andorid.native.mov

Android: mWeb Chrome

0054.andorid.chrome.mov

iOS: Native

0054.ios.native.mov

iOS: mWeb Safari

0054.ios.safari.mov

MacOS: Chrome / Safari

0054.desktop.chrome.mov

MacOS: Desktop

0054.desktop.native.mov

github-actions · 2025-10-14T10:48:57Z

⚠️ This PR is possibly changing native code and/or updating libraries, it may cause problems with HybridApp. Please check if any patch updates are required in the HybridApp repo and run an AdHoc build to verify that HybridApp will not break. Ask Contributor Plus for help if you are not sure how to handle this. ⚠️

grgia · 2025-10-14T13:53:37Z

+    } else if (accountEmail) {
+        const intVal = parseInt(md5(accountEmail, {asString: true}).substring(0, 4), 10);
+        accountIDHashBucket = ((intVal % CONST.DEFAULT_AVATAR_COUNT) + 1) as AvatarRange;


When I first built the default avatars into NewDot, we used email to hash these. But then we changed it to accountID because of Hidden users. It makes sense now to use email again if you know the email, but wondering if this precedence will have any side effects.

My question is, which are should we should use as the default if we have both

We also have users with phone login I think...
Not sure how we generate avatars for them on BE

The idea in my implementation is to use email if we have it fallback to id if we do not

grgia · 2025-10-14T13:54:28Z

+    "node_modules/@types/md5": {
+      "version": "2.3.5",
+      "resolved": "https://registry.npmjs.org/@types/md5/-/md5-2.3.5.tgz",
+      "integrity": "sha512-/i42wjYNgE6wf0j2bcTX6kuowmdL/6PE4IVitMpm2eYKBUuYCprdcWVK+xEF0gcV6ufMCRhtxmReGfc6hIK7Jw==",
+      "dev": true,
+      "license": "MIT"


We have md5 in expensify-common now @jmusial

I'm assuming this is different, but I haven't imported one from common before. Is this a different one?

I just didn't know that we have it, will change to the one from expensify-common

updated to use expensify-common one

grgia

Design is going to be so happy with this one too

…n-delete

dominictb · 2025-10-17T09:31:51Z

I'll review this

jmusial · 2025-10-17T09:32:50Z

@dominictb give me like 10 more minutes - changing the md5 lib

codecov · 2025-10-17T11:14:04Z

Codecov Report

✅ All modified and coverable lines are covered by tests.

Files with missing lines	Coverage Δ
src/libs/ReportUtils.ts	`74.25% <ø> (ø)`
src/libs/UserUtils.ts	`81.35% <100.00%> (+17.00%)`	⬆️
src/libs/actions/PersonalDetails.ts	`52.22% <100.00%> (ø)`
...ages/ScheduleCall/ScheduleCallConfirmationPage.tsx	`0.00% <ø> (ø)`
src/pages/settings/Profile/Avatar/AvatarPage.tsx	`0.00% <ø> (ø)`
src/pages/settings/Profile/ProfilePage.tsx	`85.18% <ø> (ø)`

... and 8 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

melvin-bot · 2025-10-17T14:48:33Z

@dominictb Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

github-actions · 2025-10-20T11:37:30Z

🚧 @grgia has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2025-10-20T12:09:46Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪
Built from App PR #72556.

Android 🤖	iOS 🍎
https://github.com/Expensify/App/actions/runs/18650754167/artifacts/4316656288	https://github.com/Expensify/App/actions/runs/18650754167/artifacts/4316551803

Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/72556/NewExpensify.dmg	https://72556.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

dominictb · 2025-10-22T11:09:32Z

@jmusial Can you merge main to make sure there's no new usage of the changed functions?

dominictb · 2025-10-22T11:25:36Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Screen.Recording.2025-10-22.at.18.34.50.mov

Android: mWeb Chrome

Screen.Recording.2025-10-22.at.18.36.52.mov

iOS: HybridApp

Screen.Recording.2025-10-22.at.18.31.03.mov

iOS: mWeb Safari

Screen.Recording.2025-10-22.at.18.32.40.mov

MacOS: Chrome / Safari

Screen.Recording.2025-10-22.at.18.23.23.mov

MacOS: Desktop

…n-delete

OSBotify · 2025-10-23T13:09:50Z

🚀 Deployed to staging by https://github.com/grgia in version: 9.2.37-1 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2025-10-24T17:52:01Z

🚀 Deployed to production by https://github.com/blimpich in version: 9.2.37-8 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

POC of updating avatar logic

fcd8964

melvin-bot Bot assigned jmusial Oct 14, 2025

grgia self-requested a review October 14, 2025 11:50

grgia reviewed Oct 14, 2025

View reviewed changes

jmusial added 2 commits October 17, 2025 11:19

use md5 from expesnify-common

c006d5e

Merge branch 'main' into fix/update-default-avatar-generation-logic-o…

0b7adab

…n-delete

dominictb mentioned this pull request Oct 17, 2025

[$250] Profile - Two default avatar appears when remove custom profile image #71288

Closed

8 tasks

jmusial added 3 commits October 17, 2025 12:37

change hex value for parseInt

10f0f90

fix test

9fb445e

fix pretteir

c34354e

jmusial marked this pull request as ready for review October 17, 2025 14:48

jmusial requested a review from a team as a code owner October 17, 2025 14:48

melvin-bot Bot requested review from dominictb and removed request for a team October 17, 2025 14:48

jmusial changed the title ~~POC of updating avatar logic~~ Fix for updating avatar logic Oct 20, 2025

jmusial added 2 commits October 23, 2025 10:29

Merge branch 'main' into fix/update-default-avatar-generation-logic-o…

feda029

…n-delete

fix lint

29194d8

grgia approved these changes Oct 23, 2025

View reviewed changes

dominictb approved these changes Oct 23, 2025

View reviewed changes

melvin-bot Bot requested a review from grgia October 23, 2025 11:58

grgia merged commit 4f373a9 into Expensify:main Oct 23, 2025
32 of 33 checks passed

github-actions Bot mentioned this pull request Oct 23, 2025

Investigate workflow job failing on main: test / test (job 1) #73306

Closed

OSBotify mentioned this pull request Oct 23, 2025

Deploy Checklist: New Expensify 2025-10-23 #73307

Closed

88 tasks

Conversation

jmusial commented Oct 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Before

After

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

github-actions Bot commented Oct 14, 2025

Uh oh!

grgia Oct 14, 2025

Choose a reason for hiding this comment

Uh oh!

grgia Oct 14, 2025

Choose a reason for hiding this comment

Uh oh!

jmusial Oct 16, 2025

Choose a reason for hiding this comment

Uh oh!

grgia Oct 14, 2025

Choose a reason for hiding this comment

Uh oh!

grgia Oct 14, 2025

Choose a reason for hiding this comment

Uh oh!

jmusial Oct 16, 2025

Choose a reason for hiding this comment

Uh oh!

jmusial Oct 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

grgia left a comment

Choose a reason for hiding this comment

Uh oh!

dominictb commented Oct 17, 2025

Uh oh!

jmusial commented Oct 17, 2025

Uh oh!

codecov Bot commented Oct 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

melvin-bot Bot commented Oct 17, 2025

Uh oh!

github-actions Bot commented Oct 20, 2025

Uh oh!

github-actions Bot commented Oct 20, 2025

Uh oh!

dominictb commented Oct 22, 2025

Uh oh!

dominictb commented Oct 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

Uh oh!

OSBotify commented Oct 23, 2025

Uh oh!

OSBotify commented Oct 24, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

jmusial commented Oct 14, 2025 •

edited

Loading

jmusial Oct 17, 2025 •

edited

Loading

codecov Bot commented Oct 17, 2025 •

edited

Loading

dominictb commented Oct 22, 2025 •

edited

Loading