fix: Tax no longer valid error shown on distance expense by nkdengineer · Pull Request #72602 · Expensify/App

nkdengineer · 2025-10-14T16:48:30Z

Explanation of Change

Fixed Issues

$ #71044
PROPOSAL: #71044 (comment)

Tests

Create a workspace
Enable Taxes in More features
Create a manual expense in the workspace chat
In the WS chat click "+" button - Create expense - Distance
Create a distance expense
Observe the report preview - it has a "Review" button with a red dot
Verify that: No error is shown on distance expense, when taxes are enabled in the workspace

Verify that no errors appear in the JS console

Offline tests

Same as tests

QA Steps

Same as tests

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

am.mov

Android: mWeb Chrome

am.mov

iOS: Native

ios.mov

iOS: mWeb Safari

im.mov

MacOS: Chrome / Safari

web.mov

MacOS: Desktop

desktop-resize.mp4

codecov · 2025-10-14T16:59:46Z

Codecov Report

❌ Patch coverage is 50.00000% with 3 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
src/libs/TransactionUtils/index.ts	0.00%	3 Missing ⚠️

Files with missing lines	Coverage Δ
src/libs/Violations/ViolationsUtils.ts	`66.34% <100.00%> (-0.43%)`	⬇️
src/libs/TransactionUtils/index.ts	`68.35% <0.00%> (-0.25%)`	⬇️

... and 6 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

melvin-bot · 2025-10-15T07:52:26Z

@abdulrahuman5196 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

nkdengineer · 2025-10-20T07:58:31Z

friendly bump here @abdulrahuman5196

abdulrahuman5196 · 2025-10-20T08:23:31Z

Hi will check today

abdulrahuman5196 · 2025-10-20T16:44:03Z

-        const isPolicyTrackTaxEnabled = !!policy?.tax?.trackingEnabled;
+        const isDistanceRequest = TransactionUtils.isDistanceRequest(updatedTransaction);
+        const isPerDiemRequest = TransactionUtils.isPerDiemRequest(updatedTransaction);
+        const isPolicyTrackTaxEnabled = isTaxTrackingEnabled(true, policy, isDistanceRequest, isPerDiemRequest); // we can use isPolicyExpenseChat here


@nkdengineer What is the comment here? I don't understand it?

@abdulrahuman5196 i removed. Looks like I forgot to delete it after testing

abdulrahuman5196 · 2025-10-21T18:41:43Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Screen.Recording.2025-10-22.at.12.00.33.AM.mov

Android: mWeb Chrome

Screen.Recording.2025-10-22.at.12.07.01.AM.mov

iOS: HybridApp

Screen.Recording.2025-10-21.at.11.27.20.PM.mov

iOS: mWeb Safari

Screen.Recording.2025-10-21.at.11.28.36.PM.mov

MacOS: Chrome / Safari

Screen.Recording.2025-10-21.at.11.24.52.PM.mov

MacOS: Desktop

Screen.Recording.2025-10-21.at.11.25.48.PM.mov

abdulrahuman5196

Changes looks good and works well. Reviewers checklist is also complete.

All yours. @chuckdries

🎀 👀 🎀
C+ Reviewed

abdulrahuman5196 · 2025-10-21T18:44:04Z

Eslint failure doesn't seem to be related to these code changes.

cc: @nkdengineer

chuckdries

Works like a charm. Thanks!

chuckdries · 2025-10-21T20:10:16Z

@nkdengineer The ESlint should fix itself when you merge main!

nkdengineer · 2025-10-22T07:22:51Z

@chuckdries all good now

OSBotify · 2025-10-22T14:23:41Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2025-10-23T13:09:56Z

🚀 Deployed to staging by https://github.com/chuckdries in version: 9.2.37-1 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2025-10-24T17:52:07Z

🚀 Deployed to production by https://github.com/blimpich in version: 9.2.37-8 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

fix: Tax no longer valid error shown on distance expense

4684c03

melvin-bot Bot assigned nkdengineer Oct 14, 2025

nkdengineer marked this pull request as ready for review October 15, 2025 07:52

nkdengineer requested a review from a team as a code owner October 15, 2025 07:52

melvin-bot Bot requested review from abdulrahuman5196 and removed request for a team October 15, 2025 07:52

Merge branch 'main' into fix/71044-1

79125b4

abdulrahuman5196 reviewed Oct 20, 2025

View reviewed changes

nkdengineer added 2 commits October 21, 2025 11:43

Merge branch 'main' into fix/71044-1

7f9b7e7

remove useless comment

e27727e

abdulrahuman5196 approved these changes Oct 21, 2025

View reviewed changes

melvin-bot Bot requested a review from chuckdries October 21, 2025 18:43

chuckdries approved these changes Oct 21, 2025

View reviewed changes

Merge branch 'main' into fix/71044-1

358f1cc

chuckdries merged commit 2ebb00e into Expensify:main Oct 22, 2025
23 checks passed

OSBotify mentioned this pull request Oct 23, 2025

Deploy Checklist: New Expensify 2025-10-23 #73307

Closed

88 tasks

melvin-bot Bot mentioned this pull request Oct 24, 2025

[Due for payment 2025-10-31] [$250] Distance/Tax - "Tax no longer valid" error shown on distance expense, then disappears #71044

Closed

8 tasks

Conversation

nkdengineer commented Oct 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

codecov Bot commented Oct 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

melvin-bot Bot commented Oct 15, 2025

Uh oh!

nkdengineer commented Oct 20, 2025

Uh oh!

abdulrahuman5196 commented Oct 20, 2025

Uh oh!

abdulrahuman5196 Oct 20, 2025

Choose a reason for hiding this comment

Uh oh!

nkdengineer Oct 21, 2025

Choose a reason for hiding this comment

Uh oh!

abdulrahuman5196 commented Oct 21, 2025

Reviewer Checklist

Screenshots/Videos

Uh oh!

abdulrahuman5196 left a comment

Choose a reason for hiding this comment

Uh oh!

abdulrahuman5196 commented Oct 21, 2025

Uh oh!

chuckdries left a comment

Choose a reason for hiding this comment

Uh oh!

chuckdries commented Oct 21, 2025

Uh oh!

nkdengineer commented Oct 22, 2025

Uh oh!

Uh oh!

OSBotify commented Oct 22, 2025

Uh oh!

OSBotify commented Oct 23, 2025

Uh oh!

OSBotify commented Oct 24, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

nkdengineer commented Oct 14, 2025 •

edited

Loading

codecov Bot commented Oct 14, 2025 •

edited

Loading