Skip to content

[CP Staging] Revert "“Track Intent” Users Skipping Workspace Join Are Not Prompted to Create a Workspace"#72688

Merged
arosiclair merged 1 commit into
mainfrom
revert-72177-mkzie2-issue/71381
Oct 15, 2025
Merged

[CP Staging] Revert "“Track Intent” Users Skipping Workspace Join Are Not Prompted to Create a Workspace"#72688
arosiclair merged 1 commit into
mainfrom
revert-72177-mkzie2-issue/71381

Conversation

@mountiny

@mountiny mountiny commented Oct 15, 2025

Copy link
Copy Markdown
Contributor

Reverts #72177

@github-actions

github-actions Bot commented Oct 15, 2025

Copy link
Copy Markdown
Contributor

🚧 @mountiny has triggered a test Expensify/App build. You can view the workflow run here.

@codecov

codecov Bot commented Oct 15, 2025 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

Files with missing lines Coverage Δ
.../pages/OnboardingPurpose/BaseOnboardingPurpose.tsx 31.25% <ø> (ø)

... and 16 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions

github-actions Bot commented Oct 15, 2025

Copy link
Copy Markdown
Contributor

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪
Built from App PR #72688.

Android 🤖 iOS 🍎
⏩ SKIPPED ⏩ https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/72688/index.html
The build for Android was skipped iOS
Desktop 💻 Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/72688/NewExpensify.dmg https://72688.pr-testing.expensify.com
Desktop Web

👀 View the workflow run that generated this build 👀

@mountiny

mountiny commented Oct 15, 2025

Copy link
Copy Markdown
Contributor Author

Asked QA for a test

@mountiny mountiny changed the title Revert "“Track Intent” Users Skipping Workspace Join Are Not Prompted to Create a Workspace" [CP Staging] Revert "“Track Intent” Users Skipping Workspace Join Are Not Prompted to Create a Workspace" Oct 15, 2025
@arosiclair arosiclair marked this pull request as ready for review October 15, 2025 15:10
@arosiclair arosiclair requested a review from a team as a code owner October 15, 2025 15:10
@melvin-bot melvin-bot Bot requested review from chuckdries and removed request for a team October 15, 2025 15:11
@melvin-bot

melvin-bot Bot commented Oct 15, 2025

Copy link
Copy Markdown

@chuckdries Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@github-actions

github-actions Bot commented Oct 15, 2025

Copy link
Copy Markdown
Contributor

LGTM :feelsgood:. Thank you for your hard work!

@arosiclair arosiclair merged commit 4d9c237 into main Oct 15, 2025
23 of 27 checks passed
@arosiclair arosiclair deleted the revert-72177-mkzie2-issue/71381 branch October 15, 2025 15:11
@melvin-bot

melvin-bot Bot commented Oct 15, 2025

Copy link
Copy Markdown

@arosiclair looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@melvin-bot melvin-bot Bot added the Emergency label Oct 15, 2025
@arosiclair

arosiclair commented Oct 15, 2025

Copy link
Copy Markdown
Contributor

straight revert

@OSBotify OSBotify added the CP Staging marks PRs that have been CP'd to staging label Oct 15, 2025
OSBotify pushed a commit that referenced this pull request Oct 15, 2025
@arosiclair @OSBotify
Merge pull request #72688 from Expensify/revert-72177-mkzie2-issue/71381
d84f29b 
[CP Staging] Revert "“Track Intent” Users Skipping Workspace Join Are Not Prompted to Create a Workspace"

(cherry picked from commit 4d9c237)

(cherry-picked to staging by mountiny)
@OSBotify OSBotify mentioned this pull request Oct 15, 2025
Closed
42 tasks
@OSBotify

OSBotify commented Oct 15, 2025

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify

OSBotify commented Oct 15, 2025

Copy link
Copy Markdown
Contributor

🚀 Cherry-picked to staging by https://github.com/mountiny in version: 9.2.31-1 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify

OSBotify commented Oct 15, 2025

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/mountiny in version: 9.2.31-2 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify

OSBotify commented Oct 15, 2025

Copy link
Copy Markdown
Contributor

🚀 Cherry-picked to staging by https://github.com/mountiny in version: 9.2.32-0 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify

OSBotify commented Oct 16, 2025

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/mountiny in version: 9.2.32-6 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@arosiclair arosiclair arosiclair approved these changes

@chuckdries chuckdries Awaiting requested review from chuckdries

Assignees

@mountiny mountiny

Labels

CP Staging marks PRs that have been CP'd to staging

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mountiny @arosiclair @OSBotify