Skip to content

[CP Staging] Revert "Add primary receipt scan option on mobile and web"#72690

Merged
mountiny merged 1 commit into
mainfrom
revert-72236-JKobrynski/72030-add-primary-receipt-scan-option
Oct 15, 2025
Merged

[CP Staging] Revert "Add primary receipt scan option on mobile and web"#72690
mountiny merged 1 commit into
mainfrom
revert-72236-JKobrynski/72030-add-primary-receipt-scan-option

Conversation

@mountiny

@mountiny mountiny commented Oct 15, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Reverts #72236

Fixes #72646
Fixes #72616
Fixes #72638
Fixes #72621
Fixes #72624
Fixes #72617

@mountiny mountiny self-assigned this Oct 15, 2025
@mountiny mountiny requested review from a team as code owners October 15, 2025 13:13
@melvin-bot melvin-bot Bot requested review from luacmartins and removed request for a team October 15, 2025 13:14
@melvin-bot

melvin-bot Bot commented Oct 15, 2025

Copy link
Copy Markdown

@luacmartins Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@github-actions

github-actions Bot commented Oct 15, 2025

Copy link
Copy Markdown
Contributor

LGTM :feelsgood:. Thank you for your hard work!

@codecov

codecov Bot commented Oct 15, 2025 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 80.00000% with 2 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...c/components/Navigation/NavigationTabBar/index.tsx 0.00% 1 Missing ⚠️
src/components/Search/SearchPageFooter.tsx 0.00% 1 Missing ⚠️
Files with missing lines Coverage Δ
src/components/FloatingActionButton.tsx 100.00% <100.00%> (+3.57%) ⬆️
...ents/Navigation/TopLevelNavigationTabBar/index.tsx 92.85% <ø> (-0.90%) ⬇️
.../Search/SearchPageHeader/SearchTypeMenuPopover.tsx 0.00% <ø> (ø)
...es/home/sidebar/FloatingActionButtonAndPopover.tsx 51.27% <ø> (-0.20%) ⬇️
src/styles/index.ts 45.35% <ø> (+0.24%) ⬆️
...c/components/Navigation/NavigationTabBar/index.tsx 59.74% <0.00%> (ø)
src/components/Search/SearchPageFooter.tsx 0.00% <0.00%> (ø)

... and 11 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions

github-actions Bot commented Oct 15, 2025

Copy link
Copy Markdown
Contributor

🚧 @mountiny has triggered a test Expensify/App build. You can view the workflow run here.

@github-actions

github-actions Bot commented Oct 15, 2025

Copy link
Copy Markdown
Contributor

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪
Built from App PR #72690.

Android 🤖 iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/72690/index.html https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/72690/index.html
Android iOS
Desktop 💻 Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/72690/NewExpensify.dmg https://72690.pr-testing.expensify.com
Desktop Web

👀 View the workflow run that generated this build 👀

@mountiny mountiny merged commit 51b52e4 into main Oct 15, 2025
24 of 29 checks passed
@mountiny mountiny deleted the revert-72236-JKobrynski/72030-add-primary-receipt-scan-option branch October 15, 2025 16:27
@melvin-bot melvin-bot Bot added the Emergency label Oct 15, 2025
@melvin-bot

melvin-bot Bot commented Oct 15, 2025

Copy link
Copy Markdown

@mountiny looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@mountiny

mountiny commented Oct 15, 2025

Copy link
Copy Markdown
Contributor Author

Straight revert

OSBotify pushed a commit that referenced this pull request Oct 15, 2025
@mountiny @OSBotify
Merge pull request #72690 from Expensify/revert-72236-JKobrynski/7203…
2530e1b 
…0-add-primary-receipt-scan-option

[CP Staging] Revert "Add primary receipt scan option on mobile and web"

(cherry picked from commit 51b52e4)

(cherry-picked to staging by mountiny)
@OSBotify OSBotify added the CP Staging marks PRs that have been CP'd to staging label Oct 15, 2025
@OSBotify

OSBotify commented Oct 15, 2025

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify OSBotify mentioned this pull request Oct 15, 2025
Closed
42 tasks
JKobrynski added a commit to callstack-internal/Expensify-App that referenced this pull request Oct 15, 2025
@JKobrynski
Revert "Merge pull request Expensify#72690 from Expensify/revert-7223…
60780d9 
…6-JKobrynski/72030-add-primary-receipt-scan-option"

This reverts commit 51b52e4, reversing
changes made to bb87eaa.
@mountiny mountiny mentioned this pull request Oct 15, 2025
Closed
16 tasks
@JKobrynski JKobrynski mentioned this pull request Oct 15, 2025
Merged
54 tasks
@OSBotify

OSBotify commented Oct 15, 2025

Copy link
Copy Markdown
Contributor

🚀 Cherry-picked to staging by https://github.com/mountiny in version: 9.2.31-2 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify

OSBotify commented Oct 15, 2025

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/mountiny in version: 9.2.31-2 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment