-
Notifications
You must be signed in to change notification settings - Fork 3.9k
[SAML Configuration] Display domains to members and admins in Workspaces tab #72713
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
mountiny
merged 27 commits into
Expensify:main
from
software-mansion-labs:feat/saml-display-domain-list
Oct 23, 2025
Merged
Changes from all commits
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
d02a5d5
Display domains to members and admins in Workspaces tab
mhawryluk 52b6cd9
Tiny fix
mhawryluk 353fec8
Merge branch 'main' into feat/saml-display-domain-list
mhawryluk b25da55
Update section title spacing
mhawryluk 6cccf3a
Implement workspaces empty state when domains exist
mhawryluk 3292c7a
Remove empty line
mhawryluk de3ffb9
Rename admin access onyx key
mhawryluk e4b4774
Add translations
mhawryluk 47d8315
Review fixes
mhawryluk a7deea7
Merge branch 'main' into feat/saml-display-domain-list
mhawryluk 4fc10ff
Fix after merge
mhawryluk 4dfca54
Review fixes
mhawryluk bd9cacd
Design review fixes
mhawryluk 068c99f
Merge branch 'main' into feat/saml-display-domain-list
mhawryluk aea25da
Replace SelectionList with FlashList
mhawryluk ea7eab1
Fix domains section header translation
mhawryluk 7d92e20
Set props for hopefully better performance
mhawryluk 9c58d4a
Hide domains section when searching for a workspace
mhawryluk 79cea13
Increase bottom padding
mhawryluk d9c5b98
Small adjustment
mhawryluk e47064f
Small refactor
mhawryluk 3eb94e9
More tiny refactor
mhawryluk 99550af
Change exit to domain icon color on hover
mhawryluk 975e401
Replace FlashList with FlatList for now
mhawryluk 9473379
Revert flatListRef variable name
mhawryluk a4535b2
Revert changes to the old SelectionList
mhawryluk b6835d7
Implement more review suggestions
mhawryluk File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,54 @@ | ||
| import React from 'react'; | ||
| import {View} from 'react-native'; | ||
| import Icon from '@components/Icon'; | ||
| import * as Expensicons from '@components/Icon/Expensicons'; | ||
| import TextWithTooltip from '@components/TextWithTooltip'; | ||
| import useTheme from '@hooks/useTheme'; | ||
| import useThemeStyles from '@hooks/useThemeStyles'; | ||
|
|
||
| type DomainsListRowProps = { | ||
| /** Name of the domain */ | ||
| title: string; | ||
|
|
||
| /** Whether the row is hovered, so we can modify its style */ | ||
| isHovered: boolean; | ||
|
|
||
| /** Whether the icon at the end of the row should be displayed */ | ||
| shouldShowRightIcon: boolean; | ||
| }; | ||
|
|
||
| function DomainsListRow({title, isHovered, shouldShowRightIcon}: DomainsListRowProps) { | ||
| const styles = useThemeStyles(); | ||
| const theme = useTheme(); | ||
|
|
||
| return ( | ||
| <View style={[styles.flexRow, styles.highlightBG, styles.br3, styles.p5, styles.alignItemsCenter, styles.gap3, isHovered && styles.hoveredComponentBG]}> | ||
| <View style={[styles.flex1, styles.flexRow, styles.bgTransparent, styles.gap3, styles.alignItemsCenter]}> | ||
| <Icon | ||
| src={Expensicons.Globe} | ||
| fill={theme.icon} | ||
| additionalStyles={styles.domainIcon} | ||
| /> | ||
| <TextWithTooltip | ||
| text={title} | ||
| shouldShowTooltip | ||
| style={[styles.textStrong]} | ||
| /> | ||
| </View> | ||
|
|
||
| {shouldShowRightIcon && ( | ||
| <View style={styles.touchableButtonImage}> | ||
| <Icon | ||
| src={Expensicons.NewWindow} | ||
| fill={isHovered ? theme.iconHovered : theme.icon} | ||
| isButtonIcon | ||
| /> | ||
| </View> | ||
| )} | ||
| </View> | ||
| ); | ||
| } | ||
|
|
||
| DomainsListRow.displayName = 'DomainsListRow'; | ||
|
|
||
| export default DomainsListRow; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great translation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed