[HOLD] Revert #72714 – "Add primary receipt scan option on mobile and web - v2" by francoisl · Pull Request #72729 · Expensify/App

francoisl · 2025-10-16T01:51:50Z

Explanation of Change

Straight revert of #72714, to fix a deploy blocker where expenses are created with a flipped amount.

Fixed Issues

$ #72727
Maybe #72728 (cc @lakchote)

Tests

Same as QA

Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

Open a 1:1 DM with anyone.
Submit a manual expense to that person
Open the transaction thread.
Click the Amount.
Verify that the same amount you initially entered is displayed, without a negative leading sign

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I verified there are no new alerts related to the canBeMissing param for useOnyx
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If new assets were added or existing ones were modified, I verified that:
- The assets are optimized and compressed (for SVG files, run npm run compress-svg)
- The assets load correctly across all supported platforms.
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

MacOS: Chrome / Safari

Screen.Recording.2025-10-15.at.18.55.27.mov

…rimary-receipt-scan-option-2" This reverts commit b30f0f7, reversing changes made to 50a14d8.

github-actions · 2025-10-16T01:53:30Z

🚧 @francoisl has triggered a test Expensify/App build. You can view the workflow run here.

codecov · 2025-10-16T02:02:58Z

Codecov Report

❌ Patch coverage is 81.81818% with 2 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
...c/components/Navigation/NavigationTabBar/index.tsx	0.00%	1 Missing ⚠️
src/components/Search/SearchPageFooter.tsx	0.00%	1 Missing ⚠️

Files with missing lines	Coverage Δ
src/components/FloatingActionButton.tsx	`100.00% <100.00%> (+3.57%)`	⬆️
...ents/Navigation/TopLevelNavigationTabBar/index.tsx	`92.85% <ø> (-0.90%)`	⬇️
.../Search/SearchPageHeader/SearchTypeMenuPopover.tsx	`0.00% <ø> (ø)`
src/libs/ReportUtils.ts	`74.61% <100.00%> (-0.03%)`	⬇️
...es/home/sidebar/FloatingActionButtonAndPopover.tsx	`51.27% <ø> (+0.86%)`	⬆️
src/pages/iou/request/IOURequestStartPage.tsx	`82.81% <ø> (-0.27%)`	⬇️
src/pages/workspace/WorkspaceInitialPage.tsx	`0.00% <ø> (ø)`
src/styles/index.ts	`45.35% <ø> (+0.24%)`	⬆️
...c/components/Navigation/NavigationTabBar/index.tsx	`59.74% <0.00%> (ø)`
src/components/Search/SearchPageFooter.tsx	`0.00% <0.00%> (ø)`

... and 11 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

github-actions · 2025-10-16T02:05:48Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪
Built from App PR #72729.

Android 🤖	iOS 🍎
⏩ SKIPPED ⏩	⏩ SKIPPED ⏩
The build for Android was skipped	The build for iOS was skipped

Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/72729/NewExpensify.dmg	https://72729.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

francoisl · 2025-10-16T02:33:07Z

I see there's also another blocker #72728 possibly related to the same PR, let's proceed with a revert (cc @lakchote for visibility)

melvin-bot · 2025-10-16T02:33:48Z

@ahmedGaber93 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

francoisl · 2025-10-16T02:34:54Z

It's a straight revert, no need for a C+ review here, thanks!

github-actions · 2025-10-16T02:35:49Z


-    const {shouldUseNarrowLayout} = useResponsiveLayout();
-
    const valueTextStyle = useMemo(() => (isOffline ? [styles.textLabelSupporting, styles.labelStrong] : [styles.labelStrong]), [isOffline, styles]);


❌ PERF-6 (docs)

Passing the entire styles object as a dependency causes this useMemo to re-execute whenever any style property changes, even unrelated ones. This creates unnecessary recalculations and impacts performance predictability.

Specify individual style properties as dependencies:

const valueTextStyle = useMemo(() => (isOffline ? [styles.textLabelSupporting, styles.labelStrong] : [styles.labelStrong]), [isOffline, styles.textLabelSupporting, styles.labelStrong]);

VickyStash · 2025-10-16T06:04:05Z

@francoisl I think we really don't want to revert the PR! Can you give us some time, so we can check the blockers and prepare fixes instead? 🙏
cc @mountiny @JKobrynski

mountiny · 2025-10-16T09:55:26Z

Adding hold, we are working on the fix for this one https://expensify.slack.com/archives/C08CZDJFJ77/p1760603258003289?thread_ts=1759942069.284649&cid=C08CZDJFJ77

lakchote · 2025-10-16T16:13:25Z

We won't revert see https://expensify.slack.com/archives/C01GTK53T8Q/p1760612613181029?thread_ts=1760578819.374289&cid=C01GTK53T8Q

Revert "Merge pull request #72714 from callstack-internal/72030-add-p…

8724e6e

…rimary-receipt-scan-option-2" This reverts commit b30f0f7, reversing changes made to 50a14d8.

francoisl self-assigned this Oct 16, 2025

francoisl added the Ready To Build label Oct 16, 2025

francoisl mentioned this pull request Oct 16, 2025

[Due for payment 2025-10-27] [Due for payment 2025-10-23] Expense - Amount field shows negative amount in IOU expense #72727

Closed

8 tasks

francoisl marked this pull request as ready for review October 16, 2025 02:33

francoisl requested review from a team as code owners October 16, 2025 02:33

melvin-bot Bot requested review from ahmedGaber93 and removed request for a team October 16, 2025 02:33

francoisl requested review from lakchote and removed request for ahmedGaber93 October 16, 2025 02:34

github-actions Bot reviewed Oct 16, 2025

View reviewed changes

mountiny changed the title ~~Revert #72714 – "Add primary receipt scan option on mobile and web - v2"~~ [HOLD] Revert #72714 – "Add primary receipt scan option on mobile and web - v2" Oct 16, 2025

lakchote closed this Oct 16, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[HOLD] Revert #72714 – "Add primary receipt scan option on mobile and web - v2"#72729

[HOLD] Revert #72714 – "Add primary receipt scan option on mobile and web - v2"#72729
francoisl wants to merge 1 commit into
mainfrom
francois-revert-72714

francoisl commented Oct 16, 2025 •

edited

Loading

Uh oh!

github-actions Bot commented Oct 16, 2025

Uh oh!

codecov Bot commented Oct 16, 2025 •

edited

Loading

Uh oh!

github-actions Bot commented Oct 16, 2025

Uh oh!

francoisl commented Oct 16, 2025

Uh oh!

melvin-bot Bot commented Oct 16, 2025

Uh oh!

francoisl commented Oct 16, 2025

Uh oh!

github-actions Bot Oct 16, 2025

Uh oh!

VickyStash commented Oct 16, 2025

Uh oh!

mountiny commented Oct 16, 2025

Uh oh!

lakchote commented Oct 16, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants


		const {shouldUseNarrowLayout} = useResponsiveLayout();

		const valueTextStyle = useMemo(() => (isOffline ? [styles.textLabelSupporting, styles.labelStrong] : [styles.labelStrong]), [isOffline, styles]);

Conversation

francoisl commented Oct 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

github-actions Bot commented Oct 16, 2025

Uh oh!

codecov Bot commented Oct 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

github-actions Bot commented Oct 16, 2025

Uh oh!

francoisl commented Oct 16, 2025

Uh oh!

melvin-bot Bot commented Oct 16, 2025

Uh oh!

francoisl commented Oct 16, 2025

Uh oh!

github-actions Bot Oct 16, 2025

Choose a reason for hiding this comment

❌ PERF-6 (docs)

Uh oh!

VickyStash commented Oct 16, 2025

Uh oh!

mountiny commented Oct 16, 2025

Uh oh!

lakchote commented Oct 16, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

francoisl commented Oct 16, 2025 •

edited

Loading

codecov Bot commented Oct 16, 2025 •

edited

Loading