Skip to content

[CP Staging] Revert "Enable category field on unreported expenses"#72857

Merged
mountiny merged 1 commit into
mainfrom
revert-72457-feat/71784-category-field
Oct 17, 2025
Merged

[CP Staging] Revert "Enable category field on unreported expenses"#72857
mountiny merged 1 commit into
mainfrom
revert-72457-feat/71784-category-field

Conversation

@grgia

@grgia grgia commented Oct 17, 2025 •
edited by mountiny
Loading

Copy link
Copy Markdown
Contributor

Reverts #72457

$ #72836
$ #72864
$ #72822
$ #72820
$ #72821

@grgia grgia self-assigned this Oct 17, 2025
@grgia grgia requested a review from a team as a code owner October 17, 2025 10:00
@melvin-bot melvin-bot Bot requested review from tylerkaraszewski and removed request for a team October 17, 2025 10:01
@melvin-bot

melvin-bot Bot commented Oct 17, 2025

Copy link
Copy Markdown

@tylerkaraszewski Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@github-actions

github-actions Bot commented Oct 17, 2025

Copy link
Copy Markdown
Contributor

🚧 @grgia has triggered a test Expensify/App build. You can view the workflow run here.

@github-actions

github-actions Bot commented Oct 17, 2025

Copy link
Copy Markdown
Contributor

LGTM :feelsgood:. Thank you for your hard work!

@github-actions

github-actions Bot commented Oct 17, 2025

Copy link
Copy Markdown
Contributor

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪
Built from App PR #72857.

Android 🤖 iOS 🍎
⏩ SKIPPED ⏩ ⏩ SKIPPED ⏩
The build for Android was skipped The build for iOS was skipped
Desktop 💻 Web 🕸️
⏩ SKIPPED ⏩ https://72857.pr-testing.expensify.com
The build for Desktop was skipped Web

👀 View the workflow run that generated this build 👀

@codecov

codecov Bot commented Oct 17, 2025 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 31.81818% with 15 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
.../pages/iou/request/step/IOURequestStepCategory.tsx 0.00% 7 Missing ⚠️
src/components/Search/index.tsx 0.00% 4 Missing ⚠️
...c/components/ReportActionItem/MoneyRequestView.tsx 0.00% 3 Missing ⚠️
src/libs/ReportUtils.ts 75.00% 1 Missing ⚠️
Files with missing lines Coverage Δ
src/ROUTES.ts 11.13% <ø> (+0.01%) ⬆️
src/SCREENS.ts 100.00% <ø> (ø)
...gation/AppNavigator/ModalStackNavigators/index.tsx 8.23% <ø> (-0.14%) ⬇️
...on/AppNavigator/Navigators/RightModalNavigator.tsx 3.77% <ø> (+0.06%) ⬆️
src/libs/Navigation/linkingConfig/config.ts 75.00% <ø> (ø)
src/libs/Violations/ViolationsUtils.ts 66.77% <100.00%> (ø)
src/libs/actions/IOU.ts 63.16% <ø> (ø)
src/pages/ReportDetailsPage.tsx 58.33% <100.00%> (+0.12%) ⬆️
src/pages/home/report/PureReportActionItem.tsx 53.55% <100.00%> (+0.07%) ⬆️
...c/pages/iou/request/step/IOURequestStepUpgrade.tsx 0.00% <ø> (ø)
... and 4 more

... and 8 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

arosiclair
arosiclair approved these changes Oct 17, 2025
View reviewed changes

@arosiclair arosiclair left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This also fixes #72864

@grgia grgia changed the title [HOLD Testing] Revert "Enable category field on unreported expenses" [HOLD CP not working][CP Staging] Revert "Enable category field on unreported expenses" Oct 17, 2025
@grgia

grgia commented Oct 17, 2025

Copy link
Copy Markdown
Contributor Author

@arosiclair would you take over CPing this when CPs are working again?

This was referenced Oct 17, 2025
Closed
Closed
@mountiny mountiny changed the title [HOLD CP not working][CP Staging] Revert "Enable category field on unreported expenses" [CP Staging] Revert "Enable category field on unreported expenses" Oct 17, 2025
mountiny
mountiny approved these changes Oct 17, 2025
View reviewed changes

@mountiny mountiny left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes more blockers so moving ahead with merge

@mountiny mountiny merged commit e7120ff into main Oct 17, 2025
26 of 35 checks passed
@mountiny mountiny deleted the revert-72457-feat/71784-category-field branch October 17, 2025 17:39
@melvin-bot

melvin-bot Bot commented Oct 17, 2025

Copy link
Copy Markdown

@mountiny looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@melvin-bot melvin-bot Bot added the Emergency label Oct 17, 2025
@OSBotify

OSBotify commented Oct 17, 2025

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify pushed a commit that referenced this pull request Oct 17, 2025
@mountiny @OSBotify
Merge pull request #72857 from Expensify/revert-72457-feat/71784-cate…
c55975e 
…gory-field

[CP Staging] Revert "Enable category field on unreported expenses"

(cherry picked from commit e7120ff)

(cherry-picked to staging by roryabraham)
@OSBotify OSBotify added the CP Staging marks PRs that have been CP'd to staging label Oct 17, 2025
@OSBotify OSBotify mentioned this pull request Oct 17, 2025
Closed
67 tasks
@AndrewGable AndrewGable mentioned this pull request Oct 17, 2025
Closed
8 tasks
@OSBotify

OSBotify commented Oct 17, 2025

Copy link
Copy Markdown
Contributor

🚀 Cherry-picked to staging by https://github.com/roryabraham in version: 9.2.33-3 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify

OSBotify commented Oct 20, 2025

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/mountiny in version: 9.2.33-4 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify

OSBotify commented Oct 20, 2025

Copy link
Copy Markdown
Contributor

🚀 Cherry-picked to staging by https://github.com/roryabraham in version: 9.2.34-0 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify

OSBotify commented Oct 21, 2025

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/cristipaval in version: 9.2.34-2 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@arosiclair arosiclair arosiclair approved these changes

@mountiny mountiny mountiny approved these changes

@tylerkaraszewski tylerkaraszewski Awaiting requested review from tylerkaraszewski

Assignees

@grgia grgia

Labels

CP Staging marks PRs that have been CP'd to staging

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@grgia @OSBotify @arosiclair @mountiny