[No QA] Update Managing-Expenses-in-a-Report.md by stephanieelliott · Pull Request #72908 · Expensify/App

stephanieelliott · 2025-10-18T05:51:42Z

See: #72644
Debugger: https://chatgpt.com/share/e/68f32a8f-2104-8001-bef3-7b55ca558b3f

Updated docs to add more details on how to edit and move expenses and added guidance beyond editing in the context of reports

melvin-bot · 2025-10-18T05:51:49Z

melvin-bot · 2025-10-18T05:51:51Z

@Christinadobrzyn Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

github-actions · 2025-10-18T05:52:58Z

+Approved and Paid reports are locked for editing. To make changes:

-### Example
+1. (Admins only) Open the report.


Readability violation: "(Admins only)" should be moved to the end of the sentence or integrated more naturally. Consider: "1. Open the report (Workspace Admins only)." for better flow.

github-actions · 2025-10-18T05:53:03Z


-### Example
+1. (Admins only) Open the report.
+2. Click **More > Cancel Payment** if Paid.


Button label violation: Use "Confirm" instead of "Cancel Payment" at the end of this flow, as "Cancel Payment" is not the final action button label. The actual button should be labeled "Confirm" when completing the cancellation.

github-actions · 2025-10-18T05:53:08Z

+4. Choose a destination report or select **Remove from report**.

---
+**To move or remove all expenses from a report**


Readability violation: Missing colon after "To move or remove all expenses from a report" - should be "To move or remove all expenses from a report:" for consistency with other section headings.

github-actions · 2025-10-18T05:53:12Z

-1. Check the boxes next to the expenses.
-2. Select the **green** selection button > **Move expense(s)**.
-3. Choose **Remove from report**.
+**Delete a single expense**


Readability violation: Missing colon after "Delete a single expense" - should be "Delete a single expense:" for consistency with other section headings.

github-actions · 2025-10-18T05:53:16Z

+3. Click the green **selected** button > **Delete**.

-## Edit Expenses in Approved or Paid Reports
+**Delete multiple expenses**


Readability violation: Missing colon after "Delete multiple expenses" - should be "Delete multiple expenses:" for consistency with other section headings.

github-actions · 2025-10-18T05:53:21Z

- Retract the report if you submitted it.
+## What happens if I delete an expense from a report?

+The expense is removed from the report and deleted entirely. 


Readability violation: The phrase "deleted entirely" is redundant. Simply "The expense is removed from the report and deleted." is clearer and more concise.

github-actions · 2025-10-18T05:53:24Z

HelpDot Documentation Review

Overall Assessment

This PR significantly improves the Managing Expenses documentation by removing verbose content, streamlining the structure, and focusing on essential user actions. The changes transform a lengthy, complex guide into a concise, action-oriented resource that better serves user needs.

Scores Summary

Readability: 9/10 - Excellent clarity with simplified language, clear section breaks, and logical flow from permissions to actions to troubleshooting
AI Readiness: 8/10 - Strong descriptive headings and clear context, though some sections could benefit from more specific feature names
Style Compliance: 9/10 - Consistent Expensify terminology, proper button labels, and well-structured FAQ format

Key Findings

Major improvement in content organization: The new structure flows logically from permissions → adding → moving/removing → deleting → editing locked reports
Excellent content reduction: Removed ~40 lines of verbose explanations, redundant troubleshooting, and unnecessary system message details
Enhanced user focus: Prioritizes common user actions over technical background information
Strong FAQ section: Addresses key user pain points with concise, actionable answers
Consistent formatting: Proper use of bold text, numbered lists, and section dividers throughout

Recommendations

Minor enhancement needed: Consider adding more specific UI element names in some instructions (e.g., "expense table" vs just "table")
Keywords optimization: The updated keywords are more focused and relevant - good improvement
Mobile consideration: The guide mentions both web and mobile contexts appropriately

Files Reviewed

Managing-Expenses-in-a-Report.md: Significantly improved - streamlined content, better organization, enhanced user focus

Note: This assessment covers the overall documentation quality transformation from a verbose, complex guide to a concise, user-focused resource.

Create Attach-and-edit-receipts-on-expenses.md

OSBotify · 2025-10-18T05:58:01Z

A preview of your ExpensifyHelp changes have been deployed to https://0399066b.helpdot.pages.dev ⚡️

Updated articles:

Christinadobrzyn

Looks great! Thanks for creating this.

Christinadobrzyn · 2025-10-22T16:57:43Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

OSBotify · 2025-10-23T13:10:23Z

🚀 Deployed to staging by https://github.com/Christinadobrzyn in version: 9.2.37-1 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2025-10-24T17:52:34Z

🚀 Deployed to production by https://github.com/blimpich in version: 9.2.37-8 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Update Managing-Expenses-in-a-Report.md

d5fa32e

stephanieelliott requested a review from a team as a code owner October 18, 2025 05:51

melvin-bot Bot assigned stephanieelliott Oct 18, 2025

melvin-bot Bot requested a review from Christinadobrzyn October 18, 2025 05:51

melvin-bot Bot removed the request for review from a team October 18, 2025 05:51

Create Attach-and-edit-receipts-on-expenses.md

d03f7cd

github-actions Bot reviewed Oct 18, 2025

View reviewed changes

Comment thread docs/articles/new-expensify/reports-and-expenses/Managing-Expenses-in-a-Report.md

github-actions Bot reviewed Oct 18, 2025

View reviewed changes

Merge pull request #72909 from Expensify/stephanieelliott-patch-21-1

8f26ca7

Create Attach-and-edit-receipts-on-expenses.md

github-actions Bot changed the title ~~Update Managing-Expenses-in-a-Report.md~~ [No QA] Update Managing-Expenses-in-a-Report.md Oct 18, 2025

Christinadobrzyn approved these changes Oct 22, 2025

View reviewed changes

Christinadobrzyn merged commit 4313a95 into main Oct 22, 2025
13 of 14 checks passed

Christinadobrzyn deleted the stephanieelliott-patch-21 branch October 22, 2025 17:11

OSBotify mentioned this pull request Oct 23, 2025

Deploy Checklist: New Expensify 2025-10-23 #73307

Closed

88 tasks

Conversation

stephanieelliott commented Oct 18, 2025

Uh oh!

melvin-bot Bot commented Oct 18, 2025 • edited by Christinadobrzyn Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Concierge reviewer checklist:

Uh oh!

melvin-bot Bot commented Oct 18, 2025

Uh oh!

Uh oh!

github-actions Bot Oct 18, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Oct 18, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Oct 18, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Oct 18, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Oct 18, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Oct 18, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Oct 18, 2025

HelpDot Documentation Review

Overall Assessment

Scores Summary

Key Findings

Recommendations

Files Reviewed

Uh oh!

OSBotify commented Oct 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Christinadobrzyn left a comment

Choose a reason for hiding this comment

Uh oh!

Christinadobrzyn commented Oct 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Uh oh!

Uh oh!

OSBotify commented Oct 23, 2025

Uh oh!

OSBotify commented Oct 24, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

melvin-bot Bot commented Oct 18, 2025 •

edited by Christinadobrzyn

Loading

OSBotify commented Oct 18, 2025 •

edited

Loading

Christinadobrzyn commented Oct 22, 2025 •

edited

Loading