Skip to content

[CP Staging] Revert "[No QA] React Compiler Compliance Check V2"#73115

Merged
blimpich merged 1 commit into
mainfrom
revert-72112-@chrispader/react-compiler-check-v2
Oct 21, 2025
Merged

[CP Staging] Revert "[No QA] React Compiler Compliance Check V2"#73115
blimpich merged 1 commit into
mainfrom
revert-72112-@chrispader/react-compiler-check-v2

Conversation

@arosiclair

@arosiclair arosiclair commented Oct 21, 2025 •
edited by blimpich
Loading

Copy link
Copy Markdown
Contributor

Reverts #72112

$ #73097
$ #73075

@arosiclair arosiclair self-assigned this Oct 21, 2025
@github-actions

github-actions Bot commented Oct 21, 2025

Copy link
Copy Markdown
Contributor

🚧 @arosiclair has triggered a test Expensify/App build. You can view the workflow run here.

@github-actions

github-actions Bot commented Oct 21, 2025

Copy link
Copy Markdown
Contributor

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪
Built from App PR #73115.

Android 🤖 iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/73115/index.html https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/73115/index.html
Android iOS
Desktop 💻 Web 🕸️
⏩ SKIPPED ⏩ https://73115.pr-testing.expensify.com
The build for Desktop was skipped Web

👀 View the workflow run that generated this build 👀

@arosiclair arosiclair mentioned this pull request Oct 21, 2025
Closed
8 tasks
@arosiclair arosiclair marked this pull request as ready for review October 21, 2025 16:54
@arosiclair arosiclair requested a review from a team as a code owner October 21, 2025 16:54
@melvin-bot melvin-bot Bot requested review from deetergp and removed request for a team October 21, 2025 16:55
@melvin-bot

melvin-bot Bot commented Oct 21, 2025

Copy link
Copy Markdown

@deetergp Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@github-actions

github-actions Bot commented Oct 21, 2025

Copy link
Copy Markdown
Contributor

LGTM :feelsgood:. Thank you for your hard work!

@blimpich blimpich merged commit 6cb6919 into main Oct 21, 2025
35 of 39 checks passed
@blimpich blimpich deleted the revert-72112-@chrispader/react-compiler-check-v2 branch October 21, 2025 17:04
@melvin-bot melvin-bot Bot added the Emergency label Oct 21, 2025
@melvin-bot

melvin-bot Bot commented Oct 21, 2025

Copy link
Copy Markdown

@blimpich looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@blimpich

blimpich commented Oct 21, 2025

Copy link
Copy Markdown
Contributor

Not an emergency, straight revert to fix a deploy blocker

@OSBotify

OSBotify commented Oct 21, 2025

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@blimpich blimpich changed the title Revert "[No QA] React Compiler Compliance Check V2" [CP Staging] Revert "[No QA] React Compiler Compliance Check V2" Oct 21, 2025
OSBotify pushed a commit that referenced this pull request Oct 21, 2025
@blimpich @OSBotify
Merge pull request #73115 from Expensify/revert-72112-@chrispader/rea…
80f07db 
…ct-compiler-check-v2

(cherry picked from commit 6cb6919)

(cherry-picked to staging by blimpich)
@OSBotify OSBotify added the CP Staging marks PRs that have been CP'd to staging label Oct 21, 2025
@OSBotify OSBotify mentioned this pull request Oct 21, 2025
Closed
47 tasks
@blimpich blimpich mentioned this pull request Oct 21, 2025
Merged
54 tasks
@OSBotify

OSBotify commented Oct 21, 2025

Copy link
Copy Markdown
Contributor

🚀 Cherry-picked to staging by https://github.com/blimpich in version: 9.2.35-3 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@blimpich blimpich mentioned this pull request Oct 21, 2025
Closed
8 tasks
@chrispader

chrispader commented Oct 21, 2025

Copy link
Copy Markdown
Contributor

Created a follow-up PR for after the revert: #73143

@OSBotify

OSBotify commented Oct 21, 2025

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/blimpich in version: 9.2.35-4 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify

OSBotify commented Oct 21, 2025

Copy link
Copy Markdown
Contributor

🚀 Cherry-picked to staging by https://github.com/blimpich in version: 9.2.36-0 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify

OSBotify commented Oct 23, 2025

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/lakchote in version: 9.2.36-7 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@blimpich blimpich blimpich approved these changes

@deetergp deetergp Awaiting requested review from deetergp

Assignees

@arosiclair arosiclair

Labels

CP Staging marks PRs that have been CP'd to staging

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@arosiclair @blimpich @OSBotify @chrispader