Skip to content

[No QA] Add some unit tests for getLastMessageTextForReport #73239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pecanoro merged 4 commits into from
Oct 23, 2025
Merged

[No QA] Add some unit tests for getLastMessageTextForReport #73239

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6e70549
add some unit tests for getLastMessageTextForReport
bernhardoj Oct 22, 2025
942ecf7
Merge branch 'main' into fix/60746-unit-tests
bernhardoj Oct 23, 2025
0c4e6da
lint
bernhardoj Oct 23, 2025
eb38b56
uncomment
bernhardoj Oct 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
204 changes: 203 additions & 1 deletion tests/unit/OptionsListUtilsTest.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,8 @@ import {LocaleContextProvider} from '@components/LocaleContextProvider';
import OnyxListItemProvider from '@components/OnyxListItemProvider';
import useReportIsArchived from '@hooks/useReportIsArchived';
import DateUtils from '@libs/DateUtils';
import {translate} from '@libs/Localize';
import isSearchTopmostFullScreenRoute from '@libs/Navigation/helpers/isSearchTopmostFullScreenRoute';
import type {OptionList, Options, SearchOption} from '@libs/OptionsListUtils';
import {
canCreateOptimisticPersonalDetailOption,
Expand All @@ -19,6 +21,7 @@ import {
filterWorkspaceChats,
formatMemberForList,
getLastActorDisplayName,
getLastMessageTextForReport,
getMemberInviteOptions,
getSearchOptions,
getSearchValueForPhoneOrEmail,
Expand All @@ -30,13 +33,27 @@ import {
recentReportComparator,
sortAlphabetically,
} from '@libs/OptionsListUtils';
import {canCreateTaskInReport, canUserPerformWriteAction, isCanceledTaskReport, isExpensifyOnlyParticipantInReport} from '@libs/ReportUtils';
import Parser from '@libs/Parser';
import {getChangedApproverActionMessage} from '@libs/ReportActionsUtils';
import {
canCreateTaskInReport,
canUserPerformWriteAction,
formatReportLastMessageText,
getMovedActionMessage,
getMovedTransactionMessage,
getReportPreviewMessage,
isCanceledTaskReport,
isExpensifyOnlyParticipantInReport,
} from '@libs/ReportUtils';
import type {OptionData} from '@libs/ReportUtils';
import initOnyxDerivedValues from '@userActions/OnyxDerived';
import CONST from '@src/CONST';
import IntlStore from '@src/languages/IntlStore';
import ONYXKEYS from '@src/ONYXKEYS';
import type {PersonalDetails, Policy, Report, ReportAction, Transaction} from '@src/types/onyx';
import createRandomReportAction from '../utils/collections/reportActions';
import {createRandomReport} from '../utils/collections/reports';
import createRandomTransaction from '../utils/collections/transaction';
import {getFakeAdvancedReportAction} from '../utils/LHNTestUtils';
import {localeCompare} from '../utils/TestHelper';
import waitForBatchedUpdates from '../utils/waitForBatchedUpdates';
Expand Down Expand Up @@ -64,6 +81,8 @@ jest.mock('@src/libs/Navigation/Navigation', () => ({
getReportRHPActiveRoute: jest.fn(),
}));

jest.mock('@libs/Navigation/helpers/isSearchTopmostFullScreenRoute', () => jest.fn());

type PersonalDetailsList = Record<string, PersonalDetails & OptionData>;

const renderLocaleContextProvider = () => {
Expand Down Expand Up @@ -2412,4 +2431,187 @@ describe('OptionsListUtils', () => {
expect(result.alternateText).toBe('Iron Man owes ₫34');
});
});

describe('getLastMessageTextForReport', () => {
describe('REPORT_PREVIEW action', () => {
it('should show report preview message for non-policy expense chat', async () => {
const report: Report = {
...createRandomReport(0),
chatType: undefined,
isOwnPolicyExpenseChat: false,
};
const iouReport: Report = {
...createRandomReport(1),
chatType: undefined,
isOwnPolicyExpenseChat: false,
type: CONST.REPORT.TYPE.IOU,
isWaitingOnBankAccount: false,
};
const reportPreviewAction: ReportAction = {
...createRandomReportAction(1),
actionName: CONST.REPORT.ACTIONS.TYPE.REPORT_PREVIEW,
childMoneyRequestCount: 1,
message: [{type: 'COMMENT', text: ''}],
originalMessage: {
linkedReportID: iouReport.reportID,
},
shouldShow: true,
};
const transaction: Transaction = {
...createRandomTransaction(0),
amount: 100,
currency: CONST.CURRENCY.USD,
merchant: '',
modifiedMerchant: '',
comment: {
comment: '<strong>A</strong><br />A<br />A',
},
};
const iouAction: ReportAction = {
...createRandomReportAction(2),
actionName: CONST.REPORT.ACTIONS.TYPE.IOU,
message: [{type: 'COMMENT', text: ''}],
originalMessage: {
IOUTransactionID: transaction.transactionID,
type: 'create',
},
shouldShow: true,
};
await Onyx.merge(`${ONYXKEYS.COLLECTION.REPORT}${iouReport.reportID}`, iouReport);
await Onyx.merge(`${ONYXKEYS.COLLECTION.REPORT_ACTIONS}${report.reportID}`, {
[reportPreviewAction.reportActionID]: reportPreviewAction,
});
await Onyx.merge(`${ONYXKEYS.COLLECTION.REPORT_ACTIONS}${iouReport.reportID}`, {
[iouAction.reportActionID]: iouAction,
});
await Onyx.merge(`${ONYXKEYS.COLLECTION.TRANSACTION}${transaction.transactionID}`, transaction);
const lastMessage = getLastMessageTextForReport({report, lastActorDetails: null, isReportArchived: false});
const reportPreviewMessage = getReportPreviewMessage(iouReport, iouAction, true, false, null, true, reportPreviewAction);
const expected = formatReportLastMessageText(Parser.htmlToText(reportPreviewMessage));
expect(lastMessage).toBe(expected);
});
});
it('MOVED_TRANSACTION action', async () => {
const mockIsSearchTopmostFullScreenRoute = jest.mocked(isSearchTopmostFullScreenRoute);
mockIsSearchTopmostFullScreenRoute.mockReturnValue(false);
const report: Report = createRandomReport(0);
const report2: Report = {
...createRandomReport(1),
reportName: 'Expense Report #123',
};
const movedTransactionAction: ReportAction = {
...createRandomReportAction(1),
actionName: CONST.REPORT.ACTIONS.TYPE.MOVED_TRANSACTION,
message: [{type: 'COMMENT', text: ''}],
originalMessage: {
toReportID: report2.reportID,
},
};
await Onyx.merge(`${ONYXKEYS.COLLECTION.REPORT}${report2.reportID}`, report2);
await Onyx.merge(`${ONYXKEYS.COLLECTION.REPORT_ACTIONS}${report.reportID}`, {
[movedTransactionAction.reportActionID]: movedTransactionAction,
});
const lastMessage = getLastMessageTextForReport({report, lastActorDetails: null, isReportArchived: false});
expect(lastMessage).toBe(Parser.htmlToText(getMovedTransactionMessage(report2)));
});
describe('SUBMITTED action', () => {
it('should return automatic submitted message if submitted via harvesting', async () => {
const report: Report = createRandomReport(0);
const submittedAction: ReportAction = {
...createRandomReportAction(1),
actionName: CONST.REPORT.ACTIONS.TYPE.SUBMITTED,
message: [{type: 'COMMENT', text: ''}],
originalMessage: {
amount: 1,
harvesting: true,
},
};
await Onyx.merge(`${ONYXKEYS.COLLECTION.REPORT_ACTIONS}${report.reportID}`, {
[submittedAction.reportActionID]: submittedAction,
});
const lastMessage = getLastMessageTextForReport({report, lastActorDetails: null, isReportArchived: false});
expect(lastMessage).toBe(Parser.htmlToText(translate(CONST.LOCALES.EN, 'iou.automaticallySubmitted')));
});
});
describe('APPROVED action', () => {
it('should return automatic approved message if approved automatically', async () => {
const report: Report = createRandomReport(0);
const approvedAction: ReportAction = {
...createRandomReportAction(1),
actionName: CONST.REPORT.ACTIONS.TYPE.APPROVED,
message: [{type: 'COMMENT', text: ''}],
originalMessage: {
type: CONST.IOU.REPORT_ACTION_TYPE.APPROVE,
automaticAction: true,
},
};
await Onyx.merge(`${ONYXKEYS.COLLECTION.REPORT_ACTIONS}${report.reportID}`, {
[approvedAction.reportActionID]: approvedAction,
});
const lastMessage = getLastMessageTextForReport({report, lastActorDetails: null, isReportArchived: false});
expect(lastMessage).toBe(Parser.htmlToText(translate(CONST.LOCALES.EN, 'iou.automaticallyApproved')));
});
});
describe('FORWARDED action', () => {
it('should return automatic forwarded message if forwarded automatically', async () => {
const report: Report = createRandomReport(0);
const forwardedAction: ReportAction = {
...createRandomReportAction(1),
actionName: CONST.REPORT.ACTIONS.TYPE.FORWARDED,
message: [{type: 'COMMENT', text: ''}],
originalMessage: {
type: CONST.IOU.REPORT_ACTION_TYPE.CREATE,
automaticAction: true,
},
};
await Onyx.merge(`${ONYXKEYS.COLLECTION.REPORT_ACTIONS}${report.reportID}`, {
[forwardedAction.reportActionID]: forwardedAction,
});
const lastMessage = getLastMessageTextForReport({report, lastActorDetails: null, isReportArchived: false});
expect(lastMessage).toBe(Parser.htmlToText(translate(CONST.LOCALES.EN, 'iou.automaticallyForwarded')));
});
});
it('TAKE_CONTROL action', async () => {
const report: Report = createRandomReport(0);
const takeControlAction: ReportAction = {
...createRandomReportAction(1),
actionName: CONST.REPORT.ACTIONS.TYPE.TAKE_CONTROL,
message: [{type: 'COMMENT', text: ''}],
originalMessage: {},
};
await Onyx.merge(`${ONYXKEYS.COLLECTION.REPORT_ACTIONS}${report.reportID}`, {
[takeControlAction.reportActionID]: takeControlAction,
});
const lastMessage = getLastMessageTextForReport({report, lastActorDetails: null, isReportArchived: false});
expect(lastMessage).toBe(Parser.htmlToText(getChangedApproverActionMessage(takeControlAction)));
});
it('REROUTE action', async () => {
const report: Report = createRandomReport(0);
const rerouteAction: ReportAction = {
...createRandomReportAction(1),
actionName: CONST.REPORT.ACTIONS.TYPE.REROUTE,
message: [{type: 'COMMENT', text: ''}],
originalMessage: {},
};
await Onyx.merge(`${ONYXKEYS.COLLECTION.REPORT_ACTIONS}${report.reportID}`, {
[rerouteAction.reportActionID]: rerouteAction,
});
const lastMessage = getLastMessageTextForReport({report, lastActorDetails: null, isReportArchived: false});
expect(lastMessage).toBe(Parser.htmlToText(getChangedApproverActionMessage(rerouteAction)));
});
it('MOVED action', async () => {
const report: Report = createRandomReport(0);
const movedAction: ReportAction = {
...createRandomReportAction(1),
actionName: CONST.REPORT.ACTIONS.TYPE.MOVED,
message: [{type: 'COMMENT', text: ''}],
originalMessage: {},
};
await Onyx.merge(`${ONYXKEYS.COLLECTION.REPORT_ACTIONS}${report.reportID}`, {
[movedAction.reportActionID]: movedAction,
});
const lastMessage = getLastMessageTextForReport({report, lastActorDetails: null, isReportArchived: false});
expect(lastMessage).toBe(Parser.htmlToText(getMovedActionMessage(movedAction, report)));
});
});
});
Loading