[Part 12] Remove Onyx.connect from LoginUtils by kubabutkiewicz · Pull Request #73282 · Expensify/App

kubabutkiewicz · 2025-10-23T06:20:41Z

Explanation of Change

Fixed Issues

$#66333
PROPOSAL:

Tests

Navigate to the form containing the phone number input field.
Enter a phone number without the + prefix or with formatting characters (e.g., (201) 867-5309).
Verify the system rejects improperly formatted phone numbers.
Confirm the error message is displayed for invalid input.
Verify the error message reads: “Please enter a complete phone number (e.g., +1-(201)-867-5309).”
Enter a valid phone number with the + prefix and formatting characters (e.g., +1-(201)-867-5309).
Enter a valid phone number without the + prefix (e.g., 2018675309).
Confirm the system accepts valid phone numbers with or without the + prefix.
Verify the system ignores non-numeric characters during validation.
Ensure no error message is displayed for valid phone numbers.

Verify that no errors appear in the JS console

Offline tests

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

Same as tests

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

melvin-bot · 2025-10-23T06:20:48Z

@DylanDylann Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

codecov · 2025-10-23T06:32:19Z

Codecov Report

❌ Patch coverage is 21.62162% with 58 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
src/pages/RoomInvitePage.tsx	0.00%	4 Missing ⚠️
src/pages/TeachersUnite/KnowATeacherPage.tsx	0.00%	3 Missing ⚠️
...settings/Profile/Contacts/NewContactMethodPage.tsx	0.00%	3 Missing ⚠️
.../settings/Security/AddDelegate/AddDelegatePage.tsx	0.00%	3 Missing ⚠️
...Payments/PersonalInfo/substeps/PhoneNumberStep.tsx	0.00%	2 Missing ⚠️
...es/MissingPersonalDetails/substeps/PhoneNumber.tsx	0.00%	2 Missing ⚠️
...gWorkspaceInvite/BaseOnboardingWorkspaceInvite.tsx	0.00%	2 Missing ⚠️
src/pages/Share/ShareTab.tsx	0.00%	2 Missing ⚠️
...pages/iou/request/MoneyRequestAttendeeSelector.tsx	0.00%	2 Missing ⚠️
...s/iou/request/MoneyRequestParticipantsSelector.tsx	0.00%	2 Missing ⚠️
... and 24 more

Files with missing lines	Coverage Δ
src/libs/LoginUtils.ts	`70.00% <100.00%> (-5.52%)`	⬇️
src/pages/NewChatPage.tsx	`70.00% <100.00%> (ø)`
...workspace/companyCards/assignCard/AssigneeStep.tsx	`52.17% <100.00%> (ø)`
src/components/ApproverSelectionList.tsx	`0.00% <0.00%> (ø)`
...ponents/Search/FilterDropdowns/UserSelectPopup.tsx	`0.00% <0.00%> (ø)`
...c/components/Search/SearchFiltersChatsSelector.tsx	`0.00% <0.00%> (ø)`
...nents/Search/SearchFiltersParticipantsSelector.tsx	`0.00% <0.00%> (ø)`
src/components/WorkspaceMembersSelectionList.tsx	`0.00% <0.00%> (ø)`
src/hooks/useSearchSelector.base.ts	`0.00% <0.00%> (ø)`
src/libs/OptionsListUtils/index.ts	`71.84% <88.88%> (+1.02%)`	⬆️
... and 27 more

... and 58 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

kubabutkiewicz · 2025-10-23T07:22:36Z

@DylanDylann Last one 🙏

DylanDylann · 2025-10-23T10:51:39Z

 function getSearchValueForPhoneOrEmail(searchTerm: string, countryCode: OnyxEntry<number>) {
    // eslint-disable-next-line @typescript-eslint/prefer-nullish-coalescing
-    const parsedPhoneNumber = parsePhoneNumber(appendCountryCodeWithCountryCode(Str.removeSMSDomain(searchTerm), countryCode || CONST.DEFAULT_COUNTRY_CODE));
+    const parsedPhoneNumber = parsePhoneNumber(appendCountryCode(Str.removeSMSDomain(searchTerm), countryCode || CONST.DEFAULT_COUNTRY_CODE));


Suggested change

const parsedPhoneNumber = parsePhoneNumber(appendCountryCode(Str.removeSMSDomain(searchTerm), countryCode || CONST.DEFAULT_COUNTRY_CODE));

const parsedPhoneNumber = parsePhoneNumber(appendCountryCode(Str.removeSMSDomain(searchTerm), countryCode));

@kubabutkiewicz Could you please move the default value to the useOnyx definition? I prefer passing countryCode as a number type rather than as an OnyxEntry (this also happens in some other places, please also help resolve)

These places

Done @DylanDylann

DylanDylann · 2025-10-23T10:55:16Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Screen.Recording.2025-10-23.at.17.59.54.mov

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

DylanDylann · 2025-10-23T11:01:20Z

@kubabutkiewicz There is a minor comment, the rest looks fine

… value when missing

…to part-12-onyxdeprecate-loginutils

DylanDylann · 2025-10-24T05:45:54Z

@kubabutkiewicz Could you make the canBeMissing parameter consistent? I think it should be set to false in all places.

kubabutkiewicz · 2025-10-24T05:52:37Z

@DylanDylann done

DylanDylann

LGTM

mountiny · 2025-10-24T07:34:31Z

 * @returns a valid phone number with country code
 */
-function getPhoneLogin(partnerUserID: string): string {
+function getPhoneLogin(partnerUserID: string, countryCode: number): string {


Should we also update the test for this method? As well as the other method which got the new parameter?

@mountiny We already updated the test. Do you mean we should add more test cases with some other values of countryCode?

ah yeah those tests are adjusted Vit

mountiny

Apologies, i reviewed on bad internet and it did not load all the files changed 🥲 i can see it now. Thank you!

OSBotify · 2025-10-24T12:10:01Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2025-10-24T18:19:05Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.2.38-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2025-10-27T20:08:29Z

🚀 Deployed to production by https://github.com/puneetlath in version: 9.2.38-5 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Remove temporary method and remove the onyx.connect from LoginUtils

05d982d

kubabutkiewicz requested a review from a team as a code owner October 23, 2025 06:20

melvin-bot Bot assigned kubabutkiewicz Oct 23, 2025

melvin-bot Bot requested review from DylanDylann and removed request for a team October 23, 2025 06:20

DylanDylann reviewed Oct 23, 2025

View reviewed changes

kubabutkiewicz added 2 commits October 24, 2025 07:23

Update countryCode handling across multiple components to use default…

e60f8a8

… value when missing

Merge branch 'main' of github.com:callstack-internal/Expensify-App in…

1dc9c28

…to part-12-onyxdeprecate-loginutils

refactor: changed canBeMissing for country codes to be false

d551034

DylanDylann approved these changes Oct 24, 2025

View reviewed changes

melvin-bot Bot requested a review from mountiny October 24, 2025 07:28

mountiny requested changes Oct 24, 2025

View reviewed changes

mountiny approved these changes Oct 24, 2025

View reviewed changes

mountiny merged commit b260040 into Expensify:main Oct 24, 2025
31 checks passed

OSBotify mentioned this pull request Oct 24, 2025

Deploy Checklist: New Expensify 2025-10-24 #73445

Closed

71 tasks

DylanDylann mentioned this pull request Oct 27, 2025

[Due for payment 2025-11-03] Remove Onyx.connect() for the key: ONYXKEYS.COUNTRY_CODE in src/libs/LoginUtils.ts #66333

Closed

	const parsedPhoneNumber = parsePhoneNumber(appendCountryCode(Str.removeSMSDomain(searchTerm), countryCode \|\| CONST.DEFAULT_COUNTRY_CODE));
	const parsedPhoneNumber = parsePhoneNumber(appendCountryCode(Str.removeSMSDomain(searchTerm), countryCode));

Conversation

kubabutkiewicz commented Oct 23, 2025

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Oct 23, 2025

Uh oh!

codecov Bot commented Oct 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

kubabutkiewicz commented Oct 23, 2025

Uh oh!

DylanDylann Oct 23, 2025

Choose a reason for hiding this comment

Uh oh!

DylanDylann Oct 23, 2025

Choose a reason for hiding this comment

Uh oh!

DylanDylann Oct 23, 2025

Choose a reason for hiding this comment

Uh oh!

kubabutkiewicz Oct 24, 2025

Choose a reason for hiding this comment

Uh oh!

DylanDylann commented Oct 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

DylanDylann commented Oct 23, 2025

Uh oh!

DylanDylann commented Oct 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kubabutkiewicz commented Oct 24, 2025

Uh oh!

DylanDylann left a comment

Choose a reason for hiding this comment

Uh oh!

mountiny Oct 24, 2025

Choose a reason for hiding this comment

Uh oh!

DylanDylann Oct 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kubabutkiewicz Oct 24, 2025

Choose a reason for hiding this comment

Uh oh!

mountiny left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

OSBotify commented Oct 24, 2025

Uh oh!

OSBotify commented Oct 24, 2025

Uh oh!

OSBotify commented Oct 27, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

codecov Bot commented Oct 23, 2025 •

edited

Loading

DylanDylann commented Oct 23, 2025 •

edited

Loading

DylanDylann commented Oct 24, 2025 •

edited

Loading

DylanDylann Oct 24, 2025 •

edited

Loading