Report - "It´s not here" briefly seen when deleting report with more than one expense by lorretheboy · Pull Request #73311 · Expensify/App

lorretheboy · 2025-10-23T13:45:24Z

Explanation of Change

Fixed Issues

$ #72666
PROPOSAL: #72666 (comment)

Tests

Prerequisite: account has at least one workspace.

Open the ND
Open any workspace chat.
Create two manual expenses.
Navigate to "Reports"
Tap on the link to workspace chat, on the report preview.
Once redirected to chat, long tap on report preview and delete it.
Verify that Report should automatically disappear after being deleted.

Verify that no errors appear in the JS console

Offline tests

Prerequisite: account has at least one workspace.

Open the ND
Open any workspace chat.
Create two manual expenses.
Navigate to "Reports"
Tap on the link to workspace chat, on the report preview.
Once redirected to chat, go offline and then long tap on report preview and delete it.
Verify that Report should be grey out.
Turn on internet, verify that Report should disappear

QA Steps

Same as Tests

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

ANDROID.mov

Android: mWeb Chrome

WEBSITE.ANDROID.mov

iOS: Native

IOS.mov

iOS: mWeb Safari

WEBSITE.IOS.mov

MacOS: Chrome / Safari

WEBSITE.mov

MacOS: Desktop

DESKTOP.mov

codecov · 2025-10-23T14:01:06Z

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
src/libs/actions/Report.ts	`54.51% <66.66%> (-0.01%)`	⬇️
... and 9 files with indirect coverage changes

melvin-bot · 2025-10-24T14:14:57Z

@parasharrajat Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

parasharrajat · 2025-10-24T15:38:32Z

            value: {
-                [reportActionID]: reportAction,
+                [reportActionID]: {
+                    pendingAction: null,


I don't think we should reset this but allow the user to see the error and clear it via close button. If you set this to null, error will not show.

Try by throwing an error with pending state and see how to behaves in app. removing the error from UI will remove the pending Action.

parasharrajat · 2025-10-26T16:31:14Z

@lorretheboy I think the root cause explanation is your proposal is still somewhat wrong.

`MoneyRequestReportPreviewContent passes pendingAction={iouReport?.pendingFields?.preview} which evaluates to undefined

After your solution, pendingaction here is still undefined in here. I think you are still missing a few pieces of this, and the proposal was not complete.

So there what we should do.

Update the pending action on previewAction as you are doing.
Update the pendingFields on ioureport as well.
Keep the failure error at the same level as deleteMoneyRequest do. Action level or iou report level. Go through deleteMoneyRequest logic and see how it handles it.

`

parasharrajat · 2025-11-03T12:23:36Z

Any update @lorretheboy

lorretheboy · 2025-11-03T16:31:50Z

@parasharrajat Could you please re-check this PR. I fixed the PR by following the request in deleteMoneyRequest also retested it.

parasharrajat · 2025-11-19T11:59:18Z

@lorretheboy Can you please merge main?

parasharrajat · 2025-11-19T12:07:05Z

-        onyxMethod: Onyx.METHOD.MERGE,
+        onyxMethod: Onyx.METHOD.SET,
        key: `${ONYXKEYS.COLLECTION.REPORT}${reportID}`,
        value: report,


Should this be updated to with generic delete failure message?

errorFields: {preview: ErrorUtils.getMicroSecondOnyxErrorWithTranslationKey('workflowsApprovalPage.genericErrorMessage')},

I don't see the error in the request failure.

Hmm could you please let me know the use-case for adding failure message here. Maybe I miss somethin, I don't know why do we need it. We also don't set any error message in deleteMoneyRequest @parasharrajat

I just tested and it looks like we do have an error below for the reportAction so we don't need error for preview.

parasharrajat · 2025-11-20T16:09:54Z

Screenshots

🔲 iOS / native

20.11.2025_22.43.09_REC.mp4

🔲 iOS / Safari

20.11.2025_22.48.25_REC.mp4

🔲 MacOS / Chrome

20.11.2025_21.43.21_REC.mp4

🔲 Android / Chrome

20.11.2025_22.47.33_REC.mp4

🔲 Android / native

20.11.2025_22.45.17_REC.mp4

parasharrajat

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

🎀 👀 🎀 C+ reviewed

OSBotify · 2025-11-25T07:53:11Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2025-11-26T03:52:39Z

🚀 Deployed to staging by https://github.com/youssef-lr in version: 9.2.64-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2025-11-27T01:21:20Z

🚀 Deployed to production by https://github.com/marcaaron in version: 9.2.64-5 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

fix: not found issue when delete expense

6225396

melvin-bot Bot assigned lorretheboy Oct 23, 2025

lorretheboy changed the title ~~Android - Report - "It´s not here" briefly seen when deleting report with more than one expense~~ Report - "It´s not here" briefly seen when deleting report with more than one expense Oct 23, 2025

fix: hard code

12f98b8

lorretheboy marked this pull request as ready for review October 24, 2025 14:14

lorretheboy requested a review from a team as a code owner October 24, 2025 14:14

melvin-bot Bot requested review from parasharrajat and removed request for a team October 24, 2025 14:14

lorretheboy mentioned this pull request Oct 24, 2025

[Due for payment 2025-12-04] [$250] Android - Report - "It´s not here" briefly seen when deleting report with more than one expense #72666

Closed

8 tasks

parasharrajat suggested changes Oct 24, 2025

View reviewed changes

Merge branch 'main' of https://github.com/Expensify/App into fix/72666

7b01c7e

lorretheboy added 2 commits November 3, 2025 23:59

Merge branch 'main' of https://github.com/Expensify/App into fix/72666

939a8b0

fix: sol

5521d0f

parasharrajat reviewed Nov 19, 2025

View reviewed changes

merge main

0bd65bf

lorretheboy requested a review from a team as a code owner November 20, 2025 14:04

melvin-bot Bot requested review from JmillsExpensify and removed request for a team November 20, 2025 14:04

parasharrajat approved these changes Nov 20, 2025

View reviewed changes

melvin-bot Bot requested a review from youssef-lr November 20, 2025 17:20

youssef-lr approved these changes Nov 25, 2025

View reviewed changes

youssef-lr merged commit 3d0b437 into Expensify:main Nov 25, 2025
30 of 32 checks passed

OSBotify mentioned this pull request Nov 26, 2025

Deploy Checklist: New Expensify 2025-11-26 #76071

Closed

70 tasks

Conversation

lorretheboy commented Oct 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

codecov Bot commented Oct 23, 2025 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

melvin-bot Bot commented Oct 24, 2025

Uh oh!

parasharrajat Oct 24, 2025

Choose a reason for hiding this comment

Uh oh!

parasharrajat Oct 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

lorretheboy Nov 3, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

parasharrajat commented Oct 26, 2025

Uh oh!

parasharrajat commented Nov 3, 2025

Uh oh!

lorretheboy commented Nov 3, 2025

Uh oh!

parasharrajat commented Nov 19, 2025

Uh oh!

parasharrajat Nov 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

parasharrajat Nov 19, 2025

Choose a reason for hiding this comment

Uh oh!

lorretheboy Nov 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

parasharrajat Nov 20, 2025

Choose a reason for hiding this comment

Uh oh!

parasharrajat commented Nov 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Screenshots

🔲 iOS / native

🔲 iOS / Safari

🔲 MacOS / Chrome

🔲 Android / Chrome

🔲 Android / native

Uh oh!

parasharrajat left a comment

Choose a reason for hiding this comment

Reviewer Checklist

Uh oh!

Uh oh!

OSBotify commented Nov 25, 2025

Uh oh!

OSBotify commented Nov 26, 2025

Uh oh!

OSBotify commented Nov 27, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

lorretheboy commented Oct 23, 2025 •

edited

Loading

codecov Bot commented Oct 23, 2025 •

edited by github-actions Bot

Loading

parasharrajat Oct 24, 2025 •

edited

Loading

parasharrajat Nov 19, 2025 •

edited

Loading

lorretheboy Nov 20, 2025 •

edited

Loading

parasharrajat commented Nov 20, 2025 •

edited

Loading