Skip to content

Revert "Fix: Create report button is shown in per diem expense when default workspace does not have per diem"#73329

Closed
grgia wants to merge 1 commit into
mainfrom
revert-73096-issue-72732
Closed

Revert "Fix: Create report button is shown in per diem expense when default workspace does not have per diem"#73329
grgia wants to merge 1 commit into
mainfrom
revert-73096-issue-72732

Conversation

@grgia

@grgia grgia commented Oct 23, 2025

Copy link
Copy Markdown
Contributor

Reverts #73096

Fixes #73312

@github-actions

Copy link
Copy Markdown
Contributor

🚧 @grgia has triggered a test Expensify/App build. You can view the workflow run here.

@github-actions

Copy link
Copy Markdown
Contributor

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪
Built from App PR #73329.

Android 🤖 iOS 🍎
⏩ SKIPPED ⏩ ⏩ SKIPPED ⏩
The build for Android was skipped The build for iOS was skipped
Desktop 💻 Web 🕸️
⏩ SKIPPED ⏩ https://73329.pr-testing.expensify.com
The build for Desktop was skipped Web

👀 View the workflow run that generated this build 👀

@codecov

codecov Bot commented Oct 23, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/pages/NewReportWorkspaceSelectionPage.tsx 0.00% 1 Missing ⚠️
Files with missing lines Coverage Δ
src/hooks/usePolicyForMovingExpenses.ts 75.00% <100.00%> (-1.20%) ⬇️
...rc/pages/iou/request/step/IOURequestEditReport.tsx 0.00% <ø> (ø)
...es/iou/request/step/IOURequestEditReportCommon.tsx 76.54% <100.00%> (ø)
...rc/pages/iou/request/step/IOURequestStepReport.tsx 0.00% <ø> (ø)
src/pages/NewReportWorkspaceSelectionPage.tsx 0.00% <0.00%> (ø)

... and 12 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@cristipaval

Copy link
Copy Markdown
Contributor

Closing this.

@grgia grgia closed this Nov 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Due for payment 2025-12-03][$250] Expense - Create report is unresponsive after deleting workspace with per diem rates

2 participants