[No QA] Update Expensify Card setup guide#73385
Conversation
Removed note about Expensify Card availability for UK and EU customers. Uk/EU expensify Cards are not live yet and this shouldn't have been published. Expensify/Expensify#559472
Concierge reviewer checklist:
For more detailed instructions on completing this checklist, see How do I review a HelpDot PR as a Concierge Team member? cc @abekkala |
HelpDot Documentation ReviewOverall AssessmentThis PR makes a focused correction to the Expensify Classic card setup documentation by removing premature information about UK/EU card availability. The change aligns with business requirements to prevent customer confusion about features that are not yet live. Scores Summary
Key Findings
Recommendations
Files Reviewed
Note: This is a content-focused change with no complex formatting or structural issues requiring detailed inline comments. |
|
A preview of your ExpensifyHelp changes have been deployed to https://9c2058b3.helpdot.pages.dev ⚡️ Updated articles: |
|
@RachCHopkins looks like this was merged without a test passing. Please add a note explaining why this was done and remove the |
|
It kinda was an emergency - we needed that line taken down before UK business hours. Not sure which test didn't pass other than the AI formatting suggestion. |
|
🚀 Deployed to staging by https://github.com/RachCHopkins in version: 9.2.38-0 🚀
|
|
🚀 Deployed to production by https://github.com/puneetlath in version: 9.2.38-5 🚀
|
Removed note about Expensify Card availability for UK and EU customers. Uk/EU expensify Cards are not live yet and this shouldn't have been published. https://github.com/Expensify/Expensify/issues/559472
Explanation of Change
Fixed Issues
$
PROPOSAL:
Tests
Offline tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop