Skip to content

[No QA] Update Expensify Card setup guide#73385

Merged
RachCHopkins merged 1 commit into
mainfrom
VictoriaExpensify-patch-6
Oct 24, 2025
Merged

[No QA] Update Expensify Card setup guide#73385
RachCHopkins merged 1 commit into
mainfrom
VictoriaExpensify-patch-6

Conversation

@VictoriaExpensify

@VictoriaExpensify VictoriaExpensify commented Oct 24, 2025

Copy link
Copy Markdown
Contributor

Removed note about Expensify Card availability for UK and EU customers. Uk/EU expensify Cards are not live yet and this shouldn't have been published. https://github.com/Expensify/Expensify/issues/559472

Explanation of Change

Fixed Issues

$
PROPOSAL:

Tests

  • Verify that no errors appear in the JS console

Offline tests

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
    • MacOS: Desktop
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I verified there are no new alerts related to the canBeMissing param for useOnyx
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop

Removed note about Expensify Card availability for UK and EU customers. Uk/EU expensify Cards are not live yet and this shouldn't have been published. Expensify/Expensify#559472
@melvin-bot

melvin-bot Bot commented Oct 24, 2025

Copy link
Copy Markdown

Concierge reviewer checklist:

  • I have verified the accuracy of the article
    • The article is within a hub that makes sense, and the navigation is correct
    • All processes, screenshots, and examples align with current product behavior.
    • All links within the doc have been verified for correct destination and functionality.
  • I have verified the readability of the article
    • The article's language is clear, concise, and free of jargon.
    • The grammar, spelling, and punctuation are correct.
    • The article contains at least one image, or that an image is not necessary
  • I have verified the formatting of the article
    • The article has consistent formatting (headings, bullet points, etc.) with other HelpDot articles and that aligns with the HelpDot formatting standards.
    • The article has proper text spacing and breaks for readability.
  • I have verified the article has the appropriate tone and style
    • The article's tone is professional, friendly, and suitable for the target audience.
    • The article's tone, terminology, and voice are consistent throughout.
  • I have verified the overall quality of the article
    • The article is not missing any information, nor does it contain redundant information.
    • The article fully addresses user needs.
  • I have verified that all requested improvements have been addressed

For more detailed instructions on completing this checklist, see How do I review a HelpDot PR as a Concierge Team member?

cc @abekkala

@melvin-bot melvin-bot Bot requested review from abekkala and removed request for a team October 24, 2025 01:20
@melvin-bot

melvin-bot Bot commented Oct 24, 2025

Copy link
Copy Markdown

@abekkala Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@VictoriaExpensify VictoriaExpensify changed the title Update Expensify Card setup guide [No QA] Update Expensify Card setup guide Oct 24, 2025
@github-actions

Copy link
Copy Markdown
Contributor

HelpDot Documentation Review

Overall Assessment

This PR makes a focused correction to the Expensify Classic card setup documentation by removing premature information about UK/EU card availability. The change aligns with business requirements to prevent customer confusion about features that are not yet live.

Scores Summary

  • Readability: 9/10 - The removal improves document flow and eliminates confusing information
  • AI Readiness: 8/10 - Document maintains clear structure and context, though the removal of geographical context may slightly reduce AI understanding of limitations
  • Style Compliance: 9/10 - Maintains proper Expensify documentation standards and terminology

Key Findings

  • Positive: Clean removal that eliminates customer confusion about unavailable features
  • Positive: Maintains document structure and flow without disruption
  • Positive: Preserves all essential setup information for US customers
  • Minor consideration: The document now lacks explicit mention of geographical limitations, which could be addressed with alternative phrasing if needed

Recommendations

  • Approved for merge: This is a straightforward content correction that improves accuracy
  • Consider future enhancement: When UK/EU cards do become available, consider adding a brief note about availability regions without linking to unreleased features
  • Monitor for customer inquiries: Track if removal of this information leads to increased support requests about international availability

Files Reviewed

  • docs/articles/expensify-classic/expensify-card/Set-Up-the-Expensify-Visa-Commercial-Card-for-your-Company.md - Clean removal, maintains document integrity

Note: This is a content-focused change with no complex formatting or structural issues requiring detailed inline comments.

@OSBotify

Copy link
Copy Markdown
Contributor

A preview of your ExpensifyHelp changes have been deployed to https://9c2058b3.helpdot.pages.dev ⚡️

Updated articles:

@RachCHopkins RachCHopkins requested review from RachCHopkins and removed request for abekkala October 24, 2025 02:51

@RachCHopkins RachCHopkins left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@RachCHopkins RachCHopkins merged commit 8ebf129 into main Oct 24, 2025
13 of 14 checks passed
@RachCHopkins RachCHopkins deleted the VictoriaExpensify-patch-6 branch October 24, 2025 02:56
@melvin-bot melvin-bot Bot added the Emergency label Oct 24, 2025
@melvin-bot

melvin-bot Bot commented Oct 24, 2025

Copy link
Copy Markdown

@RachCHopkins looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@RachCHopkins

Copy link
Copy Markdown
Contributor

It kinda was an emergency - we needed that line taken down before UK business hours. Not sure which test didn't pass other than the AI formatting suggestion.

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/RachCHopkins in version: 9.2.38-0 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/puneetlath in version: 9.2.38-5 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants