Don't allow users to chat with Concierge when blocked#7340
Conversation
chiragsalian
left a comment
There was a problem hiding this comment.
Changes LGTM and code works well.
|
Triggered auto assignment to @Beamanator ( |
|
@chiragsalian looks like this was merged without passing tests. Please add a note explaining why this was done and remove the |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
I think perhaps the internalQA label might have screwed up some stuff since i don't think we've used it before for App repo. Either way it's all good melvin and botify. |
|
🚀 Deployed to staging by @chiragsalian in version: 1.1.32-1 🚀
|
|
🚀 Deployed to production by @roryabraham in version: 1.1.33-3 🚀
|
Details
This PR makes a few changes/updates to the concierge blocking functionality.
isBlockedFromConciergeNVP in the API call. This was broken at some point.Screen.Recording.2022-01-20.at.5.30.18.PM.mov
Fixed Issues
$ https://github.com/Expensify/Expensify/issues/172842
Tests
expensify.com.dev/concierge/ToolsQA Steps
Will need to be tested by an Expensify employee on production. Steps are the same as above.
Tested On
Screenshots
Web
Video above.
Mobile Web
Desktop
iOS
Android