Fix - Updates to "Contact method" section of New Expensify profile

[FitseTLT]

Explanation of Change

Fixed Issues

$ #73259
PROPOSAL: #73259 (comment)

Tests

Precondition: Have an account with multiple contact methods

1. Go to Account > Profile
2. Verify the contact-methods menu has all logins listed, comma-separated

• Verify that no errors appear in the JS console

Offline tests

Same as above

QA Steps

Same as above

• Verify that no errors appear in the JS console

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I verified there are no new alerts related to the canBeMissing param for useOnyx
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
• I verified that if a function's arguments changed that all usages have also been updated correctly
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
• If new assets were added or existing ones were modified, I verified that:
  • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
  • The assets load correctly across all supported platforms.
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label so the design team can review the changes.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

2025-10-24.23-55-12.mp4

Android: mWeb Chrome

2025-10-24.22-48-33.mp4

iOS: Native

iOS: mWeb Safari

2025-10-24.22-47-08.mp4

MacOS: Chrome / Safari

2025-10-24.22-46-26.mp4

MacOS: Desktop

2025-10-24.22-46-51.mp4

[melvin-bot]

@allroundexperts Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[FitseTLT]

cc @dannymcclain @jamesdeanexpensify

[codecov]

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/pages/settings/Profile/ProfilePage.tsx	91.35% <100.00%> (+0.21%)	⬆️
... and 322 files with indirect coverage changes

[dannymcclain]

Looking good so far! We can remove this little copy button:

cc @dubielzyk-expensify for viz

[dannymcclain]

Oh I just noticed we have some weird extra space in the filled Primary field. The spacing here should just follow our normal push input. Looks like the Secondary field is correct.

Other examples:

[FitseTLT]

Oh I just noticed we have some weird extra space in the filled Primary field. The spacing here should just follow our normal push input. Looks like the Secondary field is correct.

Other examples:

@dannymcclain it is the normal push input styling but for the case of Secondary there is a description text (please verify this contact ..) which pushs up the title and feels like Primary has more spacing.

[FitseTLT]

Looking good so far! We can remove this little copy button:

cc @dubielzyk-expensify for viz

Is it expected to remove the copy button here @jamesdeanexpensify ? Because receipt@expensify.com is an email I feel like copy to clipboard is the right way. WDYT

[dannymcclain]

it is the normal push input styling but for the case of Secondary there is a description text (please verify this contact ..) which pushs up the title and feels like Primary has more spacing

This doesn't sound right to me. I put an example of a few more normal push inputs in my comment—none of them have the same extra space that the Primary push row is showing. Here are some more:

I removed the copy button during the redesign of this screen, so IMO it is expected for it to be gone 😅, but if we think we need to keep it (personally I think it's kinda just noise), let's at least update the spacing so it isn't butting up against or.

[melvin-bot]

Hey, I noticed you changed src/languages/en.ts in a PR from a fork. If you want to automatically generate translations for other locales, you can run the Generate static translations GitHub workflow.

Please look at the code and make sure there are no malicious changes before running the workflow.

If you have the K2 extension, you can simply click: [this button]

[FitseTLT]

Let me know how you feel about this change for both issues

[dubielzyk-expensify]

I removed the copy button during the redesign of this screen, so IMO it is expected for it to be gone 😅, but if we think we need to keep it (personally I think it's kinda just noise), let's at least update the spacing so it isn't butting up against or.

Yeah I agree that it's cleaner without it. The link is clickable and will take you to your email anyways.

Good catch on the other things 👍

[dubielzyk-expensify]

The space here looks big though, or maybe my eyes are wrong?

Can we ensure we're using the same spacing as the other flows. The hover states should touch each other basically:

CleanShot.2025-10-28.at.10.21.37.mp4

[melvin-bot]

Hey, I noticed you changed src/languages/en.ts in a PR from a fork. For security reasons, translations are not generated automatically for PRs from forks.

If you want to automatically generate translations for other locales, an Expensify employee will have to:

1. Look at the code and make sure there are no malicious changes.
2. Run the Generate static translations GitHub workflow. If you have write access and the K2 extension, you can simply click: [this button]

Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running:

npx ts-node ./scripts/generateTranslations.ts --help

Typically, you'd want to translate only what you changed by running npx ts-node ./scripts/generateTranslations.ts --compare-ref main

[FitseTLT]

The space here looks big though, or maybe my eyes are wrong?

Can we ensure we're using the same spacing as the other flows. The hover states should touch each other basically:

CleanShot.2025-10-28.at.10.21.37.mp4

@dubielzyk-expensify the hover state touch each other here too there is no specific style applied it is a normal menu item.

2025-10-30.22-59-32.mp4

[FitseTLT]

BTW to make things clear in these menu items there are label, description, title and for primary there is no description so @dannymcclain didn't want the gap to occur between the primary label and the title so when I pushed it up there seems like there is a lot of spacing between the menu. So the space has to exist somewhere as all menu items should have the same height I suppose.
Look at the difference when we have another item with description

2025-10-30.23-09-04.mp4

[dubielzyk-expensify]

Yeah the reason for the space is because this is wrong. When we don't have the help text underneath the email then the whole row should be as tall. You can see the padding below the email is too big:

If you go to Account -> Profile you can see the correct height of the push input without the help text:

[dubielzyk-expensify]

So the space has to exist somewhere as all menu items should have the same height I suppose.

I don't think we should have the same height though. They should grow like they normally do. Curious for @dannymcclain 's take though

[dannymcclain]

Agree with Jon. This screen probably hasn't been touched in quite a while, so it's probably worth looking at some other areas of the product for styling help. Workspace Overview might be a good one to look at since it has both push rows with and without help text.

CleanShot.2025-10-31.at.08.30.31.mp4

You can definitely see here that the default currency row is indeed taller than the rest since it has the description text.

[jamesdeanexpensify]

Yeah I don't mind that at all!

[dannymcclain]

Yeah I don't either. Given we've already seen at least a bit of internal confusion with the repetitive labels, I'd be down to pivot towards this design. cc @dubielzyk-expensify

[trjExpensify]

Works for me too!

[dubielzyk-expensify]

Sounds good to me 👍

[FitseTLT]

So, to make it clear. We will only update the copy here

and avoid the primary and secondary labels, right?

[jamesdeanexpensify]

That's correct, and also updating the copy at the top of the pane, all laid out here. So I guess this is mostly a copy update now!

[FitseTLT]

@jamesdeanexpensify are you ok with this copy?

We'll use this method to contact you.

this method what method? seems confusing 😕

[jamesdeanexpensify]

We could say We'll contact you here. Does that sound better to you?

[FitseTLT]

We could say We'll contact you here. Does that sound better to you?

Even more confusing 😄 to me. Now I see that we have Contact methods on the title of the page, this method might be clear enough. But my previous concern was that method was more generic word, may be contact method or login etc. might be better. But WDYT guys

[jamesdeanexpensify]

I think I'm good with We'll use this method to contact you. for now!

[FitseTLT]

This is how it looks now.

2025-11-20.23-34-25.mp4

[jamesdeanexpensify]

Thanks! Curious for @Expensify/design take on the comment directly above. My only comment is can you also add a period after Please verify this contact method.?

[dubielzyk-expensify]

I think that looks fine. Agree on the period

[FitseTLT]

Added period. @allroundexperts U can proceed.

[allroundexperts]

Reviewer Checklist

• I have verified the author checklist is complete (all boxes are checked off).
• I verified the correct issue is linked in the ### Fixed Issues section above
• I verified testing steps are clear and they cover the changes made in this PR
  • I verified the steps for local testing are in the Tests section
  • I verified the steps for Staging and/or Production testing are in the QA steps section
  • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
• I checked that screenshots or videos are included for tests on all platforms
• I included screenshots or videos for tests on all platforms
• I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
• I verified tests pass on all platforms & I tested again on:
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop
• If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
• I verified there are no new alerts related to the canBeMissing param for useOnyx
• I verified proper code patterns were followed (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I verified that this PR follows the guidelines as stated in the Review Guidelines
• I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
• If a new component is created I verified that:
  • A similar component doesn't exist in the codebase
  • All props are defined accurately and each prop has a /** comment above it */
  • The file is named correctly
  • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
  • The only data being stored in the state is data necessary for rendering and nothing else
  • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
  • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
  • All JSX used for rendering exists in the render method
  • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
• I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

Uploading Screen Recording 2025-11-24 at 4.55.19 AM.mov…

iOS: HybridApp

Screen.Recording.2025-11-24.at.4.52.51.AM.mov

iOS: mWeb Safari

Screen.Recording.2025-11-24.at.4.51.05.AM.mov

MacOS: Chrome / Safari

Screen.Recording.2025-11-24.at.4.40.24.AM.mov

MacOS: Desktop

Screen.Recording.2025-11-24.at.4.45.58.AM.mov

[MonilBhavsar]

👍

[OSBotify]

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

[mitarachim]

Hello @FitseTLT , based on this comment, is it expected that the labels primary or secondary are not displayed? Please confirm.
Thank you in advance.

Bug7013684_1764123211974.Recording__1016.mp4

[OSBotify]

🚀 Deployed to staging by https://github.com/MonilBhavsar in version: 9.2.64-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

[FitseTLT]

Hello @FitseTLT , based on this comment, is it expected that the labels primary or secondary are not displayed? Please confirm. Thank you in advance.

Bug7013684_1764123211974.Recording__1016.mp4

Sorry @mitarachim Updated the steps now.

[OSBotify]

🚀 Deployed to production by https://github.com/marcaaron in version: 9.2.64-5 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅