Skip to content

[No QA] Dont require accessibility checkboxes to ship a deploy checklist#7348

Merged
AndrewGable merged 2 commits into
mainfrom
Rory-DontRequireAccessibilityCheckboxes
Jan 24, 2022
Merged

[No QA] Dont require accessibility checkboxes to ship a deploy checklist#7348
AndrewGable merged 2 commits into
mainfrom
Rory-DontRequireAccessibilityCheckboxes

Conversation

@roryabraham

Copy link
Copy Markdown
Contributor

Details

Coming from https://expensify.slack.com/archives/C07J32337/p1642722197174300

Fixed Issues

$ n/a

Tests

  1. Close a deploy checklist with the :shipit: comment and all the QA boxes checked but a deploy blocker unchecked.
  2. The issue should reopen.
  3. Close a deploy checklist with the :shipit: comment and all the deploy blockers checked but a QA box unchecked.
  4. The issue should reopen.
  5. Close a deploy checklist with the :shipit: comment, all the QA boxes checked, all the deploy blockers checked, and at least one accessibility checkbox unchecked.
  6. The issue should not reopen and the production deploy should happen.

QA Steps

None.

Tested On

Jest/GitHub only

@roryabraham roryabraham self-assigned this Jan 21, 2022
@roryabraham roryabraham marked this pull request as ready for review January 21, 2022 01:16
@roryabraham roryabraham requested a review from a team as a code owner January 21, 2022 01:16
@roryabraham roryabraham changed the title Dont require accessibility checkboxes to ship a deploy checklist [No QA] Dont require accessibility checkboxes to ship a deploy checklist Jan 21, 2022
@MelvinBot MelvinBot requested review from sketchydroide and removed request for a team January 21, 2022 01:16
@sketchydroide

Copy link
Copy Markdown
Contributor

is this something I can test along side the deployer for the week @roryabraham?

@roryabraham

Copy link
Copy Markdown
Contributor Author

I think it'll be best for the current deployer to test this, because it should be tested when we're about ready to ship a prod deploy

@sketchydroide

Copy link
Copy Markdown
Contributor

@chiragsalian do you mind testing then 🙏🏼

@chiragsalian

Copy link
Copy Markdown
Contributor

Well the QA checklist isn't done yet and I don't plan on deploying today cause its a friday. So we've to inform the next deployer to test this on monday.

@sketchydroide

Copy link
Copy Markdown
Contributor

@AndrewGable seems like you are the deployer for the week, so you mind doing the testing as part of the deployment process for this week 🙏🏼

@AndrewGable

Copy link
Copy Markdown
Contributor

Yes, I can test

@AndrewGable AndrewGable merged commit 8bd71de into main Jan 24, 2022
@AndrewGable AndrewGable deleted the Rory-DontRequireAccessibilityCheckboxes branch January 24, 2022 17:38
@OSBotify

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by @AndrewGable in version: 1.1.32-1 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify

OSBotify commented Feb 1, 2022

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by @roryabraham in version: 1.1.33-3 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants