You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Close a deploy checklist with the comment and all the QA boxes checked but a deploy blocker unchecked.
The issue should reopen.
Close a deploy checklist with the comment and all the deploy blockers checked but a QA box unchecked.
The issue should reopen.
Close a deploy checklist with the comment, all the QA boxes checked, all the deploy blockers checked, and at least one accessibility checkbox unchecked.
The issue should not reopen and the production deploy should happen.
roryabraham
changed the title
Dont require accessibility checkboxes to ship a deploy checklist
[No QA] Dont require accessibility checkboxes to ship a deploy checklist
Jan 21, 2022
Well the QA checklist isn't done yet and I don't plan on deploying today cause its a friday. So we've to inform the next deployer to test this on monday.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
Coming from https://expensify.slack.com/archives/C07J32337/p1642722197174300
Fixed Issues
$ n/a
Tests
QA Steps
None.
Tested On
Jest/GitHub only