Fix : Unable to type next paragraph in message#7355
Merged
Conversation
parasharrajat
suggested changes
Jan 21, 2022
Co-authored-by: Rajat Parashar <parasharrajat@users.noreply.github.com>
Co-authored-by: Rajat Parashar <parasharrajat@users.noreply.github.com>
parasharrajat
suggested changes
Jan 21, 2022
Co-authored-by: Rajat Parashar <parasharrajat@users.noreply.github.com>
parasharrajat
previously approved these changes
Jan 21, 2022
parasharrajat
left a comment
parasharrajat
left a comment
Member
There was a problem hiding this comment.
LGTM.
cc: @roryabraham
🎀 👀 🎀 C+ reviewed
roryabraham
requested changes
Jan 22, 2022
parasharrajat
previously approved these changes
Jan 22, 2022
roryabraham
requested changes
Jan 24, 2022
roryabraham
approved these changes
Jan 24, 2022
roryabraham
left a comment
roryabraham
left a comment
Contributor
There was a problem hiding this comment.
Looks good and tests well
Contributor
|
@ahmdshrif Thanks for making those few updates I requested 👍 |
Contributor
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
Contributor
Author
|
thanks @roryabraham |
46 tasks
Contributor
|
🚀 Deployed to staging by @roryabraham in version: 1.1.32-1 🚀
|
Contributor
|
🚀 Deployed to production by @roryabraham in version: 1.1.33-3 🚀
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
Fixed Issues
$ #6767
Tests/QA Steps
1- Go to app
2- Open any chat
3- Type 1 line & hit return to add a paragraph in same message
Tested On
Screenshots
Web
Screen.Recording.2022-01-21.at.9.28.49.AM.mov
Mobile Web
Screen_Recording_20220121-093128_Samsung.Internet.mp4
Desktop
Screen.Recording.2022-01-21.at.9.37.32.AM.mov
iOS
Screen.Recording.2022-01-21.at.11.23.17.AM.mov
Android
Screen.Recording.2022-01-21.at.9.56.02.AM.mov