fix: Added web link for desktop error page

[mananjadhav]

Details

• Added web link for desktop error page

Fixed Issues

$ #7316

Tests

1. Tested link for the Desktop App

• Verify that no errors appear in the JS console

QA Steps

Need to follow the reproduction steps from #6856 (comment) for Desktop.

• Verify that no errors appear in the JS console

Tested On

• Web
• Mobile Web
• Desktop
• iOS
• Android

Screenshots

Web

Mobile Web

Desktop

iOS

Android

[parasharrajat]

LGTM.

cc: @NikkiWines
🎀 👀 🎀 C+ reviewed

[parasharrajat]

Thanks for correcting the link. I missed that.

[NikkiWines]

Just a note that the linked QA steps don't work currently on dev - looks like someone fixed the room details issue. I would update the QA steps to direct the tester to go to a malformed URL like https://new.expensify.com/r/75431276____/details

[mananjadhav]

Just a note that the linked QA steps don't work currently on dev - looks like someone fixed the room details issue. I would update the QA steps to direct the tester to go to a malformed URL like https://new.expensify.com/r/75431276____/details

@NikkiWines Anyway to get this working for Desktop App? Because we can't enter URL there.

[NikkiWines]

@mananjadhav oh, right - in that case if we can use the following steps for desktop (this flow works fine on web, oddly):

1. Create a new room using the + FAB
2. Click on the room's icon to open up the room details
3. Click on Settings
4. Confirm you see the error page and that it directs you to switch to web

Screen.Recording.2022-01-24.at.10.17.39.mov

[NikkiWines]

👍

[NikkiWines]

@mananjadhav since you mentioned tackling the url constant updates in a separate issue/PR, I'm going to go ahead and merge this - sound good?

[mananjadhav]

Yeah thanks, will you also help create an issue then? It'll be easier to track?

[NikkiWines]

@roryabraham created one already here

[OSBotify]

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

[OSBotify]

🚀 Deployed to staging by @NikkiWines in version: 1.1.33-4 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

[OSBotify]

🚀 Deployed to production by @sketchydroide in version: 1.1.34-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅