Separate report name and icon configuration from personal details by sobitneupane · Pull Request #7367 · Expensify/App

sobitneupane · 2022-01-24T07:38:47Z

Details

Solve the issue of report names and icons.

Fixed Issues

$ #7261

Tests

Create New Room (Private) and check report name and icon
Create New Room (Restricted) and check report name and icon
Create New Group and check report name and icon
Create New Chat and check report name and icon

QA Steps

Create New Room (Private) and check report name and icon
Create New Room (Restricted) and check report name and icon
Create New Group and check report name and icon
Create New Chat and check report name and icon

Tested On

Screenshots

Web

Mobile Web

Desktop

iOS

Android

parasharrajat · 2022-01-24T09:00:42Z

            PersonalDetails.getFromReportParticipants(_.values(simplifiedReports));
+
+            // Configure Report Name and Report Icon
+            configureReportNameAndIcon(_.values(simplifiedReports));


There could be race conditions here personal details may have not been stored in Onyx when this is called.

Promise.resolve(PersonalDetails.getFromReportParticipants(_.values(simplifiedReports))).then( details => configureReportNameAndIcon(_.values(simplifiedReports), details), );

@parasharrajat It will solve the issue. Any suggestion?

It won't be needed when PersonalDetails.getFromReportParticipants will return a promise.

parasharrajat · 2022-01-24T09:00:57Z

+    Onyx.connect({
+        key: ONYXKEYS.PERSONAL_DETAILS,
+        callback: (formattedPersonalDetails) => {
+            const reportsToUpdate = {};


Where are you canceling the subscription?

I didn't find anything about cancelling the subscription in the code as well as documentation.
Do you mean?

Onyx.connect({ key: ONYXKEYS.PERSONAL_DETAILS, callback: (formattedPersonalDetails) => { + if (!formattedPersonalDetails) { + return; + } const reportsToUpdate = {};

I am planing not to connect to onyx here. Instead use the returned value from PersonalDetails.getFromReportParticipants(_.values(simplifiedReports))

Yeah, that is a good idea.

Action methods should only have return values (data or a promise) if they are called by other actions. This is done to encourage that action methods can be called in parallel with no dependency on other methods (see discussion above).

parasharrajat · 2022-01-25T00:14:19Z

Could you please also update the template?

parasharrajat · 2022-01-25T01:58:37Z

+            Promise.resolve(PersonalDetails.getFromReportParticipants(_.values(simplifiedReports))).then(
+                details => configureReportNameAndIcon(_.values(simplifiedReports), details),
+            );


Suggested change

Promise.resolve(PersonalDetails.getFromReportParticipants(_.values(simplifiedReports))).then(

details => configureReportNameAndIcon(_.values(simplifiedReports), details),

);

const simplifiedReportsList = _.values(simplifiedReports);

PersonalDetails.getFromReportParticipants(simplifiedReportsList)

.then(details => configureReportNameAndIcon(simplifiedReportsList, details));

In this case, we should also return promise in case particpantEmails.length === 0 from PersonalDetails.getFromReportParticipants()

if (participantEmails.length === 0) { return Promise.resolve(); }

@parasharrajat Any Suggestion?

Yeah, that is fine. the interface should be consistent.

if (participantEmails.length === 0) { return Promise.resolve([]); // if details is array then empty array. }

parasharrajat · 2022-01-25T05:30:34Z

Still.... space needed between $ and url

Please follow the template. It is necessary for automation.

parasharrajat

LGTM.

cc: @tgolen

🎀 👀 🎀 C+ reviewed

OSBotify · 2022-01-25T18:02:58Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2022-01-25T20:33:35Z

🚀 Deployed to staging by @tgolen in version: 1.1.32-1 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

johnmlee101 · 2022-01-26T22:11:57Z

Heyo, this is causing #7417 so this will be reverted.

sobitneupane · 2022-01-27T08:16:59Z

@parasharrajat I have updated the branch which should probably solve the issue. It solves the issue in my side. Could you please verify? Should I create a new PR?

parasharrajat · 2022-01-27T08:56:04Z

Yeah, please create a new PR

OSBotify · 2022-02-01T18:04:39Z

🚀 Deployed to production by @roryabraham in version: 1.1.33-3 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

Separate report name and icon configuration from personal details

df12d41

sobitneupane requested a review from a team as a code owner January 24, 2022 07:38

MelvinBot requested review from parasharrajat and tgolen and removed request for a team January 24, 2022 07:38

parasharrajat suggested changes Jan 24, 2022

View reviewed changes

Resolve race condition in fetchChatReportsByIDs

57f3264

sobitneupane requested a review from parasharrajat January 24, 2022 18:47

parasharrajat suggested changes Jan 25, 2022

View reviewed changes

Make syntatic change in use of Promise

753ad92

parasharrajat suggested changes Jan 25, 2022

View reviewed changes

Comment thread src/libs/actions/PersonalDetails.js Outdated

Maintain consistent interface

8e19bf3

Julesssss assigned sobitneupane Jan 25, 2022

parasharrajat approved these changes Jan 25, 2022

View reviewed changes

tgolen approved these changes Jan 25, 2022

View reviewed changes

tgolen merged commit ecf7594 into Expensify:main Jan 25, 2022

OSBotify mentioned this pull request Jan 25, 2022

Deploy Checklist: New Expensify 2022-01-25 #7395

Closed

46 tasks

roryabraham mentioned this pull request Jan 26, 2022

Web - Lost Chat with a new user page after switch the tab #7412

Closed

This was referenced Jan 26, 2022

Android / iOS - Concierge is displayed with email address in LHN #7417

Closed

Revert "Separate report name and icon configuration from personal details" #7426

Merged

botify mentioned this pull request Feb 1, 2022

Private Room - Chair icon not displayed for private room created #7261

Closed

-            Promise.resolve(PersonalDetails.getFromReportParticipants(_.values(simplifiedReports))).then(
-                details => configureReportNameAndIcon(_.values(simplifiedReports), details),
-            );
+	     const simplifiedReportsList = _.values(simplifiedReports);
+            PersonalDetails.getFromReportParticipants(simplifiedReportsList)
+            .then(details => configureReportNameAndIcon(simplifiedReportsList, details));

Conversation

sobitneupane commented Jan 24, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

QA Steps

Tested On

Screenshots

Web

Mobile Web

Desktop

iOS

Android

Uh oh!

parasharrajat Jan 24, 2022

Choose a reason for hiding this comment

Uh oh!

sobitneupane Jan 24, 2022

Choose a reason for hiding this comment

Uh oh!

parasharrajat Jan 25, 2022

Choose a reason for hiding this comment

Uh oh!

parasharrajat Jan 24, 2022

Choose a reason for hiding this comment

Uh oh!

sobitneupane Jan 24, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

parasharrajat Jan 25, 2022

Choose a reason for hiding this comment

Uh oh!

parasharrajat commented Jan 25, 2022

Uh oh!

parasharrajat Jan 25, 2022

Choose a reason for hiding this comment

Uh oh!

sobitneupane Jan 25, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

parasharrajat Jan 25, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

parasharrajat commented Jan 25, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

parasharrajat left a comment

Choose a reason for hiding this comment

Uh oh!

OSBotify commented Jan 25, 2022

Uh oh!

OSBotify commented Jan 25, 2022

Uh oh!

johnmlee101 commented Jan 26, 2022

Uh oh!

sobitneupane commented Jan 27, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

parasharrajat commented Jan 27, 2022

Uh oh!

OSBotify commented Feb 1, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

sobitneupane commented Jan 24, 2022 •

edited

Loading

sobitneupane Jan 24, 2022 •

edited

Loading

sobitneupane Jan 25, 2022 •

edited

Loading

parasharrajat Jan 25, 2022 •

edited

Loading

parasharrajat commented Jan 25, 2022 •

edited

Loading

sobitneupane commented Jan 27, 2022 •

edited

Loading