Skip to content

Update to latest react-native-onyx version#7370

Merged
johnmlee101 merged 1 commit into
Expensify:mainfrom
kidroca:kidroca/fix-workspace-endless-loading
Jan 24, 2022
Merged

Update to latest react-native-onyx version#7370
johnmlee101 merged 1 commit into
Expensify:mainfrom
kidroca:kidroca/fix-workspace-endless-loading

Conversation

@kidroca

@kidroca kidroca commented Jan 24, 2022

Copy link
Copy Markdown
Contributor

Details

Update to latest react-native-onyx version
It includes a fix for handling null values in Onyx.set (and other write operations)

Fixed Issues

$ #7361

Tests

For Android and iOS only

  • Delete workspace and verify the app no longer hangs in infinite loading

QA Steps

For Android and iOS only

  • Delete workspace and verify the app no longer hangs in infinite loading

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

Screen.Recording.2022-01-24.at.21.02.29.mov

Mobile Web

image

Desktop

Screen.Recording.2022-01-24.at.21.05.32.mov

iOS

Screen.Recording.2022-01-24.at.21.04.06.mov

Android

2022-01-24_20-43-34.mp4

@kidroca kidroca marked this pull request as ready for review January 24, 2022 19:10
@kidroca kidroca requested a review from a team as a code owner January 24, 2022 19:10
@MelvinBot MelvinBot requested review from johnmlee101 and removed request for a team January 24, 2022 19:10

@johnmlee101 johnmlee101 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@johnmlee101 johnmlee101 merged commit 14a895f into Expensify:main Jan 24, 2022
@OSBotify

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by @johnmlee101 in version: 1.1.32-1 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify

OSBotify commented Feb 1, 2022

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by @roryabraham in version: 1.1.33-3 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants