Skip to content

Fix missing spanish translation account same error#73733

Merged
MarioExpensify merged 19 commits into
Expensify:mainfrom
huult:67639-fix-missing-spanish-translation-account-same-error
Dec 15, 2025
Merged

Fix missing spanish translation account same error#73733
MarioExpensify merged 19 commits into
Expensify:mainfrom
huult:67639-fix-missing-spanish-translation-account-same-error

Conversation

@huult

@huult huult commented Oct 29, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Details

Fixed Issues

$ #67639
PROPOSAL: #67639 (comment)

Tests

Same QA step

  • Verify that no errors appear in the JS console

Offline tests

QA Steps

Preconditions:

The app is set to Spanish (for the Admin).
Create a workspace as an Admin and add an employee.
Set up the same bank account for both the Admin and the Employee.

  1. Employee: Submit an expense in the workspace chat.
  2. Admin: Pay the expense using “Pay with Expensify.”
  3. Verify that the error message is displayed in Spanish.
  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
    • MacOS: Desktop
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I verified there are no new alerts related to the canBeMissing param for useOnyx
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Screen.Recording.2025-12-11.at.15.44.16.mp4
Android: mWeb Chrome
Screen.Recording.2025-12-11.at.15.45.56.mp4
iOS: Native
Screen.Recording.2025-12-11.at.15.47.49.mp4
iOS: mWeb Safari
Screen.Recording.2025-12-11.at.15.49.50.mp4
MacOS: Chrome / Safari
Screen.Recording.2025-12-11.at.15.39.19.mp4

@huult huult requested a review from a team as a code owner October 29, 2025 07:56
@melvin-bot melvin-bot Bot requested review from ZhenjaHorbach and removed request for a team October 29, 2025 07:56
@melvin-bot

melvin-bot Bot commented Oct 29, 2025

Copy link
Copy Markdown

Hey, I noticed you changed src/languages/en.ts in a PR from a fork. If you want to automatically generate translations for other locales, you can run the Generate static translations GitHub workflow.

Please look at the code and make sure there are no malicious changes before running the workflow.

If you have the K2 extension, you can simply click: [this button]

@melvin-bot

melvin-bot Bot commented Oct 29, 2025

Copy link
Copy Markdown

@ZhenjaHorbach Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@huult

huult commented Oct 29, 2025

Copy link
Copy Markdown
Contributor Author

@ZhenjaHorbach Do you know how I can connect to an Expensify Card?
Or if you’ve already connected with Expensify, could you share it or add my account (mrtrue955@gmail.com) as a delegate so I can test this case?

ZhenjaHorbach
ZhenjaHorbach reviewed Oct 29, 2025
View reviewed changes
Comment thread src/libs/ErrorUtils.ts Outdated
const currentLocale = IntlStore.getCurrentLocale();
if (currentLocale && currentLocale !== CONST.LOCALES.EN) {
if (error === 'The deposit and withdrawal accounts are the same.') {
return translateLocal('bankAccount.error.sameDepositAndWithdrawalAccount');

@ZhenjaHorbach ZhenjaHorbach Oct 29, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you fix eslint issue, please?

@ZhenjaHorbach ZhenjaHorbach Oct 29, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And let's write some tests for that

@huult huult Oct 29, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's done

@codecov

codecov Bot commented Oct 29, 2025 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines Coverage Δ
src/CONST/index.ts 85.84% <ø> (ø)
src/libs/TransactionPreviewUtils.ts 72.92% <50.00%> (-0.26%) ⬇️
src/libs/ErrorUtils.ts 43.00% <0.00%> (-1.33%) ⬇️
... and 11 files with indirect coverage changes

ZhenjaHorbach
ZhenjaHorbach reviewed Oct 29, 2025
View reviewed changes
Comment thread src/libs/ErrorUtils.ts Outdated
@huult

huult commented Oct 29, 2025

Copy link
Copy Markdown
Contributor Author

#73733 (comment) @ZhenjaHorbach could you check it?

ZhenjaHorbach
ZhenjaHorbach reviewed Oct 29, 2025
View reviewed changes
Comment thread src/libs/ErrorUtils.ts Outdated
@ZhenjaHorbach

ZhenjaHorbach commented Oct 29, 2025

Copy link
Copy Markdown
Contributor

@ZhenjaHorbach Do you know how I can connect to an Expensify Card? Or if you’ve already connected with Expensify, could you share it or add my account (mrtrue955@gmail.com) as a delegate so I can test this case?

You can try now

@melvin-bot

melvin-bot Bot commented Oct 30, 2025

Copy link
Copy Markdown

Hey, I noticed you changed src/languages/en.ts in a PR from a fork. For security reasons, translations are not generated automatically for PRs from forks.

If you want to automatically generate translations for other locales, an Expensify employee will have to:

  1. Look at the code and make sure there are no malicious changes.
  2. Run the Generate static translations GitHub workflow. If you have write access and the K2 extension, you can simply click: [this button]

Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running:

npx ts-node ./scripts/generateTranslations.ts --help

Typically, you'd want to translate only what you changed by running npx ts-node ./scripts/generateTranslations.ts --compare-ref main

@huult

huult commented Oct 30, 2025

Copy link
Copy Markdown
Contributor Author

@ZhenjaHorbach Here’s my employee account: zkebl.255@inbox.testmail.app. Could you add it to the same Expensify card as the admin?

@huult

huult commented Oct 30, 2025

Copy link
Copy Markdown
Contributor Author

@ZhenjaHorbach Can I share two test emails zkebl.testsameaccount01@inbox.testmail.app and zkebl.testsameaccount02@inbox.testmail.app . I’ll send you the OTPs so you can help me set up the same Expensify account for both, to test and verify this ticket.

@huult huult changed the title translate error message Fix missing spanish translation account same error Oct 31, 2025
@huult

huult commented Nov 3, 2025

Copy link
Copy Markdown
Contributor Author

@ZhenjaHorbach Could you help me when you have time?

@ZhenjaHorbach

ZhenjaHorbach commented Nov 4, 2025

Copy link
Copy Markdown
Contributor

@ZhenjaHorbach Could you help me when you have time?

Sorry for the delay
I will add today or tomorrow

@huult

huult commented Nov 10, 2025

Copy link
Copy Markdown
Contributor Author

I will add today or tomorrow

@ZhenjaHorbach It seems you still haven’t added it yet

@ZhenjaHorbach

ZhenjaHorbach commented Nov 27, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

@MarioExpensify
Could you please trigger adhoc builds for this PR?
And I suppose we need help from QA side
Since we don't have Expensify bank accounts

@MarioExpensify

MarioExpensify commented Nov 27, 2025

Copy link
Copy Markdown
Contributor

Ad hoc build triggered. Once its done I'll request help from QA.

@github-actions

github-actions Bot commented Nov 27, 2025

Copy link
Copy Markdown
Contributor

🚧 @MarioExpensify has triggered a test Expensify/App build. You can view the workflow run here.

@github-actions

This comment has been minimized.

Sign in to view
@huult

huult commented Dec 1, 2025

Copy link
Copy Markdown
Contributor Author

The build is completed. Waiting for QA to help verify the issue

@huult

huult commented Dec 3, 2025

Copy link
Copy Markdown
Contributor Author

#73733 (comment)

@MarioExpensify Could you please ask QA for help?

@MarioExpensify

MarioExpensify commented Dec 5, 2025

Copy link
Copy Markdown
Contributor

@huult QA requested here.

@huult

huult commented Dec 5, 2025

Copy link
Copy Markdown
Contributor Author

@MarioExpensify many thanks

@MarioExpensify

MarioExpensify commented Dec 5, 2025

Copy link
Copy Markdown
Contributor

@huult the ad-hoc is requesting update, we'll probably need to merge main and generate a new version, can you merge main and let me know?

@huult

huult commented Dec 6, 2025

Copy link
Copy Markdown
Contributor Author

@MarioExpensify it's done

@MarioExpensify

MarioExpensify commented Dec 8, 2025

Copy link
Copy Markdown
Contributor

Ad-hoc requested. Will request QA as soon as it finishes.

@github-actions

github-actions Bot commented Dec 8, 2025

Copy link
Copy Markdown
Contributor

🚧 @MarioExpensify has triggered a test Expensify/App build. You can view the workflow run here.

@github-actions

github-actions Bot commented Dec 8, 2025

Copy link
Copy Markdown
Contributor

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪
Built from App PR #73733.

Android 🤖 iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/73733/index.html https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/73733/index.html
Android iOS
Desktop 💻 Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/73733/NewExpensify.dmg https://73733.pr-testing.expensify.com
Desktop Web

👀 View the workflow run that generated this build 👀

@huult

huult commented Dec 11, 2025

Copy link
Copy Markdown
Contributor Author

@ZhenjaHorbach @MarioExpensify I’ve successfully set up the card and updated the code and screenshot. Could you check again?

Screen.Recording.2025-12-11.at.15.39.19.mp4

@ZhenjaHorbach

ZhenjaHorbach commented Dec 12, 2025

Copy link
Copy Markdown
Contributor

LGTM!

@melvin-bot melvin-bot Bot requested a review from MarioExpensify December 12, 2025 13:12
@MarioExpensify

MarioExpensify commented Dec 12, 2025

Copy link
Copy Markdown
Contributor

Awesome @huult, thank you!! Reviewing it now!

MarioExpensify
MarioExpensify approved these changes Dec 15, 2025
View reviewed changes

@MarioExpensify MarioExpensify left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good!

@MarioExpensify MarioExpensify merged commit 2634a0b into Expensify:main Dec 15, 2025
32 checks passed
@OSBotify OSBotify mentioned this pull request Dec 16, 2025
Closed
@OSBotify

OSBotify commented Dec 16, 2025

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/MarioExpensify in version: 9.2.79-0 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@huult huult mentioned this pull request Dec 17, 2025
Closed
8 tasks
@OSBotify

OSBotify commented Dec 17, 2025

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/MarioExpensify in version: 9.2.81-0 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify

OSBotify commented Dec 18, 2025

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/AndrewGable in version: 9.2.81-5 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 failure ❌
🍎 iOS 🍎 success ✅

@OSBotify

OSBotify commented Dec 18, 2025

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/AndrewGable in version: 9.2.81-5 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JmillsExpensify JmillsExpensify JmillsExpensify left review comments

+2 more reviewers

@ZhenjaHorbach ZhenjaHorbach ZhenjaHorbach approved these changes

@MarioExpensify MarioExpensify MarioExpensify approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@huult huult

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@huult @ZhenjaHorbach @MarioExpensify @OSBotify @JmillsExpensify