Skip to content

Highlight the 💳 Payment Method on the PaymentMethod list when its menu is active#7374

Merged
marcochavezf merged 7 commits into
Expensify:mainfrom
parasharrajat:menu-highlight
Jan 26, 2022
Merged

Highlight the 💳 Payment Method on the PaymentMethod list when its menu is active#7374
marcochavezf merged 7 commits into
Expensify:mainfrom
parasharrajat:menu-highlight

Conversation

@parasharrajat

@parasharrajat parasharrajat commented Jan 25, 2022

Copy link
Copy Markdown
Member

Details

Fixed Issues

$ #7353

Tests | QA Steps

  1. Open PaymentsPage .
  2. Click any payment method.
  3. It should be highlighted when menu is open for it.
  • Verify that no errors appear in the JS console

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web | Desktop | Mobile Web

image

iOS

Android

image

@parasharrajat parasharrajat requested a review from a team as a code owner January 25, 2022 01:53
@MelvinBot MelvinBot requested review from marcochavezf and removed request for a team January 25, 2022 01:53
Comment thread src/pages/settings/Payments/PaymentMethodList.js Outdated
Comment thread src/pages/settings/Payments/PaymentMethodList.js Outdated
Comment thread src/pages/settings/Payments/PaymentMethodList.js Outdated
@parasharrajat

Copy link
Copy Markdown
Member Author

Updated.

Comment thread src/pages/settings/Payments/PaymentMethodList.js Outdated
@marcochavezf marcochavezf merged commit 45f5e38 into Expensify:main Jan 26, 2022
@OSBotify

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify

OSBotify commented Feb 1, 2022

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by @marcochavezf in version: 1.1.33-4 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify

OSBotify commented Feb 2, 2022

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by @sketchydroide in version: 1.1.34-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants