Reduce imageHeight to windowHeight if greater

[sobitneupane]

Details

Reduce height of image to height of window if it is greater than window's height.

Fixed Issues

$ #7012

Tests

• Send a large image
• Open attachment to see if image height fits within the window

QA Steps

• Send a large image
• Open attachment to see if image height fits within the window

Tested On

• Web
• Mobile Web
• Desktop
• iOS
• Android

Screenshots

Web

Mobile Web

Desktop

iOS

Android

[parasharrajat]

@sobitneupane Please add screenshots for other platforms.

[sobitneupane]

@sobitneupane Please add screenshots for other platforms.

I have added for Web and mWeb. I don't have accessibility of macOS and IOS.

[parasharrajat]

Ok, I tested the changes. But now when we zoom the image it does not take the full width of the screen.

[sobitneupane]

Ok, I tested the changes. But now when we zoom the image it does not take the full width of the screen.

It is because we have used 2 as scale to zoomin for doubleClick. It can be zoomed further using pinch-to-zoom.

if (isDoubleClick) {
    this.zoom.centerOn({
        x: 0,
        y: 0,
        scale: 2,
        duration: 100,
    });
}

[deetergp]

Overall the PR looks good and I greatly appreciate the comments explaining the "why" of each bit of logic. Thanks! You've got some merge conflicts you need to resolve, but once that's done it will be good to go, IMO!

[parasharrajat]

LGTM:

cc: @deetergp

🎀 👀 🎀 C+ reviewed

[OSBotify]

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

[OSBotify]

🚀 Deployed to staging by @deetergp in version: 1.1.33-4 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

[OSBotify]

🚀 Deployed to production by @sketchydroide in version: 1.1.34-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅